Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
#2278017: When a content entity type providing module is uninstalled, the entities are not fully deleted, leaving broken reference introduced a new API for validating module uninstall readiness, which is explained in the change record. This API moved uninstall dependency messages to the module uninstall form. These are now in addition to the standard dependency messages that appear on the module install form. Let's remove the messages from the install form because all dependency checks are moving to the new API.
From the install form:
From the uninstall form:
Proposed resolution
Remaining tasks
User interface changes
"Required by:" lines are removed from the install form.
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | uninstall.png | 83.87 KB | cilefen |
| #5 | install.png | 84.9 KB | cilefen |
Comments
Comment #1
jhodgdonThe issue summary and title seem to contradict each other? The issue summary says the required message are being removed, and the title says they are being moved from install to uninstall?
Comment #2
cilefen CreditAttribution: cilefen commentedThis is postponed on #2392293: Refactor hook_system_info_alter implementations to use ModuleUninstallValidatorInterface.
Comment #3
cilefen CreditAttribution: cilefen commentedtimplunkett and I cooked this up on IRC, maybe I misstated our goal?
Comment #4
jhodgdonActually I think it was just a typo. Updated summary. Check if it's accurate?
But... Regarding this proposal, to me the Modules page is the central place to go, to find information about modules. So I am not sure I agree with the idea of removing one part of the information from this page.
As another note, the information about dependencies has relevance for updates as well as uninstalls -- for instance, if you wanted to update Views or Migrate or Rules or Media or something like that from a -2.x to a -3.x version (if they completely redid the API, which happens occasionally), you would also need to update the corresponding Views Foo Widget, Migrate Bar, Rules Baz Pack, and Specific Type of Media modules to compatible versions. It's probably obvious that Views Foo Widget depends on Views, and that updating Views may cause incompatibilities, but it may be less obvious that Views Foo Widget depends on Views Bar Bonus Pack, which could have eliminated code the Foo Widget depends on in an update.
So I think just having that information on the Uninstall page is not the best idea. Just my 2 cents...
Comment #5
cilefen CreditAttribution: cilefen commentedComment #6
jhodgdonYeah, exactly. I personally think it's quite useful to have that information on the Install page, because it's useful both for uninstalling and for considering updates. I do not think it should be removed from the Install page.
Comment #7
alexpottIf the dependency information and uninstall information is relevant for updates perhaps it should go on the updates page?
Post #2392293: Refactor hook_system_info_alter implementations to use ModuleUninstallValidatorInterface dependency messages are on the uninstall and the listing/install page.
Comment #8
mgiffordOk, think that this can be worked on now.