First off I want to say this module is a great idea and thanks for getting it rolling. But can we implement composer_manager support for the YAML support? It would make the module much more portable and available to hosted sites that can't add PHP extensions (which in themselves can sometimes be tricky to get working when PECL is also not available).

Attached patch adds these changes but also supports existing YAML pattern as a fallback.

CommentFileSizeAuthor
#5 support-for-YAML-and-Behat-libraries-2382683-4.patch4.67 KBRajab Natshah
#2 behat_ui-2382683-composeryaml.patch3.49 KBRosenstrauch
behat_ui-composer_manager_support-####-####.patch3.24 KBjpwarren00
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

caiosba’s picture

caiosba CreditAttribution: caiosba commented
Assigned: Unassigned » caiosba
Status: Active » Needs review

Many thanks for that! I'll review and apply it soon.

Rosenstrauch’s picture

Rosenstrauch CreditAttribution: Rosenstrauch commented
FileSize
behat_ui-2382683-composeryaml.patch3.49 KB

heres that patch rerolled against 2.x

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented

Notice: Undefined variable: behat_config_path in load_behat_config() (line 631

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented

load_behat_config

I think we should use the behat config as it was made by behat. as some time we do have imports

Array
(
    [imports] => Array
        (
            [0] => behat.mycustom-config-file.yml
        )

)

I will try to use the /vendor/autoload.php from the same behat.
and load configs as behat do it.

Working on a fix.

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented
FileSize
support-for-YAML-and-Behat-libraries-2382683-4.patch4.67 KB

This patch will let the module work using the Same Behat configuration library. you could use any behat libraries, which was included with your Behat ..

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented

  • RajabNatshah committed ab29411 on 7.x-2.x 
    Issue #2382683 by RajabNatshah, Rosenstrauch, jpwarren00, caiosba:...
Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented
Assigned: caiosba » Unassigned

  • RajabNatshah committed ab29411 on 8.x-1.x 
    Issue #2382683 by RajabNatshah, Rosenstrauch, jpwarren00, caiosba:...
Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah as a volunteer and at Vardot, Webship commented
Status: Needs review » Fixed
Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah as a volunteer and at Vardot, Webship commented
Status: Fixed » Closed (fixed)