[D6] Sur.ly

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2374429

Project 2: https://www.drupal.org/node/2374439

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxsurdotly1872684git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

All fine in code and pareview.sh

All fine in Pareview.sh

Manual Review

Individual user account

Yes, follows the guideline.

No duplication

Yes, does not duplicate

Master Branch

Yes, follows the Master Branch.

Licensing

No, you need to follow this from GPL 3 -

Give prominent notice with the combined library that part of it
   is a work based on the Library, and explaining where to find the
   accompanying uncombined form of the same work.

But anyway you need to remove it, read next bullet point.

3rd party assets/code

Does not follow - please don't pack surly-sdk-php with the package as stated here, unless you are the original maintainer: https://www.drupal.org/node/422996

README.txt/README.md

Yes, follows the guide lines

Code long/complex enough for review

Yes, has more then 5 functions and more then 120 lines of code.

Secure code

Yes, could not find any security problems

Coding style & Drupal API usage

1. (*) I followed the README instructions and got: "There were errors during plugin installation. Try to reinstall it. If you still see this message, please let us now at contact@surdotly.com.". I tried reinstalling, same issue.
2. (*) I can't really see where you use the required libraries API?.
3. (*) In install file do not use include_once, require the file via libraries API. Read more here https://www.drupal.org/node/1342220

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

PAReview: Individual user account

It seems you are using a non-individual account.
All user accounts are for individuals. Accounts created for more than one user or those using anonymous mail services will be blocked when discovered (see Get a Drupal.org account).
Please note that organization accounts cannot be approved for git commit access. See https://drupal.org/node/1966218 and https://drupal.org/node/1863498 for details on what is/isn't allowed. Please update your user profile so that we don't have to assume that this is a group account.

Please do not RTBC your own project application.

Despite the above reviewer's advice, you should remove the license declaration from all files. The Drupal.org packaging system will add a LICENSE.txt file to your module when it is packaged. I'd also encourage you to improve your commit messages going forward, as "Improving code" is not a very useful description of your purpose for people looking at your module later.

When that's done, please set this issue back to "Needs review" and I'll come back to give this a final look.

I have placed the required library in "sites/all/libraries/surly" and installed the module. The module successfully installed with no error.
But when I went to "admin/config/content/surly", I'm seeing the following error.

There were errors during plugin installation. Try to reinstall it. If you still see this message, please let us now at contact@surdotly.com.

I added some domains. The domains added successfully. Then when I went again to "admin/config/content/surly", the above error still exist.

Hi. You should provide the hook_help to allow site builders to find information about your module using Drupal UI.

Change the name to
[D6] & [D7] Sur.ly

Installation

I downloaded the module and installed it along with its dependencies. I found out that right after installation the module display a message requiring the user to install a package (fine), but the provided link is broken (http://sur.ly/plugins/surly-sdk-php.zip), the correct onw is probably http://cdn.sur.ly/plugins/surly-sdk-php.zip?v=2.4.0, unless of course you have a customized SDK package (then you should check if you're allowed to change the standard package).

Once installed I went to the config page, it still shows the message:
"There were errors during plugin installation. Try to reinstall it. If you still see this message, please let us now at contact at surdotly.com."

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.