Properly deprecate ForumManagerInterface::getParents().

Done

I don't think it's disruptive, and already marked as deprecated

I'm not so sure we should remove convenience methods like this, but reviewing anyway.

The patch in #2 still applies, but running unit tests leads to this error:

[29-Mar-2015 16:01:33 UTC] PHP Fatal error:  Call to undefined method Mock_EntityStorageInterface_1968d3ad::loadAllParents() in /Users/paulmitchum/projects/drupal8/core/modules/forum/src/Breadcrumb/ForumListingBreadcrumbBuilder.php on line 36

+++ b/core/modules/forum/src/ForumManagerInterface.php
@@ -57,20 +57,6 @@ public function getIndex();
-   * @deprecated Scheduled to be removed in 9.0.x, see
-   *   https://www.drupal.org/node/2371593.

At this point in the release cycle, this should be marked as to be removed before 9.0.0.

Needs a reroll.

$ git apply forum-parents-wrapper-2371593.2.patch 
error: patch failed: core/modules/forum/src/Breadcrumb/ForumListingBreadcrumbBuilder.php:30
error: core/modules/forum/src/Breadcrumb/ForumListingBreadcrumbBuilder.php: patch does not apply
error: patch failed: core/modules/forum/src/Breadcrumb/ForumNodeBreadcrumbBuilder.php:30
error: core/modules/forum/src/Breadcrumb/ForumNodeBreadcrumbBuilder.php: patch does not apply

Patch re-rolled comment 2

Rescoping a little bit here so we're properly marking the deprecation.

The patch in #9 applies. Here's some review:

1. +++ b/core/modules/forum/src/Breadcrumb/ForumListingBreadcrumbBuilder.php
   @@ -35,7 +35,10 @@ public function build(RouteMatchInterface $route_match) {
   +    /* @var \Drupal\taxonomy\TermStorageInterface $taxonomy_storage */
   +    $taxonomy_storage = $this->entityManager
   +      ->getStorage('taxonomy_vocabulary');
   +    $parents = $taxonomy_storage->loadAllParents($term_id);
   
   +++ b/core/modules/forum/src/Breadcrumb/ForumNodeBreadcrumbBuilder.php
   @@ -31,7 +31,10 @@ public function build(RouteMatchInterface $route_match) {
   +    /* @var \Drupal\taxonomy\TermStorageInterface $taxonomy_storage */
   +    $taxonomy_storage = $this->entityManager
   +      ->getStorage('taxonomy_vocabulary');
   +    $parents = $taxonomy_storage->loadAllParents($route_match->getParameter('node')->forum_tid);
   

   Entity manager is deprecated, so just get the entity storage manager service for the entity type.

2. +++ b/core/modules/forum/src/ForumManager.php
   @@ -462,13 +462,6 @@ public function resetCache() {
   -  public function getParents($tid) {
   
   +++ b/core/modules/forum/src/ForumManagerInterface.php
   @@ -57,20 +57,6 @@ public function getIndex();
   -   * Fetches the parent forums for a given forum.
   -   *
   -   * @param int $tid
   -   *   Term ID.
   -   *
   -   * @return array
   -   *   Array of parent terms.
   -   *
   -   * @deprecated Scheduled to be removed in 9.0.x, see
   -   *   https://www.drupal.org/node/2371593.
   -   */
   -  public function getParents($tid);
   

   We can't delete the method yet, since it's deprecated for removal in d9.

Marking issue for Drupal Mumbai Code Sprint

btw I think better to move it out of storage handler back to forum manager and convert to entity query, this way it will be independent from storage

maybe it needs follow-up? @larowlan any thoughts?

The patch doesn't apply anymore. Added a Reroll tag.

Rewriting from scratch to modern standards.

Updating Issue title and Summary.

Looks good. The test isn't very explicit as it just compares the two calls but I think that's enough for this simple deprecation.

Committed 04051f2 and pushed to 8.8.x. Thanks!

Publish change record