Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
taxonomy.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Oct 2014 at 18:55 UTC
Updated:
23 Nov 2014 at 22:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
crazyrohila commentedRemoved taxonomy_term_load_parents_all() from taxnomy.module
Comment #2
oenie commentedI've removed some extra @todo comment and changed the documentation in the interface.
Comment #3
ashutoshsngh commentedApplied patch and checked.It works well changing to RTBC.
Comment #4
alexpottCan someone attach this issue to the correct CR that announced the replacement of taxonomy_term_load_parents_all
Comment #5
a_thakur commentedComment #6
a_thakur commentedAdded link to the the change record: https://www.drupal.org/node/2328205. Changing to RTBC.
Comment #7
alexpottThis documentation now seems out of sync - but it was just wrong before too since it is a public method on an interface. I think we should still be saying that this is just a wrapper.
This @todo should still in exist but in changed from FormManagerInterface::getParents() was just a wrapper to TermStorage::loadAllParents(). We should remove FormManagerInterface::getParents() in 9.x This patch should be adding the deprecated notice to this function and creating the postponed 9.x issue to remove it.
Comment #8
bertramakers commentedI'm sprinting at DrupalCamp Ghent and we're looking into this issue.
I'll create the issue to remove the getParents() method from the ForumManagerInterface in 9.x, and create a patch with an interdiff for the todo comment.
Comment #9
bertramakers commentedI just created #2371593: Properly deprecate ForumManagerInterface::getParents()..
Comment #10
bertramakers commentedComment #11
lobsterr commentedApplied the patch and checked the patch. Everything is ok for me.
Comment #12
pfrenssenThis looks ready. Thanks!
Comment #13
pfrenssenComment #14
alexpottThis issue is a prioritized change (deprecated function removal) as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption. Committed 0f438fa and pushed to 8.0.x. Thanks!