Drupal core's own deprecation testing results

While using phpstan locally memory is my biggest concern. Are only adding phpstan support or would we be using https://github.com/mglaman/phpstan-drupal?

#3039472: Fix phpstan XML output is rolled out so this should work better. Same as #4.

Also trying this in a contrib module: #3044414: Add phpstan to ensure the CDN module is compatible with Drupal 9 the day it is released, specifically the patch at #3044414-6: Add phpstan to ensure the CDN module is compatible with Drupal 9 the day it is released.

Let's run again.

Now with getMock() removed, it should be much less.

I devised this script to tell apart Legacy deprecations from the non-legacy ones. So far a legacy deprecation is one that is in a *Legacy*Test.php file or that contains WebTestBase in the error, assuming all of those left are actual legacy. Since we can only go based on the file name or error, it is not possible to do very creative matching, but I believe the goal is to identify top items.

I also attached the full results based on data from #11. These are the ones that at least occur 5 times:

688 | Call to deprecated function format_string()
86  | Call to deprecated method l() of class Drupal
38  | Call to deprecated method getUsername() of class Drupal\user\Entity\User
35  | Call to deprecated method setFieldNames() of class Drupal\Core\Entity\Sql\DefaultTableMapping
30  | Call to deprecated method url() of class Drupal\Core\Form\FormBase
29  | Call to deprecated function file_uri_scheme()
22  | Call to deprecated method install() of class Drupal\Core\Extension\ThemeHandler
19  | Call to deprecated method lookupDestinationId() of class Drupal\migrate\Plugin\MigrateIdMapInterface
16  | Call to deprecated method clearCachedDefinitions() of class Drupal\Core\Entity\EntityTypeRepository
13  | Call to deprecated method setExtraColumns() of class Drupal\Core\Entity\Sql\DefaultTableMapping
12  | Access to deprecated property $entityContextDefinition of class Drupal\Core\Plugin\Context\ContextDefinition.
12  | Call to deprecated method prepareLegacyRequest() of class Drupal\Core\DrupalKernel
11  | Call to deprecated function drupal_get_profile()
11  | Call to deprecated method drupalGetHeaders() of class Drupal\Tests\BrowserTestBase
9   | Call to deprecated method l() of class Drupal\Core\Controller\ControllerBase
9   | Call to deprecated method entityManager() of class Drupal
9   | Call to deprecated method install() of class Drupal\Core\Extension\ThemeHandlerInterface
8   | Call to deprecated function statistics_get()
8   | Call to deprecated method l() of class Drupal\Core\Form\FormBase
8   | Call to deprecated function file_stream_wrapper_valid_scheme()
7   | Call to deprecated method initializeEntityContextDefinition() of class Drupal\Core\Plugin\Context\ContextDefinition.
7   | Call to deprecated function drupal_render_root()
6   | Call to deprecated method url() of class Drupal\Core\Controller\ControllerBase
6   | Call to deprecated function system_list()
5   | Call to deprecated function _file_save_upload_from_form()
5   | Call to deprecated method isNewRevision() of class Drupal\node\Entity\NodeType

We noticed that some of the long tail in the above results are actually just autoloading errors. I stripped those manually with an emacs macro and put the data here:
https://docs.google.com/spreadsheets/d/1hAtFhN26UG0QpKxMqUi3-fyoMs54hYrV...

Somehow there are a few more things being counted than there were on Mar. 19 which should only have happened with either massively large new things deprecated in core (otherwise we would have removed the usages), or new deprecations in dependencies. I think. :)

I know how to check if it's the result of new dependency deprecations: queue the patch against 8.7.x. :P Might as well hit 8.6.x and earlier while we're at it to get some "historical"-ish data.

8.6.x compatible patch

Uploading yet again for clear data - results mapping.

Overall numbers are down like this:

May 31st:
Errors found outside legacy tests: 1405
Errors found in legacy tests: 179

July 1:
Errors found outside legacy tests: 1339
Errors found in legacy tests: 180

These are left with at least 5 occurrences outside of legacy tests:

687 | Call to deprecated function format_string()
86  | Call to deprecated method l() of class Drupal
35  | Call to deprecated method setFieldNames() of class Drupal\Core\Entity\Sql\DefaultTableMapping
30  | Call to deprecated method url() of class Drupal\Core\Form\FormBase
24  | Call to deprecated method install() of class Drupal\Core\Extension\ThemeHandler
19  | Call to deprecated method lookupDestinationId() of class Drupal\migrate\Plugin\MigrateIdMapInterface
16  | Call to deprecated method clearCachedDefinitions() of class Drupal\Core\Entity\EntityTypeRepository
13  | Call to deprecated method setExtraColumns() of class Drupal\Core\Entity\Sql\DefaultTableMapping
12  | Call to deprecated method prepareLegacyRequest() of class Drupal\Core\DrupalKernel
12  | Access to deprecated property $entityContextDefinition of class Drupal\Core\Plugin\Context\ContextDefinition.
11  | Call to deprecated function drupal_get_profile()
11  | Call to deprecated method drupalGetHeaders() of class Drupal\Tests\BrowserTestBase
9   | Call to deprecated method install() of class Drupal\Core\Extension\ThemeHandlerInterface
9   | Call to deprecated method l() of class Drupal\Core\Controller\ControllerBase
9   | Call to deprecated method entityManager() of class Drupal
8   | Call to deprecated function statistics_get()
8   | Call to deprecated method l() of class Drupal\Core\Form\FormBase
7   | Call to deprecated method initializeEntityContextDefinition() of class Drupal\Core\Plugin\Context\ContextDefinition.
7   | Call to deprecated function drupal_render_root()
6   | Call to deprecated method url() of class Drupal\Core\Controller\ControllerBase
6   | Call to deprecated function system_list()
5   | Call to deprecated function _file_save_upload_from_form()
5   | Call to deprecated method isNewRevision() of class Drupal\node\Entity\NodeType

Report generated with the script from #12.

So now we can half the remaining deprecated APIs used by completing #2228741: Replace calls to format_string() with Drupal\Component\Render\FormattableMarkup. Reviews welcome there.

#2228741: Replace calls to format_string() with Drupal\Component\Render\FormattableMarkup is in, let's see again :)

Yay, we are significantly down, these are the ones left with 5 or more uses:

-------------------------------
Errors found outside legacy tests: 656
Errors found in legacy tests: 185
-------------------------------
Counts of errors outside legacy tests:

86  | Call to deprecated method l() of class Drupal
35  | Call to deprecated method setFieldNames() of class Drupal\Core\Entity\Sql\DefaultTableMapping
30  | Call to deprecated method url() of class Drupal\Core\Form\FormBase
24  | Call to deprecated method install() of class Drupal\Core\Extension\ThemeHandler
19  | Call to deprecated method lookupDestinationId() of class Drupal\migrate\Plugin\MigrateIdMapInterface
16  | Call to deprecated method clearCachedDefinitions() of class Drupal\Core\Entity\EntityTypeRepository
13  | Call to deprecated method setExtraColumns() of class Drupal\Core\Entity\Sql\DefaultTableMapping
12  | Call to deprecated method prepareLegacyRequest() of class Drupal\Core\DrupalKernel
12  | Access to deprecated property $entityContextDefinition of class Drupal\Core\Plugin\Context\ContextDefinition.
11  | Call to deprecated function drupal_get_profile()
11  | Call to deprecated method drupalGetHeaders() of class Drupal\Tests\BrowserTestBase
9   | Call to deprecated method l() of class Drupal\Core\Controller\ControllerBase
9   | Call to deprecated method install() of class Drupal\Core\Extension\ThemeHandlerInterface
9   | Call to deprecated method entityManager() of class Drupal
8   | Call to deprecated function statistics_get()
8   | Call to deprecated method l() of class Drupal\Core\Form\FormBase
7   | Call to deprecated function drupal_render_root()
7   | Call to deprecated method initializeEntityContextDefinition() of class Drupal\Core\Plugin\Context\ContextDefinition.
6   | Call to deprecated function system_list()
6   | Call to deprecated method url() of class Drupal\Core\Controller\ControllerBase
5   | Call to deprecated function _file_save_upload_from_form()
5   | Call to deprecated method isNewRevision() of class Drupal\node\Entity\NodeType

New issues:

- #3067196: Properly deprecate LinkGeneratorTrait would cover the current top item thanks @alexpott.
- #3067206: Properly deprecate drupalGetHeaders() method of Drupal\Tests\BrowserTestBase covers 11 uses as well, thanks @voleger :)

Also #2958925: Properly deprecate drupal_get_profile()

And #2776031: Properly deprecate ThemeHandlerInterface install() and uninstall() also replace usage

And #3067347: Undeprecate DefaultTableMapping::setFieldNames() and ::setExtraColumns(), mark them as internal instead :)

My new plan is to start at the bottom and work my way up.. the bottom issues are much easier.. ;-)

#3067361: Properly deprecate NodeType::isNewRevision

I lied. There are more than 5 usages of NodeType::isNewRevision() they are just not type-hinted correctly.. :-(

Looking at the 1 item results, there was some suspicious ones especially around single use file.inc functions. Turns out there is also *DeprecationTest.php files (4 of them) that invoke deprecated APIs on purpose. Filtering those out, running on the same data set from yesterday, it is down 5% from 656 to 623 :) There are still deprecated code invoked from deprecated code that we cannot detect this way, so only actually removing the APIs and seeing things possibly fail will uncover those. The 623 errors come from 262 types of things, but due to uses of traits, a lot of them are the same thing as well.

Thanks to suggestion by @berdir, we should also ignore anything in 'modules/simpletest/*' and 'src/Tests/*', which further cuts down to 596 from 623 still using the same data set from yesterday.

Here is a new parsing script to combine some things, and to manually weed out the rest of the legacy test usage cases, and some other special cases that can be ignored right now.

-------------------------------
Errors in need of review: 346 (78 distinct)
Errors found in legacy tests: 322 (223 distinct)
Deprecated code called from Deprecated Code: 15 (8 distinct)
Known errors postponed on D9 branch opening: 13 (10 distinct)
Autoloading Errors: 28 (27 distinct)
Cache Tag Unclear errors: 4 (4 distinct)
-------------------------------
Errors in need of review:

86  | 4ae932 | Call to deprecated method l() of class Drupal | 
28  | 03770f | Call to deprecated method url() of class Drupal\Core\Form\FormBase | 
19  | c20a22 | Call to deprecated method lookupDestinationId() of class Drupal\migrate\Plugin\MigrateIdMapInterface | 
16  | e7ee56 | Call to deprecated method clearCachedDefinitions() of class Drupal\Core\Entity\EntityTypeRepository | 
12  | 737cec | Access to deprecated property $entityContextDefinition of class Drupal\Core\Plugin\Context\ContextDefinition. | 
12  | 46f674 | Call to deprecated method prepareLegacyRequest() of class Drupal\Core\DrupalKernel | 
11  | 186bb5 | Call to deprecated function drupal_get_profile() | 
9   | aeec37 | Call to deprecated method entityManager() of class Drupal | 
8   | 14a3cd | Call to deprecated function statistics_get() | 
8   | 957a6c | Usage of deprecated trait Drupal\Core\Field\AllowedTagsXssTrait | 
7   | 8120ab | Call to deprecated function drupal_render_root() | 
7   | 3524c4 | Call to deprecated method initializeEntityContextDefinition() of class Drupal\Core\Plugin\Context\ContextDefinition. | 
6   | 9cd736 | Call to deprecated function system_list() | 
6   | b8178f | Call to deprecated method url() of class Drupal\Core\Controller\ControllerBase | 
6   | dc2c3d | Class extends deprecated class Drupal\Core\Entity\EntityHandlerBase | 
5   | 565426 | Call to deprecated function _file_save_upload_from_form() | 
5   | e6b952 | Call to deprecated method isNewRevision() of class Drupal\node\Entity\NodeType | 
5   | 2216da | Usage of deprecated trait Drupal\Core\Routing\UrlGeneratorTrait | 
4   | 2d13e4 | Call to deprecated function deprecation_test_function() | 
4   | edcb4f | Instantiation of deprecated class Drupal\migrate\Plugin\migrate\process\DedupeEntity | 
4   | 3cdb8a | Instantiation of deprecated class Drupal\migrate\Plugin\migrate\process\Migration | 
3   | fce998 | Call to deprecated function config_get_config_directory() | 
3   | 262469 | Fetching class constant class of deprecated class Drupal\Component\Plugin\ConfigurablePluginInterface | 
2   | b5004b | Call to deprecated function language_negotiation_url_prefixes() | 
2   | e0a0b4 | Call to deprecated method addAutowiringType() of class Symfony\Component\DependencyInjection\Definition | 
2   | 3145a7 | Call to deprecated method cacheUntilConfigurationChanges() of class Drupal\Core\Access\AccessResult | 
2   | 4d6657 | Call to deprecated method getLabelCallback() of class Drupal\Core\Entity\EntityTypeInterface | 
2   | 3a0f6f | Call to deprecated method getSectionListFromId() of class Drupal\layout_builder\Plugin\SectionStorage\DefaultsSectionStorage | 
2   | b65d10 | Call to deprecated method hashEquals() of class Drupal\Component\Utility\Crypt | 
2   | 789667 | Call to deprecated method isSafe() of class Drupal\Component\Utility\SafeMarkup | 
2   | c74175 | Call to deprecated method loadFromRoute() of class Drupal\layout_builder\SectionStorage\SectionStorageManager | 
2   | 22f199 | Call to deprecated method lookupDestinationId() of class Drupal\migrate\Plugin\migrate\id_map\Sql | 
2   | d936a8 | Call to deprecated method setRevisionAuthorId() of class Drupal\node\Entity\Node | 
2   | 9a9621 | Call to deprecated method setSectionList() of class Drupal\layout_builder\Plugin\SectionStorage\SectionStorageBase | 
2   | f9b6b7 | Call to deprecated method toArray() of class Drupal\Component\Version\Constraint | 
2   | 524ff7 | Call to deprecated method url() of class Drupal\Core\Entity\EntityBase | 
2   | 6ebd08 | Call to method isSafe() of deprecated class Drupal\Component\Utility\SafeMarkup | 
2   | 2a4b4f | Fetching class constant class of deprecated class Drupal\Core\Entity\EntityManagerInterface | 
2   | 19fb0b | Instantiation of deprecated class Drupal\Core\Entity\Sql\SqlContentEntityStorageSchemaConverter | 
2   | 6dc55e | Usage of deprecated trait Drupal\Core\Routing\LinkGeneratorTrait | 
1   | 257d1f | Access to deprecated property $authenticationProviders of class Drupal\rest\Plugin\views\display\RestExport in core/modules/rest/src/Plugin/views/display/RestExport.php on line 150 | 
1   | 411a38 | Access to deprecated property $entityManager of class Drupal\Core\Entity\EntityForm in core/lib/Drupal/Core/Entity/ContentEntityForm.php on line 59 | 
1   | 620883 | Access to deprecated property $initialAccountId of class Drupal\Core\Session\AccountProxy in core/lib/Drupal/Core/Session/AccountProxy.php on line 175 | 
1   | d4ce31 | Call to deprecated function file_upload_max_size() in core/modules/file/file.module on line 964 | 
1   | 669467 | Call to deprecated function menu_primary_local_tasks() in core/includes/menu.inc on line 153 | 
1   | ba0feb | Call to deprecated function menu_secondary_local_tasks() in core/includes/menu.inc on line 154 | 
1   | 070480 | Call to deprecated method __construct() of class Drupal\file\FileUsage\FileUsageBase in core/modules/file/src/FileUsage/DatabaseFileUsageBackend.php on line 40 | Bad deprecated tag in the constructor
1   | bee96a | Call to deprecated method doLoadRevisionFieldItems() of class Drupal\Core\Entity\ContentEntityStorageBase in core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php on line 620 | 
1   | b48306 | Call to deprecated method ensureBackwardCompatibilityConfiguration() of class Drupal\Core\Entity\EntityReferenceSelection\SelectionPluginBase in core/lib/Drupal/Core/Entity/EntityReferenceSelection/SelectionPluginBase.php on line 66 | 
1   | da955c | Call to deprecated method fixTableNames() of class Drupal\views\Entity\View in core/modules/views/src/Entity/View.php on line 304 | 
1   | ab8b68 | Call to deprecated method getMaxAge() of class Drupal\Core\Datetime\FormattedDateDiff in core/tests/Drupal/Tests/Core/Datetime/DateTest.php on line 425 | 
1   | 07b854 | Call to deprecated method getParents() of class Drupal\forum\ForumManagerInterface in core/modules/forum/src/Controller/ForumController.php on line 157 | 
1   | 982184 | Call to deprecated method getSource() of class Drupal\twig_loader_test\Loader\TestLoader in core/modules/system/tests/modules/twig_loader_test/src/Loader/TestLoader.php on line 17 | 
1   | 432cb5 | Call to deprecated method getStatus() of class Drupal\comment\CommentInterface in core/modules/comment/src/CommentForm.php on line 143 | 
1   | 50482e | Call to deprecated method getStatus() of class Drupal\comment\Entity\Comment in core/modules/comment/tests/src/Kernel/Migrate/d7/MigrateCommentTest.php on line 74 | 
1   | a901dc | Call to deprecated method getStyleSheetsRemove() of class Drupal\Core\Theme\ActiveTheme in core/lib/Drupal/Core/Asset/AssetResolver.php on line 167 | 
1   | 739c76 | Call to deprecated method handleHiddenType() of class Drupal\Core\Entity\EntityDisplayBase in core/lib/Drupal/Core/Entity/EntityDisplayBase.php on line 256 | 
1   | a8e7e2 | Call to deprecated method hasLabelCallback() of class Drupal\Core\Entity\EntityTypeInterface in core/modules/jsonapi/src/JsonApiResource/ResourceObject.php on line 287 | 
1   | c2dfa1 | Call to deprecated method isNewRevision() of class Drupal\node\NodeTypeInterface in core/modules/node/tests/src/Kernel/Migrate/d7/MigrateNodeTypeTest.php on line 57 | 
1   | 302b29 | Call to deprecated method prepareComment() of class Drupal\comment\Plugin\migrate\source\d6\Comment in core/modules/comment/src/Plugin/migrate/source/d6/Comment.php on line 37 | 
1   | 454fc6 | Call to deprecated method resolveBackwardCompatibilityConfiguration() of class Drupal\Core\Entity\EntityReferenceSelection\SelectionPluginBase in core/lib/Drupal/Core/Entity/EntityReferenceSelection/SelectionPluginBase.php on line 57 | 
1   | 38ed4c | Call to deprecated method setDefault() of class Drupal\Core\Extension\ThemeHandler in core/tests/Drupal/KernelTests/Core/Theme/ThemeSettingsTest.php on line 104 | 
1   | ddd776 | Call to deprecated method url() of class Drupal\views\Plugin\views\display\PathPluginBase in core/modules/views/src/Plugin/views/display/PathPluginBase.php on line 445 | 
1   | 1845cc | Call to deprecated method url() of class Drupal\views\Plugin\views\wizard\WizardPluginBase in core/modules/views/src/Plugin/views/wizard/WizardPluginBase.php on line 218 | 
1   | b98414 | Call to deprecated method validateTags() of class Drupal\Core\Cache\Cache. in core/tests/Drupal/Tests/Core/Cache/CacheTest.php on line 54 | 
1   | b33594 | Class extends deprecated class PHPUnit\Framework\BaseTestListener in core/tests/Drupal/Tests/Listeners/DrupalListener.php on line 21 | 
1   | 2ce122 | Class implements deprecated interface Drupal\Core\Field\PluginSettingsInterface in core/lib/Drupal/Core/Field/PluginSettingsBase.php on line 13 | 
1   | 58f958 | Class implements deprecated interface Twig\Loader\ExistsLoaderInterface in core/lib/Drupal/Core/Template/Loader/StringLoader.php on line 27 | 
1   | f1103a | Class implements deprecated interface Twig\Loader\SourceContextLoaderInterface in core/lib/Drupal/Core/Template/Loader/StringLoader.php on line 27 | 
1   | ced8c1 | Class implements deprecated interface Twig_ExistsLoaderInterface in core/modules/system/tests/modules/twig_loader_test/src/Loader/TestLoader.php on line 10 | 
1   | 39cd42 | Class implements deprecated interface Twig_SourceContextLoaderInterface in core/modules/system/tests/modules/twig_loader_test/src/Loader/TestLoader.php on line 10 | 
1   | 495dea | Fetching class constant class of deprecated class Drupal\Core\Entity\EntityHandlerBase in core/tests/Drupal/Tests/Core/Entity/EntityTypeManagerTest.php on line 400 | 
1   | 848d3b | Fetching class constant class of deprecated class Symfony\Component\ClassLoader\ApcClassLoader in core/tests/Drupal/Tests/Core/DrupalKernel/DrupalKernelTest.php on line 96 | 
1   | ea0fab | Instantiation of deprecated class Symfony\Component\ClassLoader\ApcClassLoader in core/lib/Drupal/Core/DrupalKernel.php on line 1088 | 
1   | 29a10c | Instantiation of deprecated class Symfony\Component\ClassLoader\WinCacheClassLoader in core/lib/Drupal/Core/DrupalKernel.php on line 1091 | 
1   | 3b0c85 | Instantiation of deprecated class Symfony\Component\ClassLoader\XcacheClassLoader in core/lib/Drupal/Core/DrupalKernel.php on line 1094 | 
1   | 150baa | Interface Drupal\Core\Field\FormatterInterface extends deprecated interface Drupal\Core\Field\PluginSettingsInterface in core/lib/Drupal/Core/Field/FormatterInterface.php on line 12 | 
1   | 40aa9b | Interface Drupal\Core\Field\WidgetBaseInterface extends deprecated interface Drupal\Core\Field\PluginSettingsInterface in core/lib/Drupal/Core/Field/WidgetBaseInterface.php on line 16 | 

I only manually cleared out the legacy test usages from the items that only had 1 usage. some of the remaining ones with 2 or 3 usages might be okay too, but my brain is done for today. :-)

@mikelutz nice work. Yeah we somehow need to be able to identify things like system_list() which are properly deprecated.

A bunch of issues landed, so let's try again. :)

The parsed output of that is the following (5 or more usages). Definitely trending down! Full report attached.

-------------------------------
Errors in need of review: 320 (74 distinct)
Errors found in legacy tests: 323 (224 distinct)
Deprecated code called from Deprecated Code: 15 (8 distinct)
Known errors postponed on D9 branch opening: 13 (10 distinct)
Autoloading Errors: 28 (27 distinct)
Cache Tag Unclear errors: 4 (4 distinct)
-------------------------------
Errors in need of review:

86  | 4ae932 | Call to deprecated method l() of class Drupal | 
28  | 03770f | Call to deprecated method url() of class Drupal\Core\Form\FormBase | 
16  | e7ee56 | Call to deprecated method clearCachedDefinitions() of class Drupal\Core\Entity\EntityTypeRepository | 
12  | 737cec | Access to deprecated property $entityContextDefinition of class Drupal\Core\Plugin\Context\ContextDefinition. | 
12  | 46f674 | Call to deprecated method prepareLegacyRequest() of class Drupal\Core\DrupalKernel | 
11  | 186bb5 | Call to deprecated function drupal_get_profile() | 
9   | aeec37 | Call to deprecated method entityManager() of class Drupal | 
8   | 14a3cd | Call to deprecated function statistics_get() | 
8   | 957a6c | Usage of deprecated trait Drupal\Core\Field\AllowedTagsXssTrait | 
7   | 8120ab | Call to deprecated function drupal_render_root() | 
7   | 3524c4 | Call to deprecated method initializeEntityContextDefinition() of class Drupal\Core\Plugin\Context\ContextDefinition. | 
6   | 9cd736 | Call to deprecated function system_list() | 
6   | b8178f | Call to deprecated method url() of class Drupal\Core\Controller\ControllerBase | 
5   | 565426 | Call to deprecated function _file_save_upload_from_form() | 
5   | e6b952 | Call to deprecated method isNewRevision() of class Drupal\node\Entity\NodeType | 
5   | 2216da | Usage of deprecated trait Drupal\Core\Routing\UrlGeneratorTrait | 

Here's some nice context to a few of the things in the list in #34

• 12 | 737cec | Access to deprecated property $entityContextDefinition of class Drupal\Core\Plugin\Context\ContextDefinition. | This is part of a BC layer that's all marked private and will be removed in Drupal 9 but can not in 8
• 9 | aeec37 | Call to deprecated method entityManager() of class Drupal | is deprecated properly and only called from test code. Mind you we should deprecate \Drupal\views\FieldAPIHandlerTrait::getEntityManager() and \Drupal\image\Plugin\Field\FieldType\ImageItem::getEntityManager()
• 7 | 3524c4 | Call to deprecated method initializeEntityContextDefinition() of class Drupal\Core\Plugin\Context\ContextDefinition. | This is part of a BC layer that's all marked private and will be removed in Drupal 9 but can not in 8
• 6 | 9cd736 | Call to deprecated function system_list() | is only called from legacy testing

So we're in an even better place.

Thanks @alexpott. Updated the summary script with:

    '737cec' => 'pp',
    'aeec37' => 'legacy',
    '3524c4' => 'pp',
    '9cd736' => 'legacy',
    '2d13e4' => 'legacy',

Note that the new 2d13e4 I (easily) identified as a false positive. It is Call to deprecated function deprecation_test_function() :D only used in test code testing deprecations.

Results are significantly down with these (ones with 5 or more to review):

-------------------------------
Errors in need of review: 282 (69 distinct)
Errors found in legacy tests: 342 (227 distinct)
Deprecated code called from deprecated code: 15 (8 distinct)
Known errors postponed on Drupal 9 branch opening: 32 (12 distinct)
Autoloading errors: 28 (27 distinct)
Cache tag unclear errors: 4 (4 distinct)
-------------------------------
Errors in need of review:

86  | 4ae932 | Call to deprecated method l() of class Drupal | 
28  | 03770f | Call to deprecated method url() of class Drupal\Core\Form\FormBase | 
16  | e7ee56 | Call to deprecated method clearCachedDefinitions() of class Drupal\Core\Entity\EntityTypeRepository | 
12  | 46f674 | Call to deprecated method prepareLegacyRequest() of class Drupal\Core\DrupalKernel | 
11  | 186bb5 | Call to deprecated function drupal_get_profile() | 
8   | 14a3cd | Call to deprecated function statistics_get() | 
8   | 957a6c | Usage of deprecated trait Drupal\Core\Field\AllowedTagsXssTrait | 
7   | 8120ab | Call to deprecated function drupal_render_root() | 
6   | b8178f | Call to deprecated method url() of class Drupal\Core\Controller\ControllerBase | 
5   | 565426 | Call to deprecated function _file_save_upload_from_form() | 
5   | e6b952 | Call to deprecated method isNewRevision() of class Drupal\node\Entity\NodeType | 
5   | 2216da | Usage of deprecated trait Drupal\Core\Routing\UrlGeneratorTrait | 

Let's update based on recent commits.

Down 28 more :) Ones with 5 or more:

-------------------------------
Errors in need of review: 254 (66 distinct)
Errors found in legacy tests: 343 (228 distinct)
Deprecated code called from deprecated code: 15 (8 distinct)
Known errors postponed on Drupal 9 branch opening: 32 (12 distinct)
Autoloading errors: 28 (27 distinct)
Cache tag unclear errors: 4 (4 distinct)
-------------------------------
Errors in need of review:

86  | 4ae932 | Call to deprecated method l() of class Drupal | 
28  | 03770f | Call to deprecated method url() of class Drupal\Core\Form\FormBase | 
12  | 46f674 | Call to deprecated method prepareLegacyRequest() of class Drupal\Core\DrupalKernel | 
11  | 186bb5 | Call to deprecated function drupal_get_profile() | 
8   | 14a3cd | Call to deprecated function statistics_get() | 
8   | 957a6c | Usage of deprecated trait Drupal\Core\Field\AllowedTagsXssTrait | 
6   | b8178f | Call to deprecated method url() of class Drupal\Core\Controller\ControllerBase | 
5   | 565426 | Call to deprecated function _file_save_upload_from_form() | 
5   | 2216da | Usage of deprecated trait Drupal\Core\Routing\UrlGeneratorTrait | 

I went through the list and moved more into postponed/legacy/dcdc. I also added/linked issues for all the outstanding ones. Sorry for the dump here, but I think it's useful

Edit: moved dump to the IS for others to edit.

> 2 | 524ff7 | Call to deprecated method url() of class Drupal\Core\Entity\EntityBase | #3067198: Properly deprecate UrlGeneratorTrait

Entity::url() is not about UrlGeneratorTrait and is already fully deprecated, those most be tests/deprecated code => this is done.

> 1 | 411a38 | Access to deprecated property $entityManager of class Drupal\Core\Entity\EntityForm in core/lib/Drupal/Core/Entity/ContentEntityForm.php on line 59 | #2450793: Properly deprecate support for entity type label callbacks

Wrong issue, should be the same as the one above?

Maybe move this list into the issue summary so every can update it? Great work btw.

I copied it as is, I'm on my phone. Have at it. :-)

#2958925: Properly deprecate drupal_get_profile() is in
few child issues needs review

edit: oops, posted on wrong issue.

Latest results, fixing a couple incorrect links in the script + updating IS.

-------------------------------
Errors in need of review: 144 (30 distinct)
Errors found in legacy tests: 359 (239 distinct)
Deprecated code called from deprecated code: 20 (10 distinct)
Known errors postponed on Drupal 9 branch opening: 65 (30 distinct)
Autoloading errors: 28 (27 distinct)
Cache tag unclear errors: 4 (4 distinct)
-------------------------------

-------------------------------
Errors in need of review: 140 (26 distinct)
Errors found in legacy tests: 363 (242 distinct)
Deprecated code called from deprecated code: 20 (10 distinct)
Known errors postponed on Drupal 9 branch opening: 65 (30 distinct)
Autoloading errors: 28 (27 distinct)
Cache tag unclear errors: 4 (4 distinct)
-------------------------------

Drupal::l() landed :)

-------------------------------
Errors in need of review: 44 (23 distinct)
Errors found in legacy tests: 368 (247 distinct)
Deprecated code called from deprecated code: 20 (10 distinct)
Known errors postponed on Drupal 9 branch opening: 65 (30 distinct)
Autoloading errors: 28 (27 distinct)
Cache tag unclear errors: 4 (4 distinct)
-------------------------------

-------------------------------
Errors in need of review: 40 (20 distinct)
Errors found in legacy tests: 371 (250 distinct)
Deprecated code called from deprecated code: 20 (10 distinct)
Known errors postponed on Drupal 9 branch opening: 65 (30 distinct)
Autoloading errors: 28 (27 distinct)
Cache tag unclear errors: 4 (4 distinct)
-------------------------------

-------------------------------
Errors in need of review: 33 (14 distinct)
Errors found in legacy tests: 380 (257 distinct)
Deprecated code called from deprecated code: 20 (10 distinct)
Known errors postponed on Drupal 9 branch opening: 65 (30 distinct)
Autoloading errors: 28 (27 distinct)
Cache tag unclear errors: 4 (4 distinct)
-------------------------------

#3069046: Properly manage newly required parameter of FileUsageBase::__construct() landed, removing from summary.

Hm, we actually went up a bit:

-------------------------------
Errors in need of review: 40 (19 distinct)
Errors found in legacy tests: 373 (252 distinct)
Deprecated code called from deprecated code: 20 (10 distinct)
Known errors postponed on Drupal 9 branch opening: 65 (30 distinct)
Autoloading errors: 28 (27 distinct)
Cache tag unclear errors: 4 (4 distinct)
-------------------------------

Somehow #2450793: Properly deprecate support for entity type label callbacks is back in 4 instances.

I may not have posted my latest script. Every time we fix one we add a legacy test that then needs to be marked in the script, or it still shows up. You just re-added several closed issues that I had been taking out.

Two more issues landed. Retesting. Will wait for @mikelutz's updated script to summarise.

-------------------------------
Errors in need of review: 18 (10 distinct)
Errors found in legacy tests: 382 (259 distinct)
Deprecated code called from deprecated code: 20 (10 distinct)
Known errors postponed on Drupal 9 branch opening: 65 (30 distinct)
Autoloading errors: 28 (27 distinct)
Cache tag unclear errors: 4 (4 distinct)
-------------------------------

Looks like it should be 9 unique as this one is found but already fixed(?)

1 | 46f674 | Call to deprecated method prepareLegacyRequest() of class Drupal\Core\DrupalKernel in core/tests/Drupal/KernelTests/Core/DrupalKernel/DrupalKernelTest.php on line 209 | #2869573: Remove usages of deprecated DrupalKernel::prepareLegacyRequest()

Yeah, looks like I missed one.

Updated :)

-------------------------------
Errors in need of review: 17 (9 distinct)
Errors found in legacy tests: 383 (260 distinct)
Deprecated code called from deprecated code: 20 (10 distinct)
Known errors postponed on Drupal 9 branch opening: 65 (30 distinct)
Autoloading errors: 28 (27 distinct)
Cache tag unclear errors: 4 (4 distinct)
-------------------------------

Let's run this again :)

-------------------------------
Errors in need of review: 15 (7 distinct)
Errors found in legacy tests: 416 (282 distinct)
Deprecated code called from deprecated code: 20 (10 distinct)
Known errors postponed on Drupal 9 branch opening: 65 (30 distinct)
Autoloading errors: 24 (24 distinct)
Cache tag unclear errors: 4 (4 distinct)
-------------------------------

Three more patches landed from above.

Update errors list from IS

Stumbled on this issue.

All the child issues are closed and phpstan is now running on Core, #3178534: Start running PHPStan on Drupal core (level 0). I don't see anything else to do here. Setting to RTBC just in case I missed something at this late hour.

Agreed, I think we can close this. If we enable new phpstan levels we can have new issues to fix anything that comes up too.