Update and add links in the installer

Reviewing (#sprintweekend2015)

http://www.drupal8multilingual.org/content/sprint-weekend-2015-ideas#pag...

@ifrik are you re-rolling to fix that, or shall I do it?

New patch which changes @ to ! for urls, a few additional http:'s changed to https:, added path back in for one mention of INSTALL.txt, changed description of the server-settings docs from 'online handbook' to "online 'Webhosting issues' documentation"

Update issue summary.

In a/core/includes/install.core.inc
There is a typo on line 1956:
consult the <a href="@!andbook_url">online
should be
consult the <a href="!handbook_url">online

Line 2149, the @ was not replaced with an ! for @handbook_url

In a/core/lib/Drupal/Core/Installer/Form/SiteConfigureForm.php
Line 131
drupal_set_message(t('All necessary changes to %dir, %file and %services have been made, so you should remove write permissions to them now in order to avoid security risks. If you are unsure how to do so, consult the <a href="!installation">online installation guide</a>.', array('%dir' => $settings_dir, '%file' => $settings_file, '%services' => $services_file, '!installation' => 'https://www.drupal.org/documentation/install/settings-file')), 'warning');

The array should be on a seperate line as per code conduct

Thanks so much @kristen-pol and @karengreen - I've updated and re-rolled the patch.

There is still an ampersand on line 1956 which needs removing
<a href="@!handbook_url">

Great work on splitting the array out onto seperate lines as per code conduct, it would be good to do this to all t() functions now to make the files consistant.

I'd be happy to assign this to myself and supply the patch

Dang! Careless me :-(

Sure - I'll be tied up today, and would like to get this one tied up with a bow, so by all means go for it. I'll review when it's done...

New patch created. I've also tidied up some code to match conduct
This is my first patch to core to hopefully its a good one!
Thanks,

I had some issues with my patch, so re-done it all and now included an interdiff between patch in #18 and this one
Thanks,

Thanks for the patches!

A few small things I noticed in the latest patch:

a)

online \'Webhosting issues\' documentation

This should be using double quotes. Occurs several times in the patch.

b)

The installer requires to contact the translation server to download a translation file. 

This is not good English. Should be something like "... installer needs to be able to contact...".

c)

The %language translation file is not available at the translation server. 

at ==> on

d)

The @drupal installer requires write permissions to %file during the installation process.  For more information,

Should only be 1 space between sentences, not two.

e)

...and create a new one by copying the %default_file file to %file.

No "the" here.

f)

All necessary changes to %dir, %file and %services have been made,

Needs comma after %file too.

g) In system.install:

For more information, see INSTALL.txt or the <a href="!installation">online installation guide</a>.'

This seems inconsistent with the wording being used in install.core.inc for the same purpose. Please make them all the same.

h) Generally, we like to keep patches to an issue only addressing the problems of this issue. So the changes like adding commas to array elements etc. are really NOT a good idea for this patch. It would make it much easier to review this patch, and much more likely to get committed, if those were removed. Just patch this issue and if necessary file a separate issue to address other problems that are unrelated to this issue.

Thanks!

working on this at #dclondon

I have taken the comments at #28, noted below...

a/ OK
b/ OK
c/ OK
d/ OK
e/ OK
f/ OK
g/ OK
h/ Where the only difference was the addition of a comma, as per coding standards, I have reverted that change. Where other changes have taken place in that array, I have left the comma in as part of that work.

working on this at #dclondon

Reviewed: at #dclondon

Applied patch (#30) and installed Drupal, no errors found.

Ref: #28 comments:
a/ corrected
b/ corrected
c/ corrected
d/ corrected
e/ - “the” is still there
f/ corrected
g/ corrected
h/ corrected as far as I could tell

Thanks for the review @kae76 - looks like the patch needs a bit of work, based on (e).

Having a look at why the test fails...

Triaging for Bug Smash.

There are some changes in the existing patch that are still relevant. For one, they change a link pointing to the webhosting issues page that was last changed in 2012 to a more recent page.

I decided to reroll the patch. Giving the age of the previous patch, the changes to install.core.inc and this is only about 10K, I have not made a interdiff.

Still need to update the IS.

Updated the IS.

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

The destination URL here directs to old Drupal 7 documentation. In #3552836: Installer "online handbook" link after installation leads to 404 in Drupal 11 a redirect has been as been added to direct the URl to a page about file permissions. That makes this outdated. I have updated credit.

Thanks all!