Follow-up to #2191565: [META] Comment/Forum/History path to beta
Updated: Comment #0
Problem/Motivation
There's some tasks needs to complete to make comment module ready for release [731724]
Proposed resolution
Clean-up comment manager and integration with history and forum modules
Also UI needs some love
Remaining tasks
Comment/Forum module - API changes/clean-ups
#2495087: comment_entity_storage_load() is too expensive on cold caches
#2377849: Simplify what CommentLinkBuilder is doing - consider removing a lot of the functionality
#2390065: Moving a forum with "Leave shadow copy" checked should leave a copy in the original forum
#2318875: Redo CommentStatisticsInterface Assigned to: roderik *
#2227503: Apply formatters and widgets to Comment base fields *
#2338319: Clean-up CommentManager::getFields() function signature/invocations +
#2594195: [meta] Improve support for multiple comment fields.
Comment links cleanup
#2113323: Rename Comment::permalink() to not be ambiguous with ::uri()
#2198041: Comment::urlInfo no longer includes the comment-{cid} fragment
#2010202-14: Deprecate comment_uri()
#2613040: The "Permalink" comment link links to the non-permanent URL
#2188287: Split CommentManager in two
#2324719: Node indexing - should use view mode for comments, not hook
#1920044: Move comment field settings that relate to rendering to formatter options
#2496699: Allow comments to be attached to entities using a string primary key
History module (api clean-up)
#2081585: [META] Modernize the History module
#1029708: History table for any entity
Tracker module
#2330577: Introduce TrackerRepository service Assigned to: roderik
Entity
#2227503: Apply formatters and widgets to Comment base fields
Markup-twig
#2002094: Improve performance of comment.html.twig
#1857946: Comment parent template variables are built twice
UX
#1903138: Move global comment permissions to comment-type level
#1920044: Move comment field settings that relate to rendering to formatter options
Fields
#552604: Adding new fields leads to a confusing "Field settings" form
#1875974: Abstract 'component type' specific code out of EntityDisplay
* = issue summary includes beta-phase template
Comments
Comment #1
andypostAlso we need to clean-up tokens to be finally decoupled from node
#2031901: Remove node tokens from comment.tokens.inc
#920056: [comment:name] duplicates [comment:author], and the latter should use format_username()
Comment #2
andypostWe need update each issue with summary from https://www.drupal.org/contribute/core/beta-changes#summaries-matter
<xjm> andypost: if you would like someone to approve an issue, make sure it has that information first
Comment #3
andypostExample is #1963340-167: Change field UI so that adding a field is a separate task
Comment #4
larowlanThanks
Comment #5
larowlanMarked those I've updated the issue summary to add the beta-phase template
Comment #6
andypostAdded #2377849: Simplify what CommentLinkBuilder is doing - consider removing a lot of the functionality
Comment #7
andypostAdded #2338319: Clean-up CommentManager::getFields() function signature/invocations
Comment #8
andypostComment #9
larowlanComment #10
larowlanComment #11
andypostComment #12
andypostComment #13
andypostComment #18
ao2 CreditAttribution: ao2 as a volunteer commentedI added #2613040: The "Permalink" comment link links to the non-permanent URL, which could be considered an excuse to discuss what the
comments/{{cid}}
links are meant for :)Right now they seem to always point to the parent entity page (e.g. node) anyways.
Comment #21
andypostComment #22
xjmComment #23
xjmComment #26
andypost