Updated: Comment #0

Problem/Motivation

There's some tasks needs to complete to make comment module ready for beta after #731724: Convert comment settings into a field to make them work with CMI and non-node entities

Proposed resolution

Clean-up comment manager and integration with history and forum modules
Also UI needs some love

Remaining tasks

Comment/Forum module - API changes/clean-ups
#3090187: Mechanism to disable preprocessing of base fields in comment entity type so they can be configured via the field UI
#2377849: Simplify what CommentLinkBuilder is doing - consider removing a lot of the functionality
#2227503: Apply formatters and widgets to Comment base fields
#2098419: Missing default access for all comment fields Assigned to: larowlan
#2324719: Node indexing - should use view mode for comments, not hook
#1920044: Move comment field settings that relate to rendering to formatter options
#2230177: Without Field UI comment module presents a poor UX
#2113323: Rename Comment::permalink() to not be ambiguous with ::uri()
#2304939: Stop loading comment statistics into entity object
#2010202-14: Deprecate comment_uri()
#2188287: Split CommentManager in two
#2068331: Convert comment SQL queries to the Entity Query API Assigned to: roderik
#2198041: Comment::urlInfo no longer includes the comment-{cid} fragment

#2318251: Make comment links functionality testable and convert CommentLinkTest to PHPUnit Assigned to: larowlan
#2156089: Remove comment_get_thread() in favour of method on CommentStorage Assigned to: roderik
#1498662: Refactor comment entity properties to multilingual
#2292821: Use widget for comment subject field Assigned to: larowlan

#2097123: Deprecate comment_num_new() in favour of method on CommentManager Assigned to: roderik
#2149859: Convert the 'field_id' base field on comment entities to an entity reference field
#2028025: Expand CommentInterface to provide methods
#2169361: Convert COMMENT_HIDDEN & COMMENT_CLOSED & COMMENT_OPEN to a constant on the comment field interface Assigned to: larowlan
#2228763: Create a comment-type config entity and use that as comment bundles, require selection in field settings form
#2205215: {comment} and {comment_entity_statistics} only support integer entity ids
#2205185: Split up ForumManager to create ForumIndexStorage
#2318875: Redo CommentStatisticsInterface Assigned to: roderik

History module (api clean-up)
#2081585: [META] Modernize the History module
#1029708: History table for any entity

Tracker module
#2330577: Introduce TrackerRepository service Assigned to: roderik

Comment statistics - nice to have
#2101183: Move {comment_entity_statistics} to proper service Assigned to: larowlan
#148849: Refactor {comment_entity_statistics} into performant Field Assigned to: David Strauss

Markup-twig
#2031883: Markup for: comment.html.twig
#2002094: Improve performance of comment.html.twig
#1857946: Comment parent template variables are built twice
#1962846: Use field instance name for header of comment list, drop comment-wrapper template

UX
#1699138: [meta] Coordination of effort on comment module improvements
#1903138: Move global comment permissions to comment-type level
#1920044: Move comment field settings that relate to rendering to formatter options
#2099421: Add an administrative description for a comment field
#1901110: Improve the UX for comment bundle pages and comment field settings

Entity
#2028025: Expand CommentInterface to provide methods
#2078387: Add an EntityOwnerInterface
#2099105: Clean-up render cache when permission changes

Fields
#1963340: Change field UI so that adding a field is a separate task
#552604: Adding new fields leads to a confusing "Field settings" form
#1875974: Abstract 'component type' specific code out of EntityDisplay

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes
Related issues: +#2002094: Improve performance of comment.html.twig
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes
Related issues: +#2010202: Deprecate comment_uri()
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

forum
#2032699: Preserve taxonomy_forums field when uninstalling forum module Assigned to: larowlan
#2106243: Use yml files to create the forum module's comment and taxonomy term fields Assigned to: RainbowArray

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue summary: View changes
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue summary: View changes
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

Added #2198041: Comment::urlInfo no longer includes the comment-{cid} fragment

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes
Related issues: +#2149859: Convert the 'field_id' base field on comment entities to an entity reference field
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue summary: View changes
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes

Added #1857946: Comment parent template variables are built twice

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue summary: View changes
Related issues: +#2205185: Split up ForumManager to create ForumIndexStorage

Added #2205185: Split up ForumManager to create ForumIndexStorage

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue summary: View changes
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes

Added #2228763: Create a comment-type config entity and use that as comment bundles, require selection in field settings form

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes

Added #1498662: Refactor comment entity properties to multilingual
reordered fixed

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes

Added #2292821: Use widget for comment subject field Assigned to: larowlan & #2227503: Apply formatters and widgets to Comment base fields

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes

added #2098419: Missing default access for all comment fields

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes

#2304939: Stop loading comment statistics into entity object

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes

#2318251: Make comment links functionality testable and convert CommentLinkTest to PHPUnit Assigned to: larowlan

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
CreditAttribution: roderik commented
Issue summary: View changes

(Tracker module can/should also be referenced here, right?
There was no issue for that yet so I created one. Before creating a patch for it I'll first look at the "table-per-entity type" discussion that had #2081585: [META] Modernize the History module - I'm pretty sure there have been commits which can unblock this, though I don't know the issue # right now.)

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes

Added
#1699138: [meta] Coordination of effort on comment module improvements
#2377849: Simplify what CommentLinkBuilder is doing - consider removing a lot of the functionality

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Version: 8.6.x-dev » 9.0.x-dev
Issue summary: View changes
Related issues: +#3090187: Mechanism to disable preprocessing of base fields in comment entity type so they can be configured via the field UI
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 9.0.x-dev » 9.1.x-dev
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

I'm wondering if this meta should be either retitled or closed at this point?

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Issue summary: View changes
Status: Active » Fixed

Re #31. I vote for closing. There has been one comment in 7 years which leads me to believe that the need to closely monitor progress has passed. Plus work is continuing on the related issues. All up, I think this can be closed.

I will take the leap and close this as fixed. If anyone disagrees, just reopen it and comment why this issue is still helpful

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.