[D8] wb_breadcrumbs

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxoles892367919git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Thanks @Codenator. I tested module work great for me! Very simple to use.

@Codenator I tried to improve the project description. If for any reason you want to revert it to how it was please let me know.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2502647

Project 2: https://www.drupal.org/node/2368123

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Manual Review

Individual user account

Yes: Follows

No duplication

No: Causes duplication - Codenator, can you better explain how to use your module and how it is different from default breadcrumbs. Is it using Url path or just active menu tree. Do I need to add your breadcrumb block, and why can't use default block and breadcrumb negotiation

Master Branch

Yes: Follows

Licensing

Yes: Follows

3rd party assets/code

Yes: Follows

README.txt/README.md

No: Does not follow the README Template.

Code long/complex enough for review

Yes: Follows

Secure code

Yes: Meets

Coding style & Drupal API usage

1. Good knowledge of D8 code structure
2. (*) Config link needs to be added to modules page
3. (*) Optional configurable homepage link would be useful
4. (*) Module didn't work for me. I enabled "WeebDo Breadcrumbs" block next to original breadcrumb block, and "WeebDo Breadcrumbs" had cache set to "forever" (D8 beta 11)(screenshot attached)
5. (*) Looks like block breadcrumb work in the same way as standard breadcrumbs block
6. (*) Code check gives minor errors http://pareview.sh/pareview/httpgitdrupalorgsandboxoles892367919git-8x-1x
7. (+) README.txt starts with "rupal 8 menu bas..." and lacks section styling

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

This review uses the Project Application Review Template.

Looks good for me! Tested on my site. Work differently than core module as mentioned in '#19'. So this is not duplication

Hi congratulation for your project,

I ve small return of this in code :

you need to fix Coding standards and add this link into your issue summary : http://pareview.sh/pareview/httpgitdrupalorgsandboxoles892367919git

Here is a first impression of the code:

We must properly comment and add some description @see this little patch (on attachement).
The indentation was also a little strange (that is fixed in the patch). We must comment on the linksFromTree function () becauseinheritDoc is to be used only in the event the parent class contains this method.

The build() method of the factory block use rather config at places of use \ Drupal :: config ('wb_breadcrumbs.settings'); it will be more convenient for the tests '$ Container-> get (' config.factory ');'

Once its few things resolved, I would proceed has a test push more;) nice work.

@Codenator i m busy atm but i can review it when i have a small time promise !

I'd fix this warning but looks pretty close to finished. http://pareview.sh/pareview/httpgitdrupalorgsandboxoles892367919git

Thanks a lot for submitting this theme. Here's a few comments on having a look at your theme.

1) Change your git clone command to
git clone http://git.drupal.org/sandbox/oles89/2367919.git nameofyourmodule
This will mean that the folder will be renamed when downloaded.

2) is it suppose to repeat the page you are on ? for me it is displaying like this Home / services / services also I tried to change the separator but it doesn't seem to change it. Does it only accept certain values ?

3) Installed fine on 8.1.8 no issues

4) no issues with the dblog either.

5) the readme seems decent. but outputs markup if you use the readme module. I would recommend fixing this but it is optional.

Let us know when you have updated it and I will have another look for you.

I'm happy to review this if it's ready for another pass. Can you please let me know when you have had a chance to look at the previous comment?

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.