Drupal 8 version not working

I came to the issue queue because I couldn't find the leaflet style option in Views. This patch solves that.

One thing, that I don't know if it should be addressed in this issue, is that when setting leaflet style options, there no scrollbar, so without using [TAB] to move between fields, I can't access the entire settings form.
Nvm, scrollbar showed up now...

New patch with a few more minor fixes.

@bforchhammer, will you release that modules at d.o?

Also, is https://github.com/bforchhammer/leaflet_markercluster related to https://www.drupal.org/project/leaflet_markercluster?

The patch should be updated again to fix https://www.drupal.org/developing/api/8/assets incompatibility (see leaflet_render_map()).

I corrected the following:
- there was a javascript error preventing the display of the nodes
- you could not set a custom logo (nor customize its size)

And I also added the possibility to define the zoom level that you want to use at the administration level (with the minimum and maximum zoom also now definable in the administration)

As I am very new to this module, can someone please review the patch?

Ok, now I am a bit confused regarding Views. Long story short: I can't make any view display my nodes.

There is LeafletMap.php and Leaflet.php that are both Views Format. LeafletMap.php is tagged deprecated, so why don't we remove it?

Also, with Leaflet.php, you cannot choose which field is the geofield you want to use with your view, and my map is rendering but is empty. Am I missing something here?

hmmm, same here!
On a nodepage it works, I see a map.
But when I create a view to show all nodes on the map... I get this error:
Notice: Undefined index: #attached in Drupal\leaflet_views\Plugin\views\style\Leaflet->render() (line 117 of modules/leaflet/leaflet_views/src/Plugin/views/style/Leaflet.php).

I've downloaded your updated leaflet module from https://github.com/bforchhammer/leaflet

Hello Everyone,

We're looking to explore the possibility of integrating Leaflet.js into Drupal 7.x sites (which, potentially, could be migrated into Drupal 8). Has there been any progress in relation to resolving this issue (and, more generally, working with recently-released betas)?

Thank you.

Sincerely,
James

Attached minor fix for the following error (after core update to 8.0.0-rc1).

Fatal error: Declaration of Drupal\\leaflet\\Plugin\\Field\\FieldFormatter\\LeafletDefaultFormatter::viewElements() must be compatible with Drupal\\Core\\Field\\FormatterInterface::viewElements(Drupal\\Core\\Field\\FieldItemListInterface $items, $langcode) in modules/contrib/leaflet/src/Plugin/Field/FieldFormatter/LeafletDefaultFormatter.php

Applying patch at comment 10 gives warning about whitespace error (trailing whitespace).

I re-rolled #10 to remove the whitespace errors and the deletion of leaflet.api.php, and attached a patch with all fixes per patch standards.

• interdiff-6-10.txt: displays changes from #6 to my re-roll of #10.
• interdiff-10-14.txt: displays changes from my re-roll of #10 and #14.
• interdiff-6-16.txt: displays changes from #6 to the latest patch that I uploaded.

Has anyone had luck with leaflet_views? I haven't been able to create a map view (yet).

Minor bugfixes on current patch.

I am facing the following fatal error:

"Fatal error: Declaration of Drupal\leaflet\Plugin\Field\FieldFormatter\LeafletDefaultFormatter::viewElements() must be compatible with Drupal\Core\Field\FormatterInterface::viewElements(Drupal\Core\Field\FieldItemListInterface $items, $langcode) in D:\xampp\htdocs\drupal-8\docroot\modules\leaflet\src\Plugin\Field\FieldFormatter\LeafletDefaultFormatter.php on line 244"

Even if I clone the module from github: https://github.com/bforchhammer/leaflet.

Updated issue summary to prevent confusion in #19

I have noticed that entity_type property of the views plugin is always empty, since views base table is a data table for an entity, while it's compared with entities base tables.

Add the schema definition file to avoid the annoying "missing schema" issue.

Thanks everyone for the great work in making Leaflet work with the latest Drupal 8 core. I've tested this and will go ahead and commit #22 to the 8.x branch. Any new work can then can go in separate issues from here onwards.