[D7] SMS MTarget

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxarnaudlumini2350919git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi arnaudlumini,

You need to fix all the errors. Now more errors are reported now.
Also please follow the Drupal coding standards.

Coding Standards Ref: https://www.drupal.org/coding-standards

Leftover coding standard errors are not application blockers, please do a real manual review.

Project applications are always tasks, so just leave the category as is.

Thanks Klausi,

To share this knowledge about coding standard and category options.

I did not manually review this application. My this comment is based on PAreview.

I will mind your suggestion from next time.

Thanks a lot.

Manual Review:

1- Fatal error: Class 'EntityDefaultViewsController' not found in /var/www/7drupal-1/sites/all/modules/custom/sms_mtarget/sms_mtarget_message/SMSMTargetMessageViewsController.class.php on line 8.

Help: You can handle this type of error using hook_requirements($phase).

2- Do not include all the files in hook_init() function. This hook is run on every page request.
3- hook_help is missing.
4- If you need to use $_POST variables, ensure they are fully sanitized, use the following to displayed check_plain(), filter_xss(). etc.

Automated Review
http://pareview.sh/pareview/httpgitdrupalorgsandboxarnaudlumini2350919git
(commit b89e9c9) found a some list of Coding Standards Issues. Recommend taking a close look.
Check below one issue from the list.

FILE: /var/www/drupal-7-pareview/pareview_temp/classes/SMSMTarget.class.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
11 | ERROR | Doc comment short description must be on a single line, further
| | text should be a separate paragraph
53 | ERROR | Use "elseif" in place of "else if"
56 | ERROR | Use "elseif" in place of "else if"
59 | ERROR | Use "elseif" in place of "else if"
--------------------------------------------------------------------------------

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
No: Follows the licensing requirements
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes. If "no", list security issues identified.
Coding style & Drupal API usage
Nothing found that needs to be addressed, except for the issues identified by pareview.sh (see above)

Hi,

Nice work.
Do fix all the issues reported by PareView.sh(Automated Review).
Have a look on the attached file and do the need.

Good luck for your submission.

Sanat

This module is working fine on a production site. According to #13, we can set the status to RTBC

Blocking issues:

1. All variables should be removed in a hook_uninstall(), such as sms_mtarget_username

Non-blocking issues:

• The project page should be filled out
• You don't need to specify the access callback as user_access, that is provided by default
• In SMSMTargetMessage::create() use REQUEST_TIME instead of time(), since that value may change during page execution

Looks great aside from that one issue.

Since this was in RTBC before and the only change was minor,

Thanks for your contribution, arnaudlumini!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.