Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Aug 2014 at 16:02 UTC
Updated:
22 Feb 2015 at 19:54 UTC
Jump to comment: Most recent
Comments
Comment #1
miteshmapComment #2
PA robot commentedGit clone command for the sandbox is missing in the issue summary, please add it.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
miteshmapComment #4
miteshmapComment #5
miteshmapComment #6
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdevelopermitesh231633...
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #7
miteshmapAutomated Review
Here is the result url, no error found.!
http://pareview.sh/pareview/httpgitdrupalorgsandboxdevelopermitesh231633...
Comment #8
miteshmapComment #9
th_tushar commentedHi,
I have manually reviewed your code, it seems that you are setting a drupal variable but not deleting them during un-installation. So, make sure you delete them else may create a garbage variables in the drupal system.
Changing the status to "Needs Work", you can revert it back after making the changes.
Comment #10
miteshmapAdded hook_uninstall to delete variables.
Comment #11
Michael Hodge Jr commentedAutomated Review
Parreview.sh found some issues, see: http://pareview.sh/pareview/httpgitdrupalorgsandboxdevelopermitesh231633... The big thing is you need a newline at the end of the .install file. Otherwise you are good to go.
Manual Review
I went through your code and didn't see any glaring issues that needed to be fixed. I'm going to set this to RTBC.
Comment #12
miteshmapUpdated .install file added a newline at the end of the file.
Comment #13
kscheirerThe code is short, but shows a good understanding of the Drupal API. Additionally checked through some other projects by the author (jquery_date_range) and found good code there too. No other issues found.
Thanks for your contribution, developermitesh!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #14
miteshmapThanks very much for your updates. The project is now moved to - https://www.drupal.org/project/internal_nodes_linkit
Looking forward to make jquery_date_range a full project. I will make updates on it and solve the pending issues soon and apply for the full project.
Comment #16
kscheirerSorry, the bot got confused. @developermitesh you already have "git vetted user" status, and can publish your own projects. Closing the other application instead.