User Created By module saves uid of user who creates other users. This is very helpful in sites where particular user roles are allowed to create other users and with this module it can be easily shown who created which user.
Features:
- Saves uid of user who creates other users. And if user registers then anonymous users uid is saved which is 0.
- User Created By module provides view handler which allows to make relationship in view and add user creator's name or other corresponding fields of user creator in view.
Sandbox Link
https://www.drupal.org/sandbox/gaurav_varshney/2315037
Pareview Link
http://pareview.sh/pareview/httpgitdrupalorgsandboxgauravvarshney2315037git
GIT Clone
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/gaurav_varshney/2315037.git user_created_by
cd user_created_by| Comment | File | Size | Author |
|---|---|---|---|
| #10 | userlist_view.png | 2.51 KB | gbisht |
| #10 | userlist_relationship.png | 17.58 KB | gbisht |
Comments
Comment #1
govind.maloo commentedAutomated Review
http://pareview.sh/pareview/httpgitdrupalorgsandboxgauravvarshney2315037git
Showing no error.
Manual Review
Code appears good to me.
I spent some time looking through your schema and not able to find primary key. I think it would be better to have that.
Comment #2
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
mxr576Manual Review
user_created_by.module
There is a typo at line 13: "moudle's" .
user_created_by_user_delete() is a hook_user_delete() implementation not a hook_user_insert().
user_created_by.info
Description maybe more specific if you change to this: "the uid of the current user"
Everything else seems fine to me.
Comment #4
gaurav_varshney commentedComment #5
gaurav_varshney commented1. @govind.maloo thanks for reviewing the code i have make the changes you suggest - Primary Key
2. @mxr576 thanks for reviewing the code i have make the changes you suggest
1) Typos error
2) Module Description in .info file
Thanks Once Again.
Comment #6
tkuldeep17 commentedVery nice and short module.. I tried to use this module, but could not able to show Creator UID, as you have not added field handler. So drupal views is not able to populate this value. So you have to add this, For more you can take help from here http://web3.ee/en/my-first-views-field-handler-drupal-7.
Comment #7
tkuldeep17 commentedComment #8
gbisht commented@tkuldeep17 field handler is there. To show creator UID or any other field associated to user creator you need to create a relationship with user created by and then use that relationship with the field.
Didn't found any issue with the module so changing to needs review status.
Comment #9
tkuldeep17 commented@gulab.bisht I added relationship, but did not see that field, then I went through code, did not find code for that.. May be something other I am missing..
Comment #10
gbisht commented@tkuldeep17 I checked it again and after you add "User Created By: Creator Uid" relationship, add user name field with created uid relationship. After these step you will be able to see creator user name in the view. Similarly other field associated with the creator user can be added. Attached some screenshots for reference.
Comment #11
MattWithoos commentedManual Review:
1. You have a .install - what about a .uninstall to remove the variables?
2. One purpose of having a project application process is for Drupal developers to demonstrate their knowledge of Drupal. Your module is very small so I would suggest expanding it if appropriate to demonstrate to the Git admins your competency!
3. I couldn't see any permission settings to control who can use this. Is this necessary?
4. It would make sense to offer a column of users and the user who created them, with permission settings, but this is merely a suggestion.
5. Optional - include a link to the PAReview website so future changes by yourself can easily be passed/reviewed by other reviewers.
Comment #12
MattWithoos commentedComment #13
gaurav_varshney commented@Matt thanks for the review.
1. There is no .uninstall file in drupal. In install file I'm creating a table which will be get deleted on module uninstall.
2. I thinks there is appropriate amount of code and complexity in module with appropriate amount of functions.
3. I don't think there is any need of any permission in this project. If you have any suggestion please let me know I will try to include in future stable release.
4. Permission to allow other users to create user can be achived by Role Delegation module.
5. Pareview link added.
Comment #14
gaurav_varshney commentedComment #15
MattWithoos commentedWoops re: no.1, I meant hook_uninstall, not .uninstall!
Regarding number 2 - in that case, I have applied a tag for you.
Comment #16
MattWithoos commentedActually, I don't see any issues with this module - it's short and succinct so I'm going to move it to RTBC. Thanks and good luck!
Comment #17
irfworld commentedAutomated Review
Reviewed the code with http://pareview.sh . And it shows no error.
Manual Review
Code is simple and clean.
Comment #18
stborchert@irfworld: please do not remove this tag since the module is indeed to short and simple to approve the author as a vetted git user.
@gaurav_varshney: if you like, we could manually promote this module to a full project for you.
Comment #19
pingwin4egThe official tag for this is 'PAReview: Single project promote'.
Comment #20
gaurav_varshney commented@pingwin4eg yes i agree with you to promote this module as a single project.
Thanks for your reply.
Comment #21
pushpinderchauhan commentedGetting review bonus would help speed up the process and make sure it gets on the review admins radar.
Comment #22
stborchertThanks for your contribution, Gaurav!
I promoted your sandbox to a full project so you can create releases and work with it as if you would have promoted it ;)
New URL: https://www.drupal.org/project/user_created_by
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.