Closed (fixed)
Project:
Video Filter
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Jun 2014 at 10:32 UTC
Updated:
19 Mar 2016 at 22:01 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ultimateboy commentedIt's usually rare for a module maintainer to grant co-maintership unless you've been active in the issue queue and providing patches. I'm sure this issue might get some traction if you contribute a couple patches or review some that are already out there.
With that said, I too volunteer myself for co-maintaining this module. Would love to see the RTBC issues committed!
Comment #2
me-taras commentedHello.
Here is the part of module for d8.
Comment #3
gilmordFixed filter-plugin's name and module's name. Seems that basic D8 version is completed.
But I have idea to rebuild video_filter.codec.inc and implement codecs as plugins or something like that.
Set issue to Needs review status, so someone can check and review patch.
Comment #4
damienmckennaLets focus this on the D8 port, given several people have worked on code.
If anyone wants to join as a comaintainer I suggest contacting the author directly.
Comment #5
proweb.ua commentedd8 rc2
after install, in /admin/config/content/formats/manage/fullhtml
i do not see a video filter settings
Comment #6
gilmord1
Comment #7
estoyausenteRerrolled. I'm trying to test it.
Comment #8
estoyausente[Fri Feb 05 15:11:51.873715 2016] [:error] [pid 13306] [client 127.0.0.1:33148] PHP Fatal error: Declaration of Drupal\\video_filter\\Plugin\\Filter\\VideoFilter::settingsForm() must be compatible with Drupal\\filter\\Plugin\\FilterInterface::settingsForm(array $form, Drupal\\Core\\Form\\FormStateInterface $form_state) in [PATH]/modules/contrib/video_filter/src/Plugin/Filter/VideoFilter.php on line 142
Can you create a D8 branch? It's a little bit uncomfortable to work of this way :-)
Thanks.
Comment #9
minnur commentedHey guys,
I am working on porting this module to Drupal 8. Should have working prototype by next Monday!
This is the repo I am working on, currently nothing in there, but expect to see some code very soon:
https://github.com/chapter-three/video_filter
FYI, I am using Drupal 8 plugin system for codecs.
Thanks,
Minnur
Comment #10
estoyausenteHi minnur, great. Pluggin system I think that is the correct way to implements this filters.
I think that we can add some external providers (like TED) that are implemented rigth now in external modules or patches in the issue queue. I try to help you if I have some time.
Comment #11
minnur commentedI am getting very close to completion of porting the module to D8.
Currently works:
- CKEditor plugin. (generates [video] token)
- Allows to embed Youtube, Vimeo, YouKu
Remaining tasks:
- fix video ratio issue.
- complete twig template for flash player
- Add all possible Video Filter plugins
- Add README
- Add example module (example of how to extend Video Filter module and write plugins/codecs)
Comment #12
minnur commentedI am almost finished porting all the Video Filter codecs and most of them are already done. Please download 8.x-1.x-dev version and test.
Comment #13
minnur commentedOK guys, lets test D8 dev version and release alpha version.
Comment #14
minnur commentedSupported third-party services for D8 version of the module (as of today):
Comment #15
minnur commentedComment #16
damienmckennaExcellent work, @minnur!
Comment #17
minnur commented@DamienMcKenna thanks! Still need write some unit tests and test ported codecs/plugins. Not sure if some of them still relevant, like picasa.
Comment #18
minnur commentedComment #19
minnur commentedI feel like D8 version is ready for alpha release. I need some feedback before it. Thanks
Comment #20
estoyausenteGreat minmmur. I need some time to try it but I want to use.
If I have some time to install and test, I will give you some feedback. Thanks!
Comment #21
minnur commentedI am releasing 8.x-1.0-alpha1 this Friday (03/11/2016).
Comment #22
damienmckennaExcellent work, minnur, thanks for all your hard work! Lets handle follow up features & bugs as separate issues.
Comment #23
minnur commentedComment #24
damienmckennaFYI issues automatically close after two weeks of inactivity when their status is set to "fixed", so you don't have to manually closed them.
Comment #25
minnur commentedHi @DamienMcKenna I am aware of that, trying to cleanup the list so it is easier for me visually see all the open issues and make decisions whether to close open issues due to no activity or other reasons or fix it in the current D7 and D8 versions.