Roadmap to migrate video_filter to D8 (Draft)

@Todos

  • Remove Hook_menu and create routing file.
  • Remove hook_theme and create twig templates or renders function.
    • FLash theme
    • iframe theme
    • dashboard theme
  • Remove drupal_invoke_all and create pluggin system for codes.
  • Remove drupal_alter.
  • Use embed module to embed element into the wysiwyg?
  • Coding standars.

Comments

ultimateboy’s picture

It's usually rare for a module maintainer to grant co-maintership unless you've been active in the issue queue and providing patches. I'm sure this issue might get some traction if you contribute a couple patches or review some that are already out there.

With that said, I too volunteer myself for co-maintaining this module. Would love to see the RTBC issues committed!

me-taras’s picture

StatusFileSize
new16.73 KB

Hello.
Here is the part of module for d8.

gilmord’s picture

Status: Active » Needs review
StatusFileSize
new17.05 KB

Fixed filter-plugin's name and module's name. Seems that basic D8 version is completed.
But I have idea to rebuild video_filter.codec.inc and implement codecs as plugins or something like that.

Set issue to Needs review status, so someone can check and review patch.

damienmckenna’s picture

Title: Offering to maintain Video Filter » Port Video Filter to Drupal 8

Lets focus this on the D8 port, given several people have worked on code.

If anyone wants to join as a comaintainer I suggest contacting the author directly.

proweb.ua’s picture

d8 rc2
after install, in /admin/config/content/formats/manage/fullhtml
i do not see a video filter settings

gilmord’s picture

1

estoyausente’s picture

StatusFileSize
new17.05 KB

Rerrolled. I'm trying to test it.

estoyausente’s picture

Issue summary: View changes
Status: Needs review » Needs work

[Fri Feb 05 15:11:51.873715 2016] [:error] [pid 13306] [client 127.0.0.1:33148] PHP Fatal error: Declaration of Drupal\\video_filter\\Plugin\\Filter\\VideoFilter::settingsForm() must be compatible with Drupal\\filter\\Plugin\\FilterInterface::settingsForm(array $form, Drupal\\Core\\Form\\FormStateInterface $form_state) in [PATH]/modules/contrib/video_filter/src/Plugin/Filter/VideoFilter.php on line 142

Can you create a D8 branch? It's a little bit uncomfortable to work of this way :-)

Thanks.

minnur’s picture

Hey guys,
I am working on porting this module to Drupal 8. Should have working prototype by next Monday!
This is the repo I am working on, currently nothing in there, but expect to see some code very soon:
https://github.com/chapter-three/video_filter

FYI, I am using Drupal 8 plugin system for codecs.

Thanks,

Minnur

estoyausente’s picture

Hi minnur, great. Pluggin system I think that is the correct way to implements this filters.

I think that we can add some external providers (like TED) that are implemented rigth now in external modules or patches in the issue queue. I try to help you if I have some time.

minnur’s picture

I am getting very close to completion of porting the module to D8.
Currently works:
- CKEditor plugin. (generates [video] token)
- Allows to embed Youtube, Vimeo, YouKu

Remaining tasks:
- fix video ratio issue.
- complete twig template for flash player
- Add all possible Video Filter plugins
- Add README
- Add example module (example of how to extend Video Filter module and write plugins/codecs)

minnur’s picture

I am almost finished porting all the Video Filter codecs and most of them are already done. Please download 8.x-1.x-dev version and test.

minnur’s picture

OK guys, lets test D8 dev version and release alpha version.

minnur’s picture

Supported third-party services for D8 version of the module (as of today):

  1. Archive.org
  2. Capped
  3. College Humor
  4. Coub
  5. DailyMotion
  6. FlickrSlideshows
  7. FlickVideo
  8. Game Trailers
  9. Game Videos
  10. Giphy
  11. Godtube
  12. Google Video
  13. Instagram
  14. MakerTv
  15. Metacafe
  16. Myspace
  17. PicasaSlideshows
  18. Slideshare
  19. Teachertube
  20. TED
  21. Twitch
  22. Twitter
  23. Vimeo
  24. Vine
  25. Wistia
  26. YouKu
  27. Youtube
  28. Facebook
  29. VEVO
minnur’s picture

Status: Needs work » Needs review
damienmckenna’s picture

Excellent work, @minnur!

minnur’s picture

@DamienMcKenna thanks! Still need write some unit tests and test ported codecs/plugins. Not sure if some of them still relevant, like picasa.

minnur’s picture

Version: 7.x-3.x-dev » 8.x-1.x-dev
minnur’s picture

I feel like D8 version is ready for alpha release. I need some feedback before it. Thanks

estoyausente’s picture

Great minmmur. I need some time to try it but I want to use.

If I have some time to install and test, I will give you some feedback. Thanks!

minnur’s picture

I am releasing 8.x-1.0-alpha1 this Friday (03/11/2016).

damienmckenna’s picture

Status: Needs review » Fixed

Excellent work, minnur, thanks for all your hard work! Lets handle follow up features & bugs as separate issues.

minnur’s picture

Status: Fixed » Closed (fixed)
damienmckenna’s picture

FYI issues automatically close after two weeks of inactivity when their status is set to "fixed", so you don't have to manually closed them.

minnur’s picture

Hi @DamienMcKenna I am aware of that, trying to cleanup the list so it is easier for me visually see all the open issues and make decisions whether to close open issues due to no activity or other reasons or fix it in the current D7 and D8 versions.