Given #1498720: [meta] Make the entity storage system handle changes in the entity and field schema definitions base fields and module provided fields in general actually need the same field purge logic as we do have for configurable fields. Thus, we should move that logic from being a field.module provided API for configurable fields to an Entity Field API provided service/API.

Not marking this as critical as we've got the work-a-round of disallowing uninstalling modules providing fields that have data, which #1498720: [meta] Make the entity storage system handle changes in the entity and field schema definitions is about to establish.

Comments

effulgentsia’s picture

#2338873: Modules providing non-configurable field storage definitions can be uninstalled, leaving orphaned unpurged data is in.

I'm tempted to demote this issue to Normal priority and postpone it to 8.1. I think it can be done while preserving BC. Any reason to keep it as Major and/or give it any attention prior to 8.0?

plach’s picture

Issue tags: +entity storage
fago’s picture

I don't see an issue with not doing it for 8.0.x, however doing it is going to cause some API changes:

Probably functions like field_purge_field() etc. are going away and purging related storage methods will move from DynamicallyFieldableEntityStorageInterface to FieldableEntityStorageInterface. Depending how things work out some more changes to those purging related methods might be required also.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.