Problem/Motivation

tabledrag.js has a mysterious and completely unnecessary addition of "menu-item__link" class to the first link in a table drag row. This doesn't seem to have any purpose and doesn't make sense if you're rearranging things other than menu links.

Proposed resolution

Remove the code that adds these classes.

Remaining tasks

Review.

User interface changes

None.

API changes

None (compared to Drupal 7). This seems like it may have been accidentally added at some point.

Files: 
CommentFileSizeAuthor
#3 remove_completely-menu-item__link-2277795-3.patch1.07 KBmahtoranjeet
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 95,680 pass(es). View
#1 tabledrag-menu-link-2277795.patch603 bytesquicksketch
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 71,689 pass(es). View

Comments

quicksketch’s picture

FileSize
603 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 71,689 pass(es). View

Patch.

quicksketch’s picture

Status: Needs review » Needs work

Oh, hmm seems like this class *is* used in system.module.css. Very odd, why would it have the name "menu-item__link", and why would tabledrag.js be responsible for adding this class? It seems like something that should be moved to be part of the CSS for the particular table it's intended to affect.

mahtoranjeet’s picture

Status: Needs work » Needs review
FileSize
1.07 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 95,680 pass(es). View

Removing class from "menu-item__link" from tabledrag.js and system.module.css. Asuming it is not in used in else where. Or what is your suggestions.?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

droplet’s picture

Component: javascript » markup

this is adding from #75 of #1261002: Draggable tables do not work on touch screen devices. I can't find the actual usage anyway.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.