Follow-up to #2207341: "Re-run tests" form action broken

CommentFileSizeAuthor
#9 drupal8.simpletest-results-ui.9.patch6.85 KBsun
#1 whenfailsandpasses.png362.95 KByesct
#1 justfailing.png403.41 KByesct
#1 justpasses.png181.33 KByesct
drupal8.simpletest-results-ui.0.patch6.86 KBsun

Comments

yesct’s picture

yesct commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new justpasses.png181.33 KB
new justfailing.png403.41 KB
new whenfailsandpasses.png362.95 KB

I read all the lines in the patch. Looks fine, nothing jumps out to concern me.

tested it with only passing tests
(entityaccess)

with only passing, primary button is return to list

and just failing
(patch from #1906810: Require type hints for automatic entity upcasting test: languageselect)

and both

when some fails, primary button is rerun tests.

very nice.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Very nice indeed :)

dries’s picture

dries commented

"Return to list" is still odd to me. It seems like that should be a link as it takes you to page instead of performing an action? Also, is "Back to overview" a better name?

dries’s picture

dries commented

Another thing that is slightly confusing in the screenshots: it says there are 6 fails but in the drop-down menu it says "Fail (1)". This seems to suggest there is 1 failure. I figure this could confuse people.

yesct’s picture

yesct commented

I think it is worth making return to list an action, so that it can be clear that that is the usual thing when everything passes. It is the primary thing to do then.

Fail (1) ... is a preexisting problem and not the fault of this issue.

We can fix that in another issue. Maybe to make it be Fail (1 test class)
And the other .. 38 asserts pass, 6 asserts failed, 3 debug messages.
But I dont know if asserts is universally accurate.

yesct’s picture

yesct commented
Related issues: +#2211849: clarify class fail vs assert fail counts in test results page

related issue created.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Parent issue: #2207341: "Re-run tests" form action broken » #2215035: [meta] Simpletest UI cleanups
Related issues: +#2207341: "Re-run tests" form action broken

Status: Reviewed & tested by the community » Needs work

The last submitted patch, drupal8.simpletest-results-ui.0.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new drupal8.simpletest-results-ui.9.patch6.85 KB

Diff context conflict.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: drupal8.simpletest-results-ui.9.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review

9: drupal8.simpletest-results-ui.9.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC.

For anyone who'd like to help getting rid of this: #2216701: Random test failure in ToolbarAdminMenuTest

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: drupal8.simpletest-results-ui.9.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review

9: drupal8.simpletest-results-ui.9.patch queued for re-testing.

yesct’s picture

yesct commented
Status: Needs review » Reviewed & tested by the community

that random fail is fixed so should be rtbc still.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: drupal8.simpletest-results-ui.9.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone commented
Project: Drupal core » SimpleTest
Version: 8.9.x-dev » 8.x-3.x-dev
Component: simpletest.module » Code

Triaging issues in simpletest.module to determine if they should be in the Simpletest Project or core.

This looks like it a simpletest module issue, changing the project.