CommentFileSizeAuthor
#32 2216701.31.patch57.52 KBalexpott
#29 2216701.29.patch1.37 KBalexpott
#29 2216701.29.patch1.37 KBalexpott
#29 2216701.29.patch1.37 KBalexpott
#29 2216701.29.patch1.37 KBalexpott
#29 2216701.29.patch1.37 KBalexpott
#29 2216701.29.patch1.37 KBalexpott
#29 2216701.29.patch1.37 KBalexpott
#29 2216701.29.patch1.37 KBalexpott
#18 2216701.18.test-only.patch57.92 KBalexpott
#18 2216701.18.test-only.patch57.92 KBalexpott
#18 2216701.18.test-only.patch57.92 KBalexpott
#18 2216701.18.test-only.patch57.92 KBalexpott
#18 2216701.18.test-only.patch57.92 KBalexpott
#18 2216701.18.test-only.patch57.92 KBalexpott
#18 2216701.18.test-only.patch57.92 KBalexpott
#18 2216701.18.test-only.patch57.92 KBalexpott
#16 2216701.16.test-only.patch57.52 KBalexpott
#16 2216701.16.test-only.patch57.52 KBalexpott
#16 2216701.16.test-only.patch57.52 KBalexpott
#16 2216701.16.test-only.patch57.52 KBalexpott
#16 2216701.16.test-only.patch57.52 KBalexpott
#16 2216701.16.test-only.patch57.52 KBalexpott
#16 2216701.16.test-only.patch57.52 KBalexpott
#16 2216701.16.test-only.patch57.52 KBalexpott
#16 2216701.16.test-only.patch57.52 KBalexpott
#13 drupal8.random-toolbar.memory-static.patch9.68 KBsun
#11 drupal8.random-toolbar.memory.patch8.55 KBsun
#9 drupal8.random-toolbar.memory.patch8.02 KBsun
#8 2216701-toolbar-random-skip-userrole.patch3.2 KBlongwave
#6 2216701-toolbar-random-brute-force.patch7.39 KBlongwave
#5 drupal8.random-toolbar.5.patch5.19 KBsun
#3 drupal8.random-toolbar.3.patch2.43 KBsun
#1 drupal8.random-toolbar.patch402 bytessun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Active » Needs review
FileSize
drupal8.random-toolbar.patch402 bytes

For starters.

@timplunkett might have found the solution

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Needs review
FileSize
drupal8.random-toolbar.3.patch2.43 KB
sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Needs review
FileSize
drupal8.random-toolbar.5.patch5.19 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
FileSize
2216701-toolbar-random-brute-force.patch7.39 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Needs work » Needs review
FileSize
2216701-toolbar-random-skip-userrole.patch3.2 KB
sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
FileSize
drupal8.random-toolbar.memory.patch8.02 KB

Just measuring some memory.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Needs review
FileSize
drupal8.random-toolbar.memory.patch8.55 KB

d'oh, it would help if I'd save my changes before creating patches ;)

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
FileSize
drupal8.random-toolbar.memory-static.patch9.68 KB
  1. More memory dumps
  2. Destructing the kernel/container in the installer
  3. Dumping drupal_static() to check for object references

A quick test run on my local box shows that drupal_static() apparently contains a full (form) render array tree, which is known to contain plenty of service instances and perhaps even the entire container.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Seen this happening at https://drupal.org/comment/8572311#comment-8572311 and https://drupal.org/comment/8572819#comment-8572819

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs work » Needs review
FileSize
2216701.16.test-only.patch57.52 KB
2216701.16.test-only.patch57.52 KB
2216701.16.test-only.patch57.52 KB
2216701.16.test-only.patch57.52 KB
2216701.16.test-only.patch57.52 KB
2216701.16.test-only.patch57.52 KB
2216701.16.test-only.patch57.52 KB
2216701.16.test-only.patch57.52 KB
2216701.16.test-only.patch57.52 KB

I've bisected and ran tests on the bots to discover that this problem was introduced by #2134857: PHPUnit test the entity base classes see the work on #2095771: alexpott's test issue

Considering #2134857: PHPUnit test the entity base classes was only introducing testability I suggest we revert it on this issue and set than one to needs work.

The patches attached to this comment are all the same - they revert that issue and patch run-tests to only run the test we're interested in. I'll post a revert only patch next.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Ho hum - I forgot to commit the patch to run tests to only run the test we're interested in... so those will run the full test suite... might as well them queued

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
FileSize
2216701.18.test-only.patch57.92 KB
2216701.18.test-only.patch57.92 KB
2216701.18.test-only.patch57.92 KB
2216701.18.test-only.patch57.92 KB
2216701.18.test-only.patch57.92 KB
2216701.18.test-only.patch57.92 KB
2216701.18.test-only.patch57.92 KB
2216701.18.test-only.patch57.92 KB

Let's not clog the bots...

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

Before rolling back, we could try to unset the services in __sleep() just like the urlGenerator?

Forget that. it extends from DependencySerialization, so that's supposed to handle that.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
FileSize
2216701.29.patch1.37 KB
2216701.29.patch1.37 KB
2216701.29.patch1.37 KB
2216701.29.patch1.37 KB
2216701.29.patch1.37 KB
2216701.29.patch1.37 KB
2216701.29.patch1.37 KB
2216701.29.patch1.37 KB

@Berdir sure

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
FileSize
2216701.31.patch57.52 KB

So that's good it appears DependencySerialization is not flawed phew. Patch attached just reverts #2134857: PHPUnit test the entity base classes

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

OH THANK GOODNESS.

Committed and pushed to 8.x. AWESOME sleuthing work here, folks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.