Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Updated: Comment #0
Problem/Motivation
Most problems with the D7 backport of Edit in version 1.0 RC1 are related to theme compatibility. Certain themes, including Omega and Zen, have as few wrapper divs as possible, to have cleaner markup. Including the <div class="region region-content"></div> wrapper… which Edit's JS relies upon for one edge case.
With extremely high probability, this will also become a problem in D8 for such themes.
Proposed resolution
In Drupal 7, this was solved by stopping to rely on the presence of the content region wrapper, and instead inject "start" and "end" markers for the content region.
Hat tip to fubhy — Omega maintainer — for coming up with this alternative!
Remaining tasks
Forward port #2178103: Stop requiring a content region wrapper + "region-content" class for maximum theme compatibility. But only do this after Edit 1.0 RC2 is released and users confirm that the problem is gone.
User interface changes
None.
API changes
None.
Comments
Comment #1
catchThis could happen any time, or if not it needs bumping priority.
Comment #2
xjmComment #3
mgiffordIt's not waiting on Edit any more https://www.drupal.org/project/edit right?
And as catch says, this could happen at any time.
Comment #4
Wim LeersNo, this is just blocked on somebody taking this on. It's a small issue that's been lingering for a long time. I'll probably do this eventually, but my focus now lies in other parts of Drupal core than Quick Edit.
Comment #5
mgiffordOk, often items that are postponed are just ignored in the queue as there are so many other issues that are marked active.
Unless there's a specific thing it's postponed on, best to leave it active I think so that someone knows they could pick it up and work on it.
Comment #6
Wim LeersYou're absolutely right. IDK why I marked it as postponed anymore. My bad.
Comment #7
mgiffordIt is pretty common.. I've been doing some gardening to try to clean it up a bit.. Made some mistakes, but...
Gardening the issue queue is a good role to encourage for the drupal community.
Comment #8
Wim LeersDefinitely!
Comment #9
Wim Leers#2407739: Remove classes from system templates r*.html.twig introduced a more permanent solution for all themes, one which #2568099: Follow-up for #2407739: Remove the js-quickedit-main-content class that was added in favor of relying on <main> is trying to improve/simplify further.
Therefore all that remains is documentation.
Comment #10
Wim LeersAlso related: #2559955: Ensure that Quick Edit relies less on the structure of the HTML.
Comment #21
SpokjeDue to Quickedit being moved out of Drupal Core and into a Contrib Module, moving this issue to the Contrib Module queue.