Feeds Import Integration for nodes

Hi I tried to use some code from the phone module
the file: telephone.feeds.inc

<?php
/**
 * @file
 * Implements Feeds support for telephone fields.
 */

/**
 * Implements hook_feeds_processor_targets_alter().
 *
 * @see FeedsNodeProcessor::getMappingTargets().
 */
function telephone_feeds_processor_targets_alter(&$targets, $entity_type, $bundle_name) {
  foreach (field_info_instances($entity_type, $bundle_name) as $name => $instance) {
    $info = field_info_field($name);
    if ($info['type'] == 'telephone') {
      $targets[$name . ':url'] = array(
        'name' => check_plain($instance['label']),
        'callback' => 'telephone_feeds_set_target',
        'description' => t('The @label field of the node.', array('@label' => $instance['label'])),
      );
    }
  }
}

/**
 * Callback for mapping. Here is where the actual mapping happens.
 *
 * When the callback is invoked, $target contains the name of the field the
 * user has decided to map to and $value contains the value of the feed item
 * element the user has picked as a source.
 */
function telephone_feeds_set_target($source, $entity, $target, $value) {
  if (empty($value)) {
    return;
  }

  // Handle non-multiple value fields.
  if (!is_array($value)) {
    $value = array($value);
  }

  // Iterate over all values.
  $i = 0;
  $info = field_info_field($target);
  list($field_name, $sub_field) = explode(':', $target);
  foreach ($value as $v) {
    if (empty($v)) {
      continue;
    }
    if (!is_array($v) && !is_object($v)) {
      $field['und'][$i]['value'] = $v;
    }
    if ($info['cardinality'] == 1) {
      break;
    }
    $i++;
  }
  $entity->{$field_name} = $field;
}

But Feeds is not seeing my new include file, tried clearing the cache but did not bring it up in the feed mappers targets

Hi

This above patch works if you uninstall feeds module and then reinstaal feeds.

Telephone will be available under the mappers.

@vlooivlerke: Did you try clearing the site caches rather than uninstalling the module?

Hi I did clear the site cache more than once.

It seems that clearing the cache does not make the new feed.ini page availableto feeds. Only uninstaaland/reinstall makes feed aware on the .inc file in my case. It is anointing.

But at least the telephone feed is now working

I can confirm that #1 is perfect solution.

Add "files[] = telephone.feeds.inc" to telephone.info

After clearing the cache, the telephone field is available.

Will this be added to the module for future updates?

Hi

I was thinking to use

Add "files[] = telephone.feeds.inc" to telephone.info

but inspecting other feed modules I noticed that it did not contain a string like that in the .info file.

Thanks, now I learned something too

That info file change wasn't needed when we added Feeds integration to Metatag.

The Feeds module keeps several records in the primary cache table, all that should be necessary is to do a full cache clear.

I rolled a patch with the fix in #1, which worked perfectly for me. I did a registry_rebuild and the importer came right up.

Patch in #8 works like a charm for me. Thanks!

#8 works for me. FWIW, I see an 'und' hard coded in, which may cause issues for multi lingual sites.

I jumped the gun on this one a little bit, the patch in #8 works only for creating a new user.

The telephone field value is properly set when creating a new user account, but if the Feed is set to update existing users, the telephone field's value will not be updated properly.

For example, creating a user via a CSV file works fine:

demo,demo@demo.com,1234567890

But when updating that same user via a new CSV file later, the new phone number is not saved:

demo,demo@demo.com,4567890123

Feeds reports that "There are no new users.".

Is there a hook(s) that can be added to the patch to indicate a telephone number is being updated? I've posted a fairly detailed description about this question here, and am looking to contribute to this issue's resolution: http://drupal.stackexchange.com/questions/135269/how-does-feeds-decide-i...

After further testing, the patch in #8 works fine for existing users if they did not have a telephone value. But if an existing user does have a telephone value, then the value does not get updated during the import (even if "update existing users" is set).

Cleaned up the patch a little bit including the 'und' mentioned in #10. Checked updating and it works for me, make sure that you have a unique field defined in your importer.

I also read on StackExchange that the issue mentioned in #11/#12 with importing for users was resolved.

The patch in #13 looks okay to me.

I created a Node importer and successfully updated a Telephone field on existing nodes and created new nodes with phone numbers.

I also tested this with a telephone field on a users, using profile2 and feeds_profile2. Creation and updating works for me.

The patch in #13 worked for me.

I created a Node importer and created new nodes with Telephone numbers. I also updated Telephone field values on existing nodes.

I just tested patch #13 with a telephone field on users. Using profile2 I added a telephone field to user entities. I used feeds_profile2 along with feeds to create the importer. I used the user name as a unique identifier and made sure that "update existing users" was selected.

Here is a screenshot of my mapping for the user processor:

And here is a screenshot of my settings for the user processor:

.csv files aren't allowed to be uploaded, so I've attached a .xsl version of the .csv I imported.

With this configuration I was able to update the phone number of user demo1 and successfully created user demo2.

Based on this I'm marking as RTBC.

Imported data into fields collection. Works great.

When I run the import from a file, it succeeds, but when I try to run the import using http fetcher, it throws

Notice: Undefined variable: field in telephone_feeds_set_target() (line 54 of /srv/bindings/e224733cdb3f43a0a1f61413eee21e21/code/sites/all/modules/telephone/telephone.feeds.inc).

I used patch # 13 to import telephones numbers into a content type / node and it worked fine. I did not check to see if it would update an existing field.

patch #13 works for me for both new field and updated field.

@gabriel.achille Does it work with multi-valued fields for you? Mine does not.

Have no time to roll a patch but have corrected #13 to work with multi-valued telephone fields. Replace _feeds_set_target from #13 with the following:

/**
 * Callback for mapping telephone fields.
 */
function telephone_feeds_set_target(FeedsSource $source, $entity, $target, array $values) {
  // Iterate over all values.
  $field = isset($entity->$target) ? $entity->$target : array('und' => array());

  foreach ($values as $value) {

    if (is_object($value) && ($value instanceof FeedsElement)) {
      $value = $value->getValue();
    }

    if (is_scalar($value) && strlen($value)) {
      $field['und'][] = array('value' => $value);
    }
  }

  $entity->$target = $field;
}

I am using a single-valued field, I don't know for multiple-valued field. But i can try your updated patch on my case and see if there is no regression.

I believe the last line should have been:

$entity->{$target} = $field;

Here is an updated patch.

I tested with single and multiple field values.

I can verify #27 works.

#27 tested in production, works for me

#27 also worked for me, Thank you.

#27 Works here too.. RTBC?

#27 Worked for me but telephone.feeds.inc file was placed into the Drupal root rather than sites/all/modules/telephone

#13, #27 worked for me. Thanks for support.

is a commit and publish scheduled soon?

Hello,

Osman how did you import multiple field values?

regards,

Update: Never mind. Tamper feeds worked for me.

#27 worked for me, sounds like this is RTBC

Confirmed #27 worked for me too. Was able to add a field in the importer and successfully import a telephone number. I think it's ready to roll in!

#27 worked for me after uninstall and reinstall of feeds module.

I can also confirm #27 works as advertised. It would be good to get this rolled into the dev snapshot at least. I'm happy to co-maintain if that will help move things along.

1. +++ b/telephone.feeds.inc
   @@ -0,0 +1,49 @@
   +/**
   + * Implements hook_feeds_processor_targets_alter().
   + */
   +function telephone_feeds_processor_targets_alter(&$targets, $entity_type, $bundle_name) {
   

   For other modules to easier override the target, consider to use the hook hook_feeds_processor_targets() instead (available since Feeds 7.x-2.0-beta1). See https://www.drupal.org/node/2638830.

2. +++ b/telephone.feeds.inc
   @@ -0,0 +1,49 @@
   +      $field['und'][$delta][$column] = (string) $value;
   

   To support multilinguality, the field should respect the mapping option "language": https://www.drupal.org/node/2638802. This mapping option is available since Feeds 7.x-2.0-beta2.

Thanks for the suggestions @MegaChriz.

I re-rolled the patch with the suggestions.

Works for me, thanks!

#42 worked like a charm. Thanks!

#42 worked for me as well. Thanks much!

#42 not working for me :(
i uninstalled / reinstalled feeds 3 times
clear cache
...

still not working

I use it with CRM Core entities, perhaps it's the reason ?

it was related to another issue with CRM core and feeds, problem is fixed now

https://www.drupal.org/node/2549793#comment-11201041

#42 worked for me as well.

#42 worked fine for me.

Hello,

shortly, have you planned to add the patch #42 in the next version on this module?

#42 works for me.

feeds 7.x-2.0-beta2
telephone 7.x-1.0-alpha1

Hey, just a quick note to say #42 is working for me on Telehpone 7.x-1.0-alpha1 and feeds 7.x-2.0-beta2. Thanks osman :)

#42 worked for me with Telephone 7.x-1.0-alpha1 and Feeds 7.x-2.0-beta2 as well. Did not need to uninstall/reinstall Feeds, only had to clear cache.

"#42 worked for me with Telephone 7.x-1.0-alpha1 and Feeds 7.x-2.0-beta2"

I confirm as well.

Wanted to give some more feedback about telephone feeds. I have three telephone fields (main, fax, toll-free) that could be filled in for a content type. I was using phone module and only getting a single phone number entry out of 200. I assumed it was the module and switched to this one. (I added the patch #42 before trying any feeds, so I can't comment on if the patch helps or not.)

But even with telephone, I was having the same issue--only one entry was getting the data. It turned out that it was the only one that had all three telephone fields filled in. In order to get any of the numbers filled, I had to add numbers for all three fields.

I tried to add only one of the fields in the feed at a time.

I tried to add dummy data and then reimport again trying to clear it out.

I ended up adding dummy data and then removing with VBO, but it was a very strange experience that I wanted to add to the pool of knowledge.

RTBC #42. Could you please add it to dev and create a new alpha or beta release?

I think the module could use a new comaintainer..

#42 works with SQL import. Previously nothing would happen- field would show up in interface and import preview would show a value but no values would be imported into the field/database.

So #55 is definitely an issue, I have confirmed it with patch #42. I will investigate further. I think the last field in the bundle (or in the import, not sure) is not being populated no matter what-- so when there is only one field populated, it is the last field so it is skipped.

Number #55 needs to be reviewed before proceeding.

Signing up for this one.

Thank you gisle, according to #59 I'd suggest do rewrite the foreach to

foreach ($values as $delta => $value) {

and remove the manual count. Perhaps that may solve one of the problems.

The patch in #42 works, but only for nodes (not users).

Based upon extensive testing, I do not think it is not possible to make it work correctly for users if there are more than one telephone field in the user profile (see report in #55).

I've created a child issue (#2998265: Feeds Import Integration for the user entity) to solve this specific use case.

However, I believe that the vast majority of use cases only involve feeding into nodes, or into user entities with a single telephone field. So to move this issue forward, I've rerolled the patch in #42 to give a meaningful error message if the use case is not supported. I have not changed anything else. This is intended as an intermediary solution, until the child issue is also resolved.

I've also uploaded a file "test_csv.txt" (rename to "test.csv") for those who want to test feed imports with multiple telephone fields.

Please review.

I've tested the patch #63 with a custom entity type using feeds_entity_processor module. It worked perfectly! Thank you!

If you need to import telephone numbers into the user entity (as opposed to nodes), you may want to implement hook_field_user_import_supported_alter and use User Import to import the fields.

For an example of this hook for phone fields, check out the Phone Field. This project already has this hook implemented.

Just applied patch #63 to latest version and it worked perfectly for me.
Telephone showed up in the import feeds and the import worked too. :)

Telephone is moving from core so closing old D7 tickets