When using drush make, it would be great if dependencies are downloaded automatically.

CommentFileSizeAuthor
#12 plupload_needs_docs_add_make-2088143-12.patch1.03 KBgarphy
#8 plupload-1_5_8-drush_make-2088143-7.patch512 byteshswong3i
#6 plupload-1_5_8-drush_make-2088143-6.patch1.38 KBhswong3i
#5 plupload-1_5_8-drush_make-2088143-5.patch1.37 KBhswong3i
#4 plupload-drush_make-2088143-4.patch502 byteshswong3i
#2 plupload-drush_make-2088143-2.patch504 byteshswong3i
#1 plupload-drush_make_support.patch511 bytesChris Charlton
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chris Charlton’s picture

Chris Charlton
Primary language English
Location Los Angeles
CreditAttribution: Chris Charlton commented
Issue summary: View changes
Issue tags: +drush, +make
FileSize
plupload-drush_make_support.patch511 bytes

Drush Make support patch attached. It even includes a line that will apply the "examples" folder security patch

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
Assigned: Unassigned » hswong3i
Status: Active » Reviewed & tested by the community
Related issues: +#1903850: [meta] Patch to remove plupload library examples folder for Drupal distribution
FileSize
plupload-drush_make-2088143-2.patch504 bytes

Port from drustack_wysiwyg.make

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented

Patch is now applied to drustack_wysiwyg.make

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented
FileSize
plupload-drush_make-2088143-4.patch502 bytes

1.5.7 archive from github don't coming with js folder, but 1.x branch does (https://github.com/moxiecode/plupload/commit/19af7a0f80aff1f090957924953...)

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented
FileSize
plupload-1_5_8-drush_make-2088143-5.patch1.37 KB

Include patch for version detect >= v1.5.7

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented
FileSize
plupload-1_5_8-drush_make-2088143-6.patch1.38 KB

Update with correct patch URL.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Title: Add make file so dependencies are downloaded automatically » [Needs docs] Add make file so dependencies are downloaded automatically
Status: Reviewed & tested by the community » Needs work
Issue tags: +Documentation

Thank you all! Make file committed. Changelog approach for version check was already added in #2171575: Plupload library not found (version 1.5.8) .

Would be great to have some docs for that (in readme and on documentation pages). Marking as "Needs work" until we sort that out. Any contributions in that direction are very welcome.

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented
Status: Needs work » Needs review
FileSize
plupload-1_5_8-drush_make-2088143-7.patch512 bytes

Sorry that I just able to find this patch applied to 7.x-2.x, but nothing for 7.x-1.x? Patch re-roll for 7.x-1.x only.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Needs review » Needs work

Committed. Thanks.

  • Commit ec1c3e5 on 7.x-1.x, 8.x-1.x by slashrsm: 
    Issue #2088143 by hswong3i, Chris Charlton | lsolesen: Add make file so...
pvhee’s picture

pvhee CreditAttribution: pvhee commented

It is a "soft standard" to call this makefile .make.example so Drush doesn't automatically build all dependencies when used in an automatic build process (see e.g. comment on this thread: https://www.drupal.org/node/1968252#comment-9000229) Could this file be renamed as well, if not it's impossible to apply patches to the plupload library independently without patching the plupload module.

garphy’s picture

garphy CreditAttribution: garphy commented
Status: Needs work » Needs review
FileSize
plupload_needs_docs_add_make-2088143-12.patch1.03 KB

Here is a patch which rename the .make file to .make.example.

  • slashrsm committed e8138f0 on 7.x-1.x authored by garphy 
    Issue #2088143 by garphy | pvhee: Rename .make file to .make.example
slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Needs review » Fixed

Committed. Thanks!

  • slashrsm committed 87d4da2 on 8.x-1.x authored by garphy 
    Issue #2088143 by garphy | pvhee: Rename .make file to .make.example

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

budalokko’s picture

budalokko CreditAttribution: budalokko commented

Committed to 7.x-2.x too.