Closed (fixed)
Project:
Scald: Media Management made easy
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Jun 2013 at 11:39 UTC
Updated:
1 Jun 2015 at 18:24 UTC
Jump to comment: Most recent
Comments
Comment #1
slybud commentedI think we should wait for scald_video to be released and stable to move the actual 3 providers out of scald's core.
That would make sense IMHO (only generic file providers for main atom types would be in scald core)
Comment #2
jcisio commentedThere should not be 3rd service integration in the core project. Therefore I'm making it a task.
No META because it's a simple task.
Comment #4
nagy.balint commentedYouTube provider is now a contrib module: Scald YouTube
Comment #5
nagy.balint commentedVimeo provider is now a contrib module: Scald Vimeo
Comment #8
nagy.balint commentedThe Dailymotion provider got moved to contrib as well: Scald Dailymotion
So I guess with this the task is done, as all 3rd party service integration modules are out of the core.
Comment #9
slybud commentedThank you for the work.
Maybe we should also consider having a basic video provider in core (file upload with html5 player), otherwise people would not be able to register video atoms w/o 3rd party providers
Also, we need to be very careful with the upgrade path and the CHANGELOG for next release, don't we ?
Comment #10
nagy.balint commentedThere is already a Scald Video module.
I don't think we can just internalize it, and making another one in core is also maybe not the best idea.
I guess an upgrade path would to:
- Update to latest version
- Install scald youtube/vimeo/dailymotion depending on what is used on the site
- Registry Rebuild (drush rr)
Then it should be fine, as it will be just like you moved a module and nothing else changed.
Comment #11
nagy.balint commentedWell if @SylvainM agrees, then i can commit the scald_video provider in core.
Comment #12
jcisio commentedIf we add scald_video, we should not add the extra players (the basic HTML5 default markup is ok).
Comment #13
nagy.balint commentedAnd the extra players would be "scald_video_extras" or "scald_video_players" or something else.
Comment #14
sylvainm commentedYep, I think it's a good idea to have a basic video provider and player.
@nagy.balint: you can commit it :)
I think the 2 players now packaged with scald_video should be two different new modules:
* scald_video_videojs
* scald_video_jw_player
Comment #15
nagy.balint commented@SylvainM
Okey thanks, I will commit the base module to Core then.
Could you create these additional modules?
Comment #17
nagy.balint commentedThe base scald_video is now committed to core.
Comment #18
nagy.balint commentedI have tested upgrade on the youtube provider.
For Youtube, Vimeo and Dailymotion:
- Install Registry Rebuild (if not already installed) either as a drush command or as a php file.
Explanation at https://www.drupal.org/project/registry_rebuild
- Update to the latest version of Scald Core
- Download the youtube/vimeo/dailymotion modules depending on which ones were used before on the site
- Run Registry Rebuild
For scald_video:
- Install Registry Rebuild (if not already installed) either as a drush command or as a php file.
Explanation at https://www.drupal.org/project/registry_rebuild
- Disable and uninstall the scald_video players that are used on the site. Do not disable or uninstall the scald_video module itself.
- Delete the scald_video module already existing on the site
- Update to the latest version of Scald Core
- Download one of the two player modules that was used on the site
- Run Registry Rebuild
Seems to work fine that way.
Comment #19
nagy.balint commentedCreated the video player modules:
https://www.drupal.org/project/scald_video_videojs
https://www.drupal.org/project/scald_video_jw_player
@SylvainM : Gave you maintainer rights.
Comment #20
nagy.balint commentedAll newly created modules have been tagged with stable release.
I think the task is done then.
Comment #21
sylvainm commented@nagy.balint: thanks, I'm just reading your demand to create the 2 additional modules :)