Make Scald core clean and easier to maintain. But which ones?

Comments

slybud’s picture

I think we should wait for scald_video to be released and stable to move the actual 3 providers out of scald's core.
That would make sense IMHO (only generic file providers for main atom types would be in scald core)

jcisio’s picture

Title: [META] Move some providers into contrib » Move some providers into contrib
Category: Feature request » Task
Issue summary: View changes
Priority: Normal » Major

There should not be 3rd service integration in the core project. Therefore I'm making it a task.

No META because it's a simple task.

  • nagy.balint committed 71134ec on 7.x-1.x
    Issue #2025785: Move YouTube provider into contrib
    
nagy.balint’s picture

YouTube provider is now a contrib module: Scald YouTube

nagy.balint’s picture

Vimeo provider is now a contrib module: Scald Vimeo

  • nagy.balint committed cfbbe84 on 7.x-1.x
    Issue #2025785: Move scald_vimeo provider into contrib
    

  • nagy.balint committed 15cafe9 on 7.x-1.x
    Issue #2025785: Move Dailymotion provider into contrib
    
nagy.balint’s picture

Status: Active » Fixed

The Dailymotion provider got moved to contrib as well: Scald Dailymotion

So I guess with this the task is done, as all 3rd party service integration modules are out of the core.

slybud’s picture

Status: Fixed » Needs review

Thank you for the work.

Maybe we should also consider having a basic video provider in core (file upload with html5 player), otherwise people would not be able to register video atoms w/o 3rd party providers

Also, we need to be very careful with the upgrade path and the CHANGELOG for next release, don't we ?

nagy.balint’s picture

There is already a Scald Video module.
I don't think we can just internalize it, and making another one in core is also maybe not the best idea.

I guess an upgrade path would to:
- Update to latest version
- Install scald youtube/vimeo/dailymotion depending on what is used on the site
- Registry Rebuild (drush rr)

Then it should be fine, as it will be just like you moved a module and nothing else changed.

nagy.balint’s picture

Well if @SylvainM agrees, then i can commit the scald_video provider in core.

jcisio’s picture

If we add scald_video, we should not add the extra players (the basic HTML5 default markup is ok).

nagy.balint’s picture

And the extra players would be "scald_video_extras" or "scald_video_players" or something else.

sylvainm’s picture

Yep, I think it's a good idea to have a basic video provider and player.
@nagy.balint: you can commit it :)

I think the 2 players now packaged with scald_video should be two different new modules:
* scald_video_videojs
* scald_video_jw_player

nagy.balint’s picture

@SylvainM
Okey thanks, I will commit the base module to Core then.

Could you create these additional modules?

nagy.balint’s picture

The base scald_video is now committed to core.

nagy.balint’s picture

I have tested upgrade on the youtube provider.

For Youtube, Vimeo and Dailymotion:
- Install Registry Rebuild (if not already installed) either as a drush command or as a php file.
Explanation at https://www.drupal.org/project/registry_rebuild
- Update to the latest version of Scald Core
- Download the youtube/vimeo/dailymotion modules depending on which ones were used before on the site
- Run Registry Rebuild

For scald_video:
- Install Registry Rebuild (if not already installed) either as a drush command or as a php file.
Explanation at https://www.drupal.org/project/registry_rebuild
- Disable and uninstall the scald_video players that are used on the site. Do not disable or uninstall the scald_video module itself.
- Delete the scald_video module already existing on the site
- Update to the latest version of Scald Core
- Download one of the two player modules that was used on the site
- Run Registry Rebuild

Seems to work fine that way.

nagy.balint’s picture

Created the video player modules:
https://www.drupal.org/project/scald_video_videojs
https://www.drupal.org/project/scald_video_jw_player

@SylvainM : Gave you maintainer rights.

nagy.balint’s picture

Status: Needs review » Fixed

All newly created modules have been tagged with stable release.

I think the task is done then.

sylvainm’s picture

@nagy.balint: thanks, I'm just reading your demand to create the 2 additional modules :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.