The node module contains some theming logic + ugly css within node_revision_overview:
$row[] = array('data' => t('!date by !username', array('!date' => l(format_date($revision->timestamp, 'short'), "node/$node->nid"), '!username' => theme('username', array('account' => $revision))))
. (($revision->log != '') ? '<p class="revision-log">' . filter_xss($revision->log) . '</p>' : ''),
'class' => array('revision-current'));
$row[] = array('data' => drupal_placeholder(t('current revision')), 'class' => array('revision-current'));
we should align the class names to the new smacss standards.
#2004252: node.html.twig template
#1921610: [Meta] Architect our CSS
CSS Coding Standards
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | cleanup_css_in-2004702-7.patch | 2.38 KB | alansaviolobo |
| #4 | drupal-cleanup_node_revision_overview_css-2004702-4.patch | 2.11 KB | svefre |
| #2 | core-cleanup-css-node_revision_overview_2004702-2.patch | 1.98 KB | dasjo |
Comments
Comment #1
c4rl commentedCan you be more specific? What parts of this do you want to change and why? Go ahead and update the issue summary with
<code>blocks.Comment #2
dasjoi have added a code block to the issue summary and attached a patch that tries to align classes with the new standards.
its not perfect though, as we don't really have objects to style here but rather use the classes for simply styling current revisions with a certain color.
Comment #4
svefre commentedComment #4.0
svefre commentedUpdated issue summary.
Comment #5
Sumit kumar commentedComment #6
star-szrComment #7
alansaviolobo commentedComment #8
andrefy commentedComment #9
andrefy commentedI took a look to the patch, it seems fine, follow SMACSS standards but another issue show up, so can't verify it working in Drupal.
http://cl.ly/image/3g3T1Y2v222T here is an screenshot of the issue I found while looking at the review table, it was printing HTML tags.
Comment #10
andrefy commentedComment #25
smustgrave commentedThank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Comment #26
smustgrave commentedSince there's been no follow up and NodeController appears to have since been updated.