Follow up for #1921818: Modify drupal_rewrite_settings() to allow writing $settings values

Problem/Motivation

The current implementation of drupal_rewrite_settings() does not allow sticking settings to their comment blocks as proposed in the original issue description.

However, the comment blocks in settings.php are helpful and we want the settings to stick to those blocks.

Proposed resolution

Add more states to drupal_rewrite_settings() when stepping through each token in settings.php trying to replace any variables that are in the passed-in array.

Remaining tasks

Reviews needed.

User interface changes

None.

API changes

None.

Original report by heyrocker

#1921818: Modify drupal_rewrite_settings() to allow writing $settings values

CommentFileSizeAuthor
#14 1988138-14.patch4.35 KBderjochenmeyer
#11 1988138-11.patch3.36 KBderjochenmeyer
#9 1988138-9.patch3.37 KBderjochenmeyer
#7 1988138-7.patch3.37 KBderjochenmeyer
#4 1988138-4.patch3.36 KBderjochenmeyer
#4 interdiff.txt1.27 KBderjochenmeyer
#1 1988138-1.patch3.41 KBderjochenmeyer

Comments

derjochenmeyer’s picture

derjochenmeyer commented
Status: Active » Needs review
StatusFileSize
new 1988138-1.patch3.41 KB
derjochenmeyer’s picture

derjochenmeyer commented
Title: Modify drupal_rewrite_settings() to allow writing $settings values » Modify drupal_rewrite_settings() to allow sticking settings to their comment block

Better title.

Status: Needs review » Needs work

The last submitted patch, 1988138-1.patch, failed testing.

derjochenmeyer’s picture

derjochenmeyer commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.27 KB
new 1988138-4.patch3.36 KB

This should work.

Status: Needs review » Needs work

The last submitted patch, 1988138-4.patch, failed testing.

derjochenmeyer’s picture

derjochenmeyer commented
Status: Needs work » Needs review

#4: 1988138-4.patch queued for re-testing.

derjochenmeyer’s picture

derjochenmeyer commented
StatusFileSize
new 1988138-7.patch3.37 KB

Status: Needs review » Needs work

The last submitted patch, 1988138-7.patch, failed testing.

derjochenmeyer’s picture

derjochenmeyer commented
Status: Needs work » Needs review
StatusFileSize
new 1988138-9.patch3.37 KB

fix encoding.

Status: Needs review » Needs work

The last submitted patch, 1988138-9.patch, failed testing.

derjochenmeyer’s picture

derjochenmeyer commented
StatusFileSize
new 1988138-11.patch3.36 KB

Tested again.

derjochenmeyer’s picture

derjochenmeyer commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1988138-11.patch, failed testing.

derjochenmeyer’s picture

derjochenmeyer commented
Status: Needs work » Needs review
StatusFileSize
new 1988138-14.patch4.35 KB

The last patch actually works. The tests need to be rewritten because with this patch the settings are replaced instead of being overridden in a new line.

alansaviolobo queued 14: 1988138-14.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 14: 1988138-14.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Issue summary: View changes
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +stale-issue-cleanup

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Since there's been no follow up in 3+ months going to close this one out. If still valid task please re-open.

Thanks