Follow up for #1921818: Modify drupal_rewrite_settings() to allow writing $settings values
Problem/Motivation
The current implementation of drupal_rewrite_settings() does not allow sticking settings to their comment blocks as proposed in the original issue description.
However, the comment blocks in settings.php are helpful and we want the settings to stick to those blocks.
Proposed resolution
Add more states to drupal_rewrite_settings() when stepping through each token in settings.php trying to replace any variables that are in the passed-in array.
Remaining tasks
Reviews needed.
User interface changes
None.
API changes
None.
Original report by heyrocker
#1921818: Modify drupal_rewrite_settings() to allow writing $settings values
Comment | File | Size | Author |
---|---|---|---|
#14 | 1988138-14.patch | 4.35 KB | derjochenmeyer |
#11 | 1988138-11.patch | 3.36 KB | derjochenmeyer |
#9 | 1988138-9.patch | 3.37 KB | derjochenmeyer |
#7 | 1988138-7.patch | 3.37 KB | derjochenmeyer |
#4 | 1988138-4.patch | 3.36 KB | derjochenmeyer |
Comments
Comment #1
derjochenmeyer CreditAttribution: derjochenmeyer commentedComment #2
derjochenmeyer CreditAttribution: derjochenmeyer commentedBetter title.
Comment #4
derjochenmeyer CreditAttribution: derjochenmeyer commentedThis should work.
Comment #6
derjochenmeyer CreditAttribution: derjochenmeyer commented#4: 1988138-4.patch queued for re-testing.
Comment #7
derjochenmeyer CreditAttribution: derjochenmeyer commentedComment #9
derjochenmeyer CreditAttribution: derjochenmeyer commentedfix encoding.
Comment #11
derjochenmeyer CreditAttribution: derjochenmeyer commentedTested again.
Comment #12
derjochenmeyer CreditAttribution: derjochenmeyer commentedComment #14
derjochenmeyer CreditAttribution: derjochenmeyer commentedThe last patch actually works. The tests need to be rewritten because with this patch the settings are replaced instead of being overridden in a new line.