Voting starts in March for the Drupal Association Board election.
Convert the following theme functions to use the new table #type:
|Module||Theme function name||Where in Code||What is it really?|
Changes in this patch
- theme_node_search_admin() is removed (along with the theme hook "node_search_admin").
- This theme function was only used for theming the content ranking section of the config page for the NodeSearch plugin in NodeSearch::buildConfigurationForm(). That function is refactored to use a regular #type = table render array instead of #theme = node_search_admin.
- In the process of doing that, the form elements for the weights of the rankings changed their HTML element names in the markup, so NodeSearch::submitConfigurationForm() also changed how it reads the ranking values for saving in the config, and SearchRankingTest also had to change how it submitted these forms.
- An Aria label is added to the ranking HTML selects, for accessibility.
Manual testing steps
- Enable the Search module
admin/config/search/pages/manage/node_searchto review the generated HTML.
Beta phase evaluation
|Issue category||Task because we only change the way the markup for an admin page is generated.|
|Issue priority||Major because parent meta issueis major.|
|Unfrozen changes||Unfrozen because it only changes the way markup is being printed|
|Prioritized changes||This is not a prioritized change for the beta phase.|
|Disruption||Non disruptive for core because we only change way markup is being printed. It also improves accessibility by providing aria-labels instead of hidden|
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,872 pass(es). View
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,075 pass(es). View