diff --git a/core/modules/node/node.module b/core/modules/node/node.module index 3cd3607..33ff28c 100644 --- a/core/modules/node/node.module +++ b/core/modules/node/node.module @@ -804,40 +804,6 @@ function node_user_predelete($account) { } /** - * Returns HTML for the content ranking part of the search settings admin page. - * - * @param $variables - * An associative array containing: - * - form: A render element representing the form. - * - * @see node_search_admin() - * @ingroup themeable - */ -function theme_node_search_admin($variables) { - $form = $variables['form']; - - $output = drupal_render($form['info']); - - $header = array(t('Factor'), t('Influence')); - foreach (Element::children($form['factors']) as $key) { - $row = array(); - $row[] = $form['factors'][$key]['#title']; - $form['factors'][$key]['#title_display'] = 'invisible'; - $row[] = drupal_render($form['factors'][$key]); - $rows[] = $row; - } - $table = array( - '#type' => 'table', - '#header' => $header, - '#rows' => $rows, - ); - $output .= drupal_render($table); - - $output .= drupal_render_children($form); - return $output; -} - -/** * Title callback: Displays the node's title. * * @param \Drupal\node\NodeInterface $node diff --git a/core/modules/node/src/Plugin/Search/NodeSearch.php b/core/modules/node/src/Plugin/Search/NodeSearch.php index 8ebb9cc..c874514 100644 --- a/core/modules/node/src/Plugin/Search/NodeSearch.php +++ b/core/modules/node/src/Plugin/Search/NodeSearch.php @@ -568,18 +568,25 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta '#title' => t('Content ranking'), '#open' => TRUE, ); - $form['content_ranking']['#theme'] = 'node_search_admin'; $form['content_ranking']['info'] = array( '#markup' => '

' . $this->t('Influence is a numeric multiplier used in ordering search results. A higher number means the corresponding factor has more influence on search results; zero means the factor is ignored. Changing these numbers does not require the search index to be rebuilt. Changes take effect immediately.') . '

' ); + // Prepare table. + $header = array(t('Factor'), t('Influence')); + $form['content_ranking']['rankings'] = array( + '#type' => 'table', + '#header' => $header, + ); // Note: reversed to reflect that higher number = higher ranking. $range = range(0, 10); $options = array_combine($range, $range); foreach ($this->getRankings() as $var => $values) { - $form['content_ranking']['factors']["rankings_$var"] = array( - '#title' => $values['title'], - '#type' => 'select', + $form['content_ranking']['rankings'][$var]['name'] = array( + '#markup' => $values['title'], + '#type' => 'markup', + ); + $form['content_ranking']['rankings'][$var]['value'] = array( '#options' => $options, '#default_value' => isset($this->configuration['rankings'][$var]) ? $this->configuration['rankings'][$var] : 0, ); @@ -592,8 +599,8 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta */ public function submitConfigurationForm(array &$form, FormStateInterface $form_state) { foreach ($this->getRankings() as $var => $values) { - if (!$form_state->isValueEmpty("rankings_$var")) { - $this->configuration['rankings'][$var] = $form_state->getValue("rankings_$var"); + if (!empty($form_state['values']['rankings'][$var]['value'])) { + $this->configuration['rankings'][$var] = $form_state['values']['rankings'][$var]['value']; } else { unset($this->configuration['rankings'][$var]); diff --git a/core/modules/search/src/Tests/SearchRankingTest.php b/core/modules/search/src/Tests/SearchRankingTest.php index dce09b9..6c86e2b 100644 --- a/core/modules/search/src/Tests/SearchRankingTest.php +++ b/core/modules/search/src/Tests/SearchRankingTest.php @@ -102,7 +102,7 @@ public function testRankings() { $this->cronRun(); // Test that the settings form displays the context ranking section. - $this->drupalGet('admin/config/search/pages/manage/node_search'); + $this->drupalGet('admin/config/search/settings/manage/node_search'); $this->assertText(t('Content ranking')); // Check that all rankings are visible and set to 0. @@ -114,10 +114,10 @@ public function testRankings() { $edit = array(); foreach ($node_ranks as $node_rank) { // Enable the ranking we are testing. - $edit['rankings_' . $node_rank] = 10; - $this->drupalPostForm('admin/config/search/pages/manage/node_search', $edit, t('Save search page')); - $this->drupalGet('admin/config/search/pages/manage/node_search'); - $this->assertTrue($this->xpath('//select[@id="edit-rankings-' . $node_rank . '"]//option[@value="10"]'), 'Select list to prioritize ' . $node_rank . ' for node ranks is visible and set to 10.'); + $edit['rankings'] = array($node_rank => array('value' => 10)); + $this->drupalPostForm('admin/config/search/settings/manage/node_search', $edit, t('Save search page')); + $this->drupalGet('admin/config/search/settings/manage/node_search'); + $this->assertTrue($this->xpath('//select[@id="edit-rankings-' . $node_rank . '-value"]//option[@value="10"]'), 'Select list to prioritize ' . $node_rank . ' for node ranks is visible and set to 10.'); // Reload the plugin to get the up-to-date values. $this->nodeSearch = entity_load('search_page', 'node_search'); @@ -126,15 +126,15 @@ public function testRankings() { $set = $this->nodeSearch->getPlugin()->execute(); $this->assertEqual($set[0]['node']->id(), $nodes[$node_rank][1]->id(), 'Search ranking "' . $node_rank . '" order.'); // Clear this ranking for the next test. - $edit['rankings_' . $node_rank] = 0; + $edit['rankings'] = array($node_rank => array('value' => 0)); } // Save the final node_rank change then check that all rankings are visible // and have been set back to 0. - $this->drupalPostForm('admin/config/search/pages/manage/node_search', $edit, t('Save search page')); - $this->drupalGet('admin/config/search/pages/manage/node_search'); + $this->drupalPostForm('admin/config/search/settings/manage/node_search', $edit, t('Save search page')); + $this->drupalGet('admin/config/search/settings/manage/node_search'); foreach ($node_ranks as $node_rank) { - $this->assertTrue($this->xpath('//select[@id="edit-rankings-' . $node_rank . '"]//option[@value="0"]'), 'Select list to prioritize ' . $node_rank . ' for node ranks is visible and set to 0.'); + $this->assertTrue($this->xpath('//select[@id="edit-rankings-' . $node_rank . '-value"]//option[@value="0"]'), 'Select list to prioritize ' . $node_rank . ' for node ranks is visible and set to 0.'); } }