Change record status: 
Project: 
Introduced in branch: 
8.0.x
Description: 

Summary

  1. The theme hook node_search_admin and corresponding function theme_node_search_admin() were removed, as their sole purpose was to build a table.
  2. In NodeSearch::buildConfigurationForm(), instead of putting #theme => 'node_search_admin' in the render array, we now use #type => table and build the table rows in this function directly instead of in the theme function.
  3. This table holds the settings for ranking factors for search results. The form element names for these settings have been changed to a structure better suited for #type => table.

Before

// Build array for the form:
$form['content_ranking']['factors']['rankings_$var'] = [
  '#type' => 'select',
  ...
]

// Values retrieved from form state:
$form_state->getValue("rankings_$var");

After

// Build array for the form:
$form['content_ranking']['rankings'][$var]['value'] = [
  '#type' => 'table',
  ...
]

// Values retrieved from form state:
$form_state->getValue(['rankings', $var, 'value']);
Impacts: 
Module developers