Problem/Motivation

As @webchick said in #1510544-126: Allow to preview content in an actual live environment

I found my natural inclination while testing this was to want to be able to save right when I'm looking at the page

Follow-up of #1510544: Allow to preview content in an actual live environment

Proposed resolution

Add save button as per #1751606: Move published status checkbox next to "Save" to the preview bar.

Remaining tasks

  1. Postpone on #1510544: Allow to preview content in an actual live environment and #1751606: Move published status checkbox next to "Save".
  2. Add save button.

User interface changes

We'll have a save button next to "Back to content editing" link.

API changes

None

save button.png

CommentFileSizeAuthor
#43 1899360-43.patch6.74 KBmgifford
save button.png39.97 KBjibran

Issue fork drupal-1899360

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue summary: View changes
Status: Postponed » Active
Parent issue: » #1510544: Allow to preview content in an actual live environment

#1510544: Allow to preview content in an actual live environment is in.

Bojhan’s picture

Bojhan commented

I am not sure how I feel about this, the idea is that you return to the content creation page - as that is the central interface.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

If anything I'd turn the "Back to content editing interface" button into a drop-down to save space.

yoroy’s picture

yoroy commented

Interesting case where you can't save on the node form when preview is made required: #2354469: Can't create node, if preview is required

swentel’s picture

swentel commented
Related issues: +#2354469: Can't create node, if preview is required
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Related issues: +#2325463: Destination URL breaks preview, +#2341221: Node preview bar has usability issues, is difficult to use on mobile, not usable without Bartik, and does not align with the Seven style guide and current toolbar designs
dawehner’s picture

dawehner
Primary language German
commented
Component: base system » node system

.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

yoroy’s picture

yoroy commented
Issue tags: +ux-workflow

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

pixelmord’s picture

pixelmord commented
Issue tags: +dcmuc16
dimiter’s picture

dimiter commented
Assigned: Unassigned » dimiter
yoroy’s picture

yoroy commented

Oooh nice, did you get anywhere with this?

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Do we still need this? Even after the recent changes in node form?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

This has nothing to do with them I think, so would still be useful.

However, I expect quite a few problems with this, specifically that all non-field based things would be lost if we simply save the node, e.g. menu link changes. Otherwise we'd need to submit the node form and not just save the node we have.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +Needs usability review

I had always envisioned this working in the way you describe, so carrying over all of the field values as well as the node values. (I'm surprised it doesn't already do that, given that it previews those values?)

However, we might want to revisit this issue in UX meeting, because we recently ripped out the dropbutton pattern on the node form due to its obtuseness for content authors.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Yes, it wouldn't be a dropbutton anymore, just a save I guess and possibly explicitly display the status?

node values = field values (a node/entity is nothing but a set of fields with values). But there are things that are *not* saved on the node, and the menu link settings are one example of that. That's not visible because we are not actually previewing/showing that anywhere. It works right now because we store the whole form state including all submitted values and then we restore it, but it woudln't work if we'd just do a $node->save(), then those changes would be gone.

Bojhan’s picture

Bojhan commented
Issue tags: -Needs usability review

Lets proceed with the idea, but we need to figure out the best execution.

handkerchief’s picture

handkerchief
Primary language German
Location Chur, Switzerland
commented

Great! I'm glad this will be implemented. This is a very important feature for us, because it's intuitive to save the node direct in the preview. Less unnecessary clicks.

handkerchief’s picture

handkerchief
Primary language German
Location Chur, Switzerland
commented

It would be nice, if the save dropbutton would also be at the end of the form as usual. But it's a "nice to have".

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

kapil17’s picture

kapil17 commented

In which release we are having this feature of saving node on preview page ???

Thanks

adminMN2023’s picture

adminMN2023 commented

Hi, is this the same as a SAVE Progress type button? I am editing long pages and it would be nice to have a save button that does not send the used to a preview screen from which they then have to drill back dow to node to keep editing. "Save" "Save and Preview"

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Version: 8.8.x-dev » 9.1.x-dev

Yes this is still a usability issue and would be a very user friendly improvement to have.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

trishkaideka’s picture

trishkaideka commented

Recently I have had multiple clients request this feature.

It would be a great addition to the usability of the node preview form.

gngn’s picture

gngn commented

I agree that this would be big usability improvement (and my clients also request this feature).

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

boyar’s picture

boyar commented

Created a small module for this - https://www.drupal.org/project/node_preview_save

acbramley’s picture

acbramley commented
Issue tags: +Needs title update, +Needs issue summary update

We don't have dropbuttons for saving anymore so we need a title and IS update here.

Also #19 is probably going to cause massive confusion over this if that wasn't also taken into account.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Title: Add save dropbutton next to 'Back to content editing' link in node preview. » Add save dbutton next to 'Back to content editing' link in node preview
Assigned: dimiter » Unassigned
Issue summary: View changes
Issue tags: -Needs title update, -Needs issue summary update

I still yearn for this feature whenever I'm in preview mode.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Title: Add save dbutton next to 'Back to content editing' link in node preview » Add save button next to 'Back to content editing' link in node preview

I was scratching my head about the "dbutton" but believe that was just a typo.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

bonus points for someone who wants to convert https://www.drupal.org/project/node_preview_save into a core patch and add an assertion or preview save button click to a test.

mgifford’s picture

mgifford
he/him
Primary language English
commented
StatusFileSize
new 1899360-43.patch6.74 KB

So @joseph.olstad something like this patch?

Note, AI was used in the creation of this patch (and I haven't tested it).

joseph.olstad opened merge request !16780

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Thanks Mike!

MR 16780 diff/patch
and
Pipeline

Had a quick look at the patch. It applies cleanly to the "main" branch so I decided it should see a pipeline.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Needs work

patch causes a regression in the javascript testing it looks like.

Please investigate