The default global theme setting for toggle_node_user_picture and toggle_comment_user_picture is TRUE so the test will always work. Even if you move theme settings out of variables and into CMI :)

Files: 
CommentFileSizeAuthor
#3 1864290-3.drupal8.user-picture-test.remove-vset.patch1.66 KBalexpott
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 1864290-3.drupal8.user-picture-test.remove-vset.patch. Unable to apply patch. See the log in the details link for more information. View
#2 1864290-2.drupal8.user-picture-test.patch1.65 KBalexpott
PASSED: [[SimpleTest]]: [MySQL] 49,347 pass(es). View
#1 1864290-1.drupal8.user-picture-test.remove-vset.patch1.14 KBalexpott
PASSED: [[SimpleTest]]: [MySQL] 49,046 pass(es). View

Comments

alexpott’s picture

Status: Active » Needs review
FileSize
1.14 KB
PASSED: [[SimpleTest]]: [MySQL] 49,046 pass(es). View

Patch attached just removes the variable_set()'s to show that they have no effect on the outcome on the test.

alexpott’s picture

FileSize
1.65 KB
PASSED: [[SimpleTest]]: [MySQL] 49,347 pass(es). View

Patch attached fixes the tests so that we are actually testing the ability to enable / disable user pictures on nodes and comments.

alexpott’s picture

FileSize
1.66 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 1864290-3.drupal8.user-picture-test.remove-vset.patch. Unable to apply patch. See the log in the details link for more information. View

Bah... mistake in the comment for the new test that completely turns off user pictures..

Status: Needs review » Needs work

The last submitted patch, 3: 1864290-3.drupal8.user-picture-test.remove-vset.patch, failed testing.

mgifford’s picture

Assigned: alexpott » Unassigned
Issue summary: View changes

This still a concern in D8? Unassigned issue too.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.