This depends on #1863898: Views revision link handlers are broken and #1826604: Add a dropbutton field handler to Views

This is one of the only content listings without it's own custom hook_ENTITY_operations().

Files: 
CommentFileSizeAuthor
#10 1863906-replace_content_revisions-10.patch23.89 KBpcambra
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1863906-replace_content_revisions-10.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#8 vdc-1863906-8.patch12.3 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vdc-1863906-8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#4 vdc-1863906-4-HACK.patch26.52 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 49,324 pass(es).
[ View ]
#1 vdc-1863906-1.patch24.57 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 49,265 pass(es), 4 fail(s), and 91 exception(s).
[ View ]
#1 vdc-1863906-1-withoutdropbutton-do-not-test.patch10.34 KBtim.plunkett
#1 vdc-1863906-1-WITH-A-HACK.patch25.98 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 49,292 pass(es), 4 fail(s), and 1 exception(s).
[ View ]

Comments

tim.plunkett’s picture

Assigned:Unassigned» tim.plunkett
Status:Active» Needs review
StatusFileSize
new25.98 KB
FAILED: [[SimpleTest]]: [MySQL] 49,292 pass(es), 4 fail(s), and 1 exception(s).
[ View ]
new10.34 KB
new24.57 KB
FAILED: [[SimpleTest]]: [MySQL] 49,265 pass(es), 4 fail(s), and 91 exception(s).
[ View ]
tim.plunkett’s picture

Issue tags:+VDC

Status:Needs review» Needs work

The last submitted patch, vdc-1863906-1-WITH-A-HACK.patch, failed testing.

tim.plunkett’s picture

Status:Needs work» Needs review
StatusFileSize
new26.52 KB
PASSED: [[SimpleTest]]: [MySQL] 49,324 pass(es).
[ View ]

Status:Needs review» Needs work

The last submitted patch, vdc-1863906-4-HACK.patch, failed testing.

xjm’s picture

tim.plunkett’s picture

tim.plunkett’s picture

StatusFileSize
new12.3 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vdc-1863906-8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Rerolled for dropbutton, still hacky and blocked.

larowlan’s picture

Also we have a diff library in core, would be nice to get a diff in a modal for the body field. Probably out of scope.

pcambra’s picture

Assigned:Unassigned» pcambra
StatusFileSize
new23.89 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1863906-replace_content_revisions-10.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Here's a re-roll of this, still needs quite some work.

Also opened #2032977: Add views support for the missing columns of node_field_revision as a follow up of this one as we've lost some properties in views at some point.

pcambra’s picture

Need to check also #1863898: Views revision link handlers are broken as the revision links seems to be being fixed there

dawehner’s picture

+++ b/core/modules/node/node.moduleundefined
@@ -1351,16 +1351,6 @@ function node_menu() {
-  $items['node/%node/revisions'] = array(
-    'title' => 'Revisions',
-    'page callback' => 'node_revision_overview',
-    'page arguments' => array(1),
-    'access callback' => '_node_revision_access',
-    'access arguments' => array(1),
-    'weight' => 20,
-    'type' => MENU_LOCAL_TASK,
-    'file' => 'node.pages.inc',
-  );

I really hope that noone complains about the missing revision UI when views is not installed.

+++ b/core/modules/node/node.pages.incundefined
index 1fa8689..bf44f7f 100644
--- a/core/modules/views/lib/Drupal/views/Tests/DefaultViewsTest.php

--- a/core/modules/views/lib/Drupal/views/Tests/DefaultViewsTest.php
+++ b/core/modules/views/lib/Drupal/views/Tests/DefaultViewsTest.phpundefined

+++ b/core/modules/views/lib/Drupal/views/Tests/DefaultViewsTest.phpundefined
+++ b/core/modules/views/lib/Drupal/views/Tests/DefaultViewsTest.phpundefined
@@ -32,6 +32,7 @@ class DefaultViewsTest extends ViewTestBase {

@@ -32,6 +32,7 @@ class DefaultViewsTest extends ViewTestBase {
     'backlinks' => array(1),
     'taxonomy_term' => array(1),
     'glossary' => array('all'),
+    'content_revisions' => array(1),
   );

We could also add node_field_revisions to HandlerAll test. In general I don't think have to add the view here as we have a good test coverage provided by node module anyway.

Pancho’s picture

I really hope that noone complains about the missing revision UI when views is not installed.

Given that content is anyway pretty much unmanageable without Views now, I think that doesn't add much on top.

However, Views module shouldn't say "Create customized lists and queries from your database." as description. It should mention being needed for system views, too. Created #2037783: Make module description for Views reflect its importance to cover that aspect.

Pancho’s picture

Status:Needs work» Needs review

Let's test #10 to see how close we are.

Regarding the missing revision UI without Views:

Given that content is anyway pretty much unmanageable without Views now, I think that doesn't add much on top.

was a bit overstating. We should probably have some basic fallback here, too.

Status:Needs review» Needs work

The last submitted patch, 1863906-replace_content_revisions-10.patch, failed testing.

dawehner’s picture

Mh I have to admit that sort of, because there is no other way to find the revisions of a node.
This is difficult to discuss.

pcambra’s picture

Status:Needs work» Postponed

Agreed, we need to provide a fallback for the node revisions.

I'm marking this "blocked" by #1863898: Views revision link handlers are broken & #2032977: Add views support for the missing columns of node_field_revision

xjm’s picture

Issue summary:View changes
Issue tags:+beta target
xjm’s picture

Priority:Normal» Major