Add views support for the missing columns of node_field_revision [#2032977]

These columns are defined by hook_schema but not in hook_views_data for node_field_revision:

langcode
default_langcode (I don't think this is necessary)
revision_timestamp
created
comment (I don't think this is necessary)
promote
sticky

Not sure if all this columns need to be stored in this table, things like created, comment, promote, sticky seem a little redundant?

Comment	File	Size	Author
#2	2032977-missing_node_field_revision-2.patch	2.92 KB	pcambra
#1	2032977-missing_node_field_revision.patch	2.6 KB	pcambra

Comments

Comment #1

pcambra

he/him

Spanish

commented 2 July 2013 at 11:22

Status:

Active

» Needs review

Status	File	Size
new	2032977-missing_node_field_revision.patch	2.6 KB

Comment #2

pcambra

he/him

Spanish

commented 2 July 2013 at 11:27

Status	File	Size
new	2032977-missing_node_field_revision-2.patch	2.92 KB

Added revision timestamp

Comment #3

dawehner

German

commented 4 July 2013 at 09:53

Issue tags:

+Needs tests, +VDC

I guess we want to have some basic tests in order to know that it works in the future.
The actual missing fields (coming probably from the node_revision => node_field_revision page). look fine.

The question is whether we want to support a filter for the langcode if the language module is disabled (a basic string one).

Comment #4

pancho

UTC+2 🇪🇺 EU

commented 9 July 2013 at 11:15

Priority:	Normal	» Major
Status:	Needs review	» Postponed
Issue tags:		+revisit before beta

Doesn't block #1863906: [PP-1] Replace content revision table with a view, so I'm tentatively postponing this to the critical #1998366: [meta] SQLite is broken, which will soon introduce changes to the whole schema. Marking it major + tagging it, though.