Port of emfield to 6.0

absolutely! however, since it depends on cck, i figured i'd wait for development till that was done first. however, i'll go ahead and branch it in cvs to get things started

we'll be starting this next week.

Awesome. The Dojo will be needing this module for the new website, so we are willing to help out. If the port isn't too crazy, you could also consider making it a DROP task.

Yeah I'm really keen on a drupal 6 port. I'll look at it if I have the time.

subscribed

Still waiting :)

Yeah CCK won't be released until Views 2 is finished :(

hey aaron, now that CCK is at an alpha i'd like to start poking at this. I see that you branched about 2 months ago but newer stuff has gone into 5 dev. So should I go off the older 6 branch or should I work on the port to 6 from current HEAD?

add1sun

alex just cleaned up the repository (because we were committing to different branches...)

i *believe* we decided not to use HEAD anymore, and instead the 5 dev. that means we should port to 6 from the current 5 dev. the work i did a couple of months ago, as you point out, is now obsolete (though was a good learning experience for me).

i think that alex may have also recently restarted the d6 port, so we should wait to hear from him about it.

thanks for the offer for help!

aaron

Actually, HEAD is still the one being used for 5.x-dev, but we should move it asap. The current HEAD has tons of improvements, for example I went through with Coder and took care of all the reported issues, so I would definitely start from that. I didn't get to starting to use coder to do the D6 port, so we're basically at square one right now.

I am going to help/learn/work on emfield's drupal 6 port ..

Thanks

Changed title to make it easier to follow the various 6.0 ports

subscribe

hi alex,
I have resolved all errors reported by coder, and few more which were not reported, Basically I did not fix issues related to nodereferences contrib/cck ? there is a 6 version for cck .. Will it be worthwhile to read the code and start that ..
If not what should be the next step ?

Coder module was a good exercise and I got to read a lot on changes from 5 to 6 .. If you get time then lemme know of the course ..

@dipen, could you post a patch for what you have so far?

@addisun,
As mentioned baove I have made an attempt to clean to fix the code according to coder module, but it doesn't work on drupal 6, Even menu hook is giving a problem, although I have tried to follow the guidelines given on porting from drupal 5 to drupal 6, Its still is not working .. I am attaching the zip of the whole module, If you please get time then can you suggest some way to proceed with this ?
Maybe I have missed some concepts, this is my first attempt to port ..

Thanks ..

is the zip working for you guys ?
It is working for me now !! Yay !! I mean atleast setting configurations and so on !!

I added a embedded video field and as expected, it gives sql error ..
which is as below ..

 # user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'NOT NULL DEFAULT ''''' at line 1 query: ALTER TABLE content_type_test ADD `field_test_embed` NOT NULL DEFAULT '''' in C:\wamp\www\drupal-6.2\includes\database.mysql-common.inc on line 298.
# user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'NOT NULL DEFAULT ''''' at line 1 query: ALTER TABLE content_type_test ADD `field_test_data` NOT NULL DEFAULT '''' in C:\wamp\www\drupal-6.2\includes\database.mysql-common.inc on line 298 

Also I am attaching a screenshot of error ..

I have added Dipen's latest version to CVS, so please submit any changes that you make as patches against the DRUPAL-6--1 branch.
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/emfield/?pa...

Also, I searched around to see if anyone else had encountered these exact errors, and 5 star gave the same errors for seemingly the same reason: http://drupal.org/node/232108

This patch may be useful to figure out what needs to be changed in emfield:
http://drupal.org/files/issues/fivestar_cck6.patch

Also, here is the handbook page for CCK Developers updating modules from 5.x to 6.x:
http://drupal.org/node/191796

hey alex :)
I will look at the cck issue, thanks for the links .. Btw, the zip worked for you right ?
My drupal config was :
drupal 6.2
cck 6.x alpha
emfield - above zip

Alex,

u have used text_disable in emfield.install file, it should be emfield_disable :)

so yeh i read fivestar patch .. I am still at the same problem, I have updated
hook_widget, hook_field_settings, hook_widget_info

no success it seems :|

Thanks Dipen, I fixed that item.

Did you check out the CCK document? There are a lot of changes in the way CCK works that could be causing the error. My initial guess is that the following is creating the errors:

Drupal 6 uses E_ALL testing, which creates errors anytime a field array is missing any indexes. Field arrays are merged with the default value arrays to be sure all parts of the field and widget have indexes set so they never create undefined index errors. This means all field values will always return true to isset(), and module authors should not use isset() to test if values exist for form elements on the field settings form. Instead use is_array(), is_numeric() or similar tests.

isset() is used 41 times in the module...

Alex,
Yes I did read the document, It could understand it only partially as I never worked with cck for D5 as in on programming front, I am planning to do a lil bit of reading, before taking it on again ..

Btw, How do u checkout 6.1 branch of emfield ? I have cvs repo set up in eclipse .. I see the tree of /cvs/drupal and /cvs/drupal-contrib .. where to go in that ?

This patch fixes the 'NOT NULL DEFAULT ''''' bug. Patched against the DRUPAL-6--1 branch.

Committed. Thanks!

I missed some things such as db field type definitions - instead longtext it should be type=text, size=big.
Also fixed NOT NULL DEFAULT ''''' bug + longtext field definition in video_cck and emaudio

I committed this.

@Dipen- can you try this version and let me know if you still get the db errors?

hi alex, nonsie

Nope, Now I dont get error on field creation now, Now I know What I was missing .. However field doesnt show up on create node type form .. Do you guys also experience that

Btw if you enable Image field module, then It will give u fatal error because of non closing of array .. Below is the patch

Update:

I could get the field on the node type create form .. But when I enter lets say youtube url, It stores NULL in DB .. content module handles node submit right ?

just committed #29. thanks, dipen

just committed hook_content_is_empty for emfield/video/image/audio modules

hi aaron,
below is the patch (no good for committing) As I was playing with video_cck module only and not others .. Basically by this I was able to see the field on node creation form, You can apply this on ur sandbox and then debug that non storing of values in DB .. I was trying to understand workflow of content module and hence was cut, copying pasting ..
I think we need to restructure emfield_emfield_widget function for reuse like in 5.7 with all field modules ..

Again : Its no good for committing :) and its just for video fields ..

By the above patch you should be able to see your video field on node creation form .. and yeh only video fields only ..
Also the html output is almost identical to 5.7 field (that works) hence I do not know why this doesn't work .. I am surely missing something in cck working .. I will be reading text field code to understand that ..

Also I guess we dont have to handle Multiple fields any more .. I have not tested though, so we can really get rid of lots of code in case: 'form'
in emfield_emfield_widget function in emfield.module ..

just committed "content_notify in .install files"

note that emfield is not in itself a cck field module; it is a helper module for video_cck, image_ncck, and emaudio, which actually contain the hooks for cck (and simply hook into emfield for its engine). someone had put the content_notify in emfield.install, rather than the other three modules. i've corrected that.

confusing, i know. sorry, i should document things better internally to make it more clear.

thanks for all the great work, everyone! we're making good progress.

aaron

cleaned up and committed field db columns -- they all pass through emfield for consistency

added to the various hook_field_info functions:

'callbacks' => array(
        'tables' => CONTENT_CALLBACK_DEFAULT,
        'arguments' => CONTENT_CALLBACK_DEFAULT,
      ),

we need to see if we should change any or all of those to CONTENT_CALLBACK_CUSTOM

also added widget info (also need to double check those values, though i think they'll be adequate in this case)

      'multiple values' => CONTENT_HANDLE_CORE,
      'callbacks' => array(
        'default value' => CONTENT_CALLBACK_DEFAULT,
        ),

i think emthumb will need to add the following to the widget forms:

$form['#attributes']['enctype'] = "multipart/form-data";

but i'm going to work on that module after the basic modules are done. we'll have to check the workflow to ensure it gets added properly, since that's modifying existing widget forms.

yes aaron,
emfield_emfield_widget is a helper function and its been written with $op as prime mover, With no access to $op in hook_widget, we need to restructure that as mentioned in IRC ..
also most of the callbacks we need not give, untill we implement our own handling of the filed, I think If we are able to make one of the field types (me playin with video_cck, yesterday) work, then it would be just code refactoring then .. Im still not sure which hook or part of the code ensures that values are passed on to content module loyally ..

I have a doubt :
Is the only functionality of a cck field module is to attach it to form array ? and give appropriate info in terms of $columns and other stuff to content module and content module does handle its storing .. I guess we are not able to pass appropriate info to content module in that case.

I installed the latest cvs version.

And tried to edit a node which is a content type that has a video_cck and an image_cck field. This is what i got;

Fatal error: Call to undefined function _widget() in /public_html/sites/all/modules/cck/includes/content.node_form.inc on line 157

#41

What is the cck version u are using ? Also I am right now figuring out only video cck, couldn't get time for last 2 days.. try disabling image cck field for emfield coz even the signature is incorrect for hook_widget in image_ncck_widget, According to 6.x version of cck .. fields should now use hook_widget(&$form,&$form_state,$field,..) (i dont rem the last one :P)
so try disabling cck integration for image_ncck and then see if u get the error, I am able to see the field on the node creation form (video cck field) my only problem is, its storing NULL in db .. Maybe I will get some time today ..

Thanks for reporting this :)

#41

Also its in development and like not even functionally working right now, as you would have read in the comments .. But maybe soon :)

I know that it is, but I've been waiting for a 6.x version for too long, so I would love to help in speeding the process :)

Btw, I disabled the image module (it's a bit hard process for me because of a problem about cck) now I can open the editing page.

But I neither see the video edit fields in that edit page, nor see the video in the node page. I just see the field group in which the video field included and also which is an empty box.

I have created an official release for the Drupal 6 version (6.x-1.x-dev), so that non-CVS users could download and test the current build.

I have installed the latest CVS, here is the result;

http://www.hecatomber.org/ayakustu/11.03.2008/youtube-the-great-escape-p...

There should be an embedded video of youtube.

Also this is how the node edit page looks like;

http://uploads.screenshot-program.com/upl7923181924.jpg

we'll definitely drop emimport from the contrib list for d6; it's a bit obsolete now with feedapi. that'll make things slightly easier.

After submit the add field and edit field form it wrote this error:

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'unsigned DEFAULT NULL' at line 1 query: ALTER TABLE content_type_video ADD `field_video_embed` LONGTEXT unsigned DEFAULT NULL in /Users/Bobik/Sites/includes/database.mysql-common.inc on line 298.
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'unsigned DEFAULT NULL' at line 1 query: ALTER TABLE content_type_video ADD `field_video_value` VARCHAR(255) unsigned DEFAULT NULL in /Users/Bobik/Sites/includes/database.mysql-common.inc on line 298.
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'unsigned DEFAULT NULL' at line 1 query: ALTER TABLE content_type_video ADD `field_video_provider` VARCHAR(255) unsigned DEFAULT NULL in /Users/Bobik/Sites/includes/database.mysql-common.inc on line 298.
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'unsigned DEFAULT NULL' at line 1 query: ALTER TABLE content_type_video ADD `field_video_data` LONGTEXT unsigned DEFAULT NULL in /Users/Bobik/Sites/includes/database.mysql-common.inc on line 298.

Hi, my name is Luis i come up with the same problem as dipen chaudhary and did the patches he suggested and got stuck in the exact same place as he is.. i cant see the capture the field now but i cant see the video... if there is any help i could get it would be great :)

hi all,
I have been very busy these days and also was not feeling well .. I will take a look at this today hopefully .. Lets finish this port, Its hanging for long now .. Any help is appreciated ..

subscribing...

Spent a couple hours on this today and I made a lot of progress. Didn't get all of the way though. This patch applies to DRUPAL-6--1. I'm just now seeing that there's another patch at #33 that does some of this, so sorry if I'm stepping on anyones toes.

With this patch you can now:
-create emfield fields and add them to content types (your preferences will be saved).
-create/edit nodes. The form fields will show up.
-enter data, the data is saved (But only for the first field if the field is setup to accept multiple values).
-the data is not however being parsed. Only the field_*_emebd column is populated correctly, field_*_value is incorrect, and field_*_provider and field_*_data are not populated.
-with the big modifications to emfield_emfield_widget() there may be a regression where blank values are stored for multi-value fields.
-with the big modifications to emfield_emfield_widget() emthumb may not work (I think it will have to add a 2nd submit handler to the form maybe).
-the embeded media is not displayed when the node is viewed (because the data is not being parsed, and possibly other reasons).

Ran out of time to investigate further. cck/examples/example_field.php and cck/examples/simple_field.php are good resources to figure out how things are supposed to be.

@dalin - your patch didn't attach to your post...

Whoops! Head's back on straight now. Here's the patch:

Thanks- I committed your changes.

Hi, im a newbie and need to embbed video on drupal 6. I found this thread but its kind of confusing. Do i need all these files or is there a latest file to download that has the patches in it?

This module is not ready to be used for Drupal 6, so please check back on this thread later. When a version is ready to be used and tested by the broader community we will update this thread plus add a note on the main emfield page.

latest commits:

* Separate rss nodeapi functionality into emfield.rss.inc (aaron).
* Separate cck functions into emfield.cck.inc (aaron).
* Separate admin callback into emfield.admin.inc (aaron).
* Move theme functions to video_cck.theme.inc (aaron).
* Implement hook_theme in video_cck (aaron).

sub

subscribing

subscribing

Please don't change the titles of issues for no reason.

And don't change priority. Randomly editing issues for no reason can get you blocked.

While I'm here, this isn't a bug, it is a task.

I'll start testing too

I appreciate everyones work getting this into D6, does anyone have an ETA?

Attached is a patch to a bunch of the files, which addresses changes to how #default_value is handled. I used Nate's patch here as a reference:
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/link/link.m...

I'm adding this as a patch, rather than committing, to ensure that I did this the right way.

I also changed function emfield_emfield_content_is_empty .

It looks like the big issue we're having now is with creating and storing the [data] part of the emfield array. I assume this has to do with the following errors that I see when I submit a node with an embedded video field:

# notice: Undefined variable: return in C:\xampp\htdocs\drupal6\sites\all\modules\emfield\emfield.cck.inc on line 83.
# notice: Undefined index: data in C:\xampp\htdocs\drupal6\sites\all\modules\emfield\emfield.cck.inc on line 80.
# notice: Undefined index: provider in C:\xampp\htdocs\drupal6\sites\all\modules\cck\content.module on line 883

As to an ETA: I don't think we're that far off, but there are still quite a few changes that need to be made. If anyone can help troubleshoot the data array issue we may be able to get a working version soon.

Please disregard the last patch.

OK - went ahead and submitted my corrected #default_value changes to emfield.cck.inc, video_cck.module, image_ncck.module, and emaudio.module.

Next up- figure out why $return isn't being defined.

hi there,
@dalin

-enter data, the data is saved (But only for the first field if the field is setup to accept multiple values).

I dont see the data being saved in DB

@Alex,
I troubleshooted it a lot for many hours long time ago, I think I know the reason,I can atleast point to variables and functions, me thinks.. Basically I need to dig in and recall what all I found out.. Will report soon ..

@Dipen- Actually it is saving something in the database- but only the address that you enter in. The data array, which is where it usually stores the info that it gets via emfield_request_xml (which is working fine) isn't getting stored. I'm pretty sure the problem is with one of the functions in emfield.cck.inc (but I could be wrong).

hello and thanks-

not sure if i should be posting this info here-
or on the module issues page?

...so forgive the duplicate post (or please go ahead and delete, admins)-
as it is not my intention to duplicate content-
just to provide some info that i assume the developer would like to know.

so, using: 6.x-1.x-dev (2008-Jul-05)

getting a bunch of errors like this:

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in yourdomain.com/sites/all/modules/emfield/emfield.module on line 39

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in yourdomain.com/sites/all/modules/emfield/emfield.module on line 249

i did a find and replace for '&$'... and found like 5-10 instances,
where i removed the '&', leaving just the '$'

seems to be working now-
and / or at least not throwing the errors.

thanks,
vincent, in buffalo
http://www.basicmagic.net

subscribing

subscribe

I actually made emfield work on drupal 6, but I had to change some of the methods in the video cck that were trying to call them_blah functions using the theme() function. These functions aren't registered anymore due to the theme registry. If you just call the methods directly, you're videos will start displaying. For example, the last two functions in google.inc need to call theme_video_cck_google_flash directly. We're embedding the video in a theme with the following code:

$options = array('width'=>640, 'height'=>'480');
print theme('video_cck_video_video', NULL, $node->field_video_url[0], '', $node, $options); 

subscribing...

subscribe

subscribing...

absolutely the best media embedding module i think, i'm hoping to use it again soon :)

subscribing

subscribing

Subscribe. This module is one of the few that's keeping me back on Drupal 5.x and I would love to have it for D6.

*sighs*

waits a little longer :P

is there by any chance an eta when we might expect this? :)

subscribing

I think we're getting close, but I can't say for certain. We're still having the same problem that I mentioned in #70- that the $data array isn't getting stored in the database for some reason even though it gets built correctly. As soon as we figure out what the cause of that is then emfield should be usable for NEW users. It will still take some more time after that, however, to finish the migration path since we just yesterday standardized all of the names for the modules, meaning users upgrading will need a path to get from database entries that mention video_cck and image_ncck to emvideo and emimage respectively. Also- emimport is now officially deprecated in favor of feedapi and the feedapi element mapper.

But keep your fingers crossed- we may have a working version this week. And as always- if anyone can help troubleshoot why the $data array isn't saving then it may go a lot faster!

Thanks for your patience everyone!

Let me take the opportunity to say what I'm sure the maintainers are thinking, but don't say out of politeness.

Folks this is an Open Source project. The maintainers of this project work on it in their spare time for enjoyment, or for their clients. There are a few ways to frustrate a maintainer:

-"Why isn't this ready yet?"
-"I reeeeeeealy need this. When will it be ready?"

Here are some examples of ways to encourage a maintainer and get the port to happen quicker:

-contribute patches
-Not everyone's a coder, that's fine, you can test patches and give detailed comments on what worked and what didn't.
-become the maintainer's client and pay them to work on the port
-post a RFP in the Paid Drupal services forum to hire someone else to work on the port.

Actively watching the progress on this as well so I can update my provider files. Veoh, GUBA, IMEEM, etc.
Also, revamped the 5.x dailymotion provider file to finally extract thumbnails :p

Thanks bangpound! This gets us a big step further, though it's still not displaying correctly for me, that's a much easier problem to troubleshoot.

Getting closer!

So, for anyone reading along, the next issue seems to be with function emfield_parse_embed

I'd like to help test this. Im not much of a coder but if you need me to try something i can run it through devel or whatnot and give back reading. Im not sure how much i could help but i would also like to see this finished and am willing to test if necessary. The version from CVS is the most recent im assuming, plus patches since the 18th.

Sorry- disregard the last comment- it's actually parsing it fine...

after installing this i get the error

Warning: Call-time pass-by-reference has been deprecated;.... etc

this is normal for now until this module is completed?

It depends which provider you're trying to use, but atm many of the video providers are still using theme functions that aren't being added to the theme registry (for example theme_emvideo_youtube_flash()). However there is also a problem with the way it is passing the parsed provider link (for example http://youtube.com/watch?v=XgfII5Xfv6Q should be getting parsed and then sent to emvideo_youtube_embedded_link($video_code) as XgfII5Xfv6Q, but instead the entire url gets sent), which I'm guessing is related to $view not getting constructed and rendered, although not necessarily.

I'm looking into the rendering issue for a client, and I notice that emvideo_theme() is incorrect. The array it returns uses a bunch of unintialized variables (probly copied from the function declarations). It should look like:

function emvideo_theme() {
  return array(
    'emvideo_video_embed' => array(
      'arguments' => array('field' => NULL, 'item' => NULL, 'formatter' => NULL, 'node' => NULL, 'options' => array()),
      'file' => 'emvideo.theme.inc',
    ),
    'emvideo_video_thumbnail' => array(
      'arguments' => array('field' => NULL, 'item' => NULL, 'formatter' => NULL, 'node' => NULL, 'no_link' => FALSE, 'options' => array()),
      'file' => 'emvideo.theme.inc',
    ),
    'emvideo_video_video' => array(
      'arguments' => array('field' => NULL, 'item' => NULL, 'formatter' => NULL, 'node' => NULL, 'options' => array()),
      'file' => 'emvideo.theme.inc',
    ),
    'emvideo_default' => array(
      'arguments' => array('field' => NULL, 'item' => NULL, 'formatter' => NULL, 'node' => NULL, 'options' => array()),
      'file' => 'emvideo.theme.inc',
    ),
    'emvideo_video_preview' => array(
      'arguments' => array('field' => NULL, 'item' => NULL, 'formatter' => NULL, 'node' => NULL, 'options' => array()),
      'file' => 'emvideo.theme.inc',
    ),
    'emvideo_thickbox' => array(
      'arguments' => array('field' => NULL, 'item' => NULL, 'formatter' => NULL, 'node' => NULL, 'options' => array()),
      'file' => 'emvideo.theme.inc',
    ),
  );
}

Even when this is fixed, it's still not working for me, but I hope this gets someone on the right track. If I get it working I will post a patch.

Thanks- I've committed your changes.

Based on the code in content_field of content.module, each item for a field is given a theme value which is of the form

  $module . '_formatter_' . $formatter_name;

drupal_render in common.inc then calls

  $content = theme($elements['#theme'], $elements);

Therefore, the different emfield modules need to register and implement theme functions with the signature similar to

  function theme_emvideo_formatter_video_video($element)

where "emvideo" and "video_video" are appropriately replaced.

  function theme_emvideo_formatter_video_video($element) {
    return $element['#item']['value'];
  }

This function will return the constructed html.

Also, I added the follwing code to the switch statement in _emfield_emfield_field of emfield.cck.inc

  case 'sanitize':
    foreach ($items as $delta => $item) {
      $content =  module_invoke($module, 'field_formatter', $field, $item, 'video_video', $node);
      $items[$delta]['value'] = $content;
    }
    break;

I am not sure if this was the correct place to do the formatting, but the video shows up.

I committed #99. I'll try and get to #98 tonight.

Thanks! We're really close now!

Here's a few Coder fixes to try and get this contrib back into line. I didn't change any features or functionality.

subscribing

test

@venkataramana, I'm assuming you missed a line in the project list. Moving this back where it belongs.

I committed #101- thanks! I'm still trying to get #98 to work...

There are three Warning: Call-time pass-by-reference errors within emfield.mod And I think they're all solvable this morning unless someone steps in to correct me about something I'm not seeing here.

Line 45 causes two of them:

/**
 *  A helper function for hook_field(), called by the various sub-modules.
 */
43. function emfield_emfield_field($op, &$node, $field, &$items, $teaser, $page, $module) {
44.   module_load_include('inc', 'emfield', 'emfield.cck');
45.   return _emfield_emfield_field($op, &$node, $field, &$items, $teaser, $page, $module);
46. }

Line 45 passes off to emfield.cck.inc, as we can see in line 44. Why line 45 needs to pass two of it's params by reference to the private function in emfield.cck.inc is beyond me. The _emfield_emfield_field() function in emfield.cck.ink looks like this:

/**
 * Implementation of hook_emfield_field().
 */
39. function _emfield_emfield_field($op, &$node, $field, &$items, $teaser, $page, $module) {
40.   switch ($op) {
41.     case 'validate':
          ~ ~ ~ ~
          break;
  }
}

I can understand why $node and $items need to be passed be reference when calling the originating helper function, emfield_emfield_field(), but why do we need a call-time pass-by-reference for these two vars when handing them off to the private function _emfield_emfield_field() which is slated for a pass-by-reference on incoming vars anyway?

Seems redundant to me, and unnecessary, and it's causing PHP5 warnings. Can I nuke the &$node and &$items on emfield.module's line 45 without hurting anything?

Here's a one-line comment patch that adds more description to _emfield_emfield_field().

This patch changes the General Settings fieldset from collapsed to open, because without this patch, the first things you see upon arriving on the administrative settings page is, well, nothing. Check it out for yourself.

subscribing!

subscribing.

sub

I tested out the latest CVS version that was committed on 7/25, and I wasn't able to get any videos to appear on the page. It still looks like the provider links aren't being parsed correctly. URLs from YouTube and Google Video were being saved in their entirety rather than just the as the video ID from the URL.

Has anyone else gotten this part working with latest CVS version? Do I need to add the last few patches that were posted since Alex committed the latest version on the morning of 7/25?

The commit at comment #105 is the latest and greatest code. The patches that were posted since then won't affect your described scenaria.

I have been able to get custom url and youtube videos to show up. I placed my comments on what I had to do in #98 and #99. However, I must have forgotten some things. Looking back at my code, I noticed that I had to abandon proper theme hooks in the providers for emvideo. My solutions for these issues were arrived at by looking into how CCK and themes worked. Therefore, there are probably a lot of half-baked ideas in the changes that I made. I am uploading my hacked version of the module so those who really know what is going on can see how I made my videos show up and, hence, come up with a way of integrating my changes which is more in keeping with drupal. Also, to the maintainers of emfield, this is a really cool module.

Could you upload just a patch instead of the entire module?

Ok- it looks like we (zivtech) need this for a client, so it will officially get put on the "front burner" this week, and a patch should be ready by (hopefully) Friday.

I love it when the open source community modules get 'funded' by a pressing client need. This is gonna be awesome! Go Alex!

subscribe

man so many posts for one module lol haven't seen this before :)

Here is a patch for getting emvideo to work. I added a function to emfield.module and changed how emvideo gets its theme function information from the providers. I have tested it with most of the video providers. I had to make some changes to the extract functions for some of the providers to get it to work. I would not say they are foolproof, but I got spike to work from embed code and added a regex for bliptv.

All I can say is "Wow!" Thanks for such a thorough patch! It patched fine, and I'm testing it out right now...

I tested all of the video providers and it looks like they all work! (I didn't test custom_url, but I assume it works as well).

I just committed the patch- looks like we have a working version of emfield for Drupal 6!

There are still some issues we'll need to deal with (I'm getting a ton of errors on the nodes with embedded videos), and the links to original file on node->edit aren't working correctly yet. We also need to create an upgrade path from 5->6 before we can put this into an alpha release.

I committed Senpai's patches from comments 107 + 108. Comment 106 was included in cshoney's patch.

Video works great :)

I can't manage to get image fields working.

All the nodes given in the address below supposed to view images;

http://www.hecatomber.org/ayakustu/resim

also don't forget to add a database update which will rename "cck_video" or "cck_image" field names to "emvideo" or "emimage" etc.

that's what http://drupal.org/node/284438 is for (upgrade path). we'll also need to cover views.

This is a patch for emimage. I was able to get Flickr and Picasa to work, but not ImageShack. I did not try Photobucket.

Thanks chsoney- committed!

Hey Guys....
I downloaded the latest nightly build of emfield, and I assume it includes pretty much all the patches that are listed here, up to that point (august 7, 2008) but after installing, I'm getting errors when submitting a youtube video link (emfield_video). I'm getting the same error twice...that error is:

warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'theme_emvideo_youtube_flash' was given in /html/includes/theme.inc on line 597.

Any thoughts? Is there a patch here that I'm missing?

@bobchristenson- that may be related to Aaron's changes to youtube.inc that he committed yesterday. Maybe you should post a comment here: http://drupal.org/node/292559

I fixed the theme_emvideo problems. We mistakenly reverted to using video_cck references in the last commit and there wasn't a valid call to the function in emvideo.theme.inc .

Fatal error: Call to undefined function _embthumb_file_insert() in
/home/vegthrea/public_html/writ8/sites/all/modules/emfield/contrib/emthumb/emthumb.module on line 148

Unable to view videos anyone know whats going on here?

fixed #131

I ported and committed the missing emvideo providers: vimeo, veoh, imeem, lastfm, and guba.

A quick update: I changed some of the l() functions to respect the new api arguments, and changed the blip.tv player back to the original embedding method which allows the show player to work correctly.

Since many parts of the module are working correctly, and some people were having trouble staying on top of the dev releases, I have released an alpha version of emfield for Drupal 6.

I installed a few minutes ago the alpha version and iam having the same error -> #131
Fatal error: Call to undefined function _embthumb_file_insert() in /bla/sites/all/modules/emfield/contrib/emthumb/emthumb.module on line 148

There is already an issue open for that, so please do not open new ones. Also, please do not change the status for no reason (you finding a bug does not mean that this is not a feature request).

Hi, Guys. I'm a drupal newbie, so sorry to chime in on what appears to be dev talk on the new module.

I'm not sure where else to ask, so if anyone would be so kind....

I have alpha installed on a new drupal install and it shows up fine in my modules list. all green.

Deal is, I don't see any options in permissions for it, and all I want is to embed youtube content in new nodes. I have the youtube checkbox checked in the long list of video embed option services/sites...but I don't see the embed field in my new content nodes.

Can anyone provide some charity direction? I'm probably not looking in the right area.

Thanks. -jz

@discdemo
Usually the first place to start with a new module is the README.txt file. Yours will looks like this:
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/emfield/REA...

However I'm seeing that this file is significantly lacking in installation help.

The short of it is that there are no permisions for emfield. You need to go to admin > content > content types. There you can edit the content types that you want to have video and add a new video field to them.

For future reference the best place for this type of question is the support forums.

note to self: implement http://drupal.org/node/304813 first when updating. probably won't be a problem, as the modules should be called alphabetically, but it's an easy safeguard.

I've started work on the upgrade path. It's going to be a woozy; hard to get my head around it. I want to work on that this weekend if anyone's around DrupalCampNYC: come find me!

Issues that have cropped up:

1. CCK will need to have been upgraded to 5.x-1.9 before upgrading to 6, or they may lose all their data. That's out of our control; hopefully folks read that and back up their db's before continuing. I added a note to the project page to remind them.
2. We have changed the name of the video_cck module to emvideo, and that can get really hairy. There are several cases we need to account for:
   • This is a new install. Hoorah! Do nothing.
   • They have video_cck installed, but have upgraded fully before continuing. They get a Keen Developer's Merit Badge! But we still have to change the types of field, and fix up any messes we left in Views.
   • They have video_cck installed, but didn't upgrade fully before. Unfortunately, because of our name change, we don't know they didn't upgrade fully, which means we have to manually check our tables have the proper columns in them that should have been taken care of long ago. Uggh.
3. Sadly, in any case, we don't get to do a normal upgrade anyway, because Drupal thinks this is a new installation regardless of what we've done. And I'm not sure we would normally want to take a long time to upgrade 50000 videos during the installation without our progress bar. (It might not even be possible.)

So that's the quandary we have right now. We should look at other modules that have undergone name changes for ideas. Off the top of my head is Views Bookmark to Flag. It's probably the best example to follow.

OK, off to the conference. See you guys there!

The d5-d6 upgrade path should be working now for emvideo. We'll need to update the project page for instructions:

1) MAKE CERTAIN that you have d5 fully upgraded for both CCK and emfield. Failing that could conceivably cause you to LOSE YOUR DATA (from other CCK modules too, not just emfield.) THIS NEEDS TO BE IN BOLD or whatever.
2) Follow the standard upgrade procedures for updating to d6. This includes turning off contributed modules, BACK UP your database, etc.
3) Upgrade CCK before re-enabling emfield. You'll get a warning if you try to reenable emvideo anyway.
4) Re-enable emfield/emvideo. It will run some updates on installation. You won't need to run update.php for emvideo (because, technically, it's a new module, since we've renamed the module).

I could really use some volunteers to try out the upgrade path; I only did it on a basic test installation, and not thoroughly. Obviously, back up the DB first and don't do it on a production site (unless you're certain everything worked properly).

Once this is working, we'll do the same for emimage.

Thanks!
Aaron

note when working with views hooks for emfield: read http://angrydonuts.com/attention-views-api-developers first to see what applies to what we do (since we provide our own views hooks, rather than using cck's, because of provider views).

hmmm... i realized i forgot to finish up a check during the upgrade process. it might not actually run. let me fix that quick

ah, no, that check works. it just means it's going to try to run some update stuff on new installations too. i'm pretty sure it has no real effect (except a couple of wasted CPU cycles). i still need to fix it though. if you're helping out, make sure to check from cvs, because the version from before a few minutes ago will probably white screen on you.

wow, i might better wait before upgrading to d6. i have d5 with views, cck, emfield (video), localizer, pretty much all popular modules.
i would be willing to test it....

my site is www.alizee-fanpage.com and i would just set up a new test site to test the upgrade, would i get any help from u guys if i would do so?

and whats the current status?

I'm desperate to see a safe version for 6.x

From what I can tell there is no update to change the widget info. The widget name needs to change from video_cck_textfields to emvideo_textfields in the content_node_field_instance table.

Also see http://drupal.org/node/310883 - Line 81 of emvideo.install should be: db_query("UPDATE {content_node_field} SET type='emvideo' WHERE type='video_cck'"); (no parentheses around the SET statement.)

Also I was having a problem upgrading because things like 'video_cck_bliptv_version' need to change names in the serialized data. I think that running an emfield reload from admin/content/node will probably be necessary upon upgrade.

when updating emimage, etc: read http://drupal.org/node/304813#comment-1025832

I committed lynn's changes and will release alpha3 later today.

Did the patch from #120 get committed? I am building a prototype site and need youtube integration. It is giving me this error: You have specified an invalid media URL or embed code. It seems like that was a problem and #120 was supposed to fix it. I didn't see any notifications of it being committed and it has probably bitrotted since.

I fully understand that this is alpha code and I shouldn't expect it to work perfectly.

I apologize for the bugspam. I had not enabled the youtube provider. duh!

subscribe. Thanks

I just installed alpha 3 but I still see "You have specified an invalid media URL or embed code." in emimage fields for Picsa and Flickr.
Regarding chsoney's patch in #126 --- is it apart of the module now?
What should I do?

ok, it does work for individual pictures, my bad.

however it does not for photosets.
for example:
this url is accepted:
http://www.flickr.com/photos/10069384@N05/2942652512/ (because its an individual pic)

***This url or its equivilent embed html will be allowed, but no slideshow is displayed:
http://www.flickr.com/photos/10069384@N05/sets/72157607679302723/show/

If I go to the source code of my node I can embed the html, and have the slideshow appear, so the formatting is correct.
Does anyone know how to fix this?

Subscribing.

Thanks for all your excellent work.

Emfield is still not fully ported to Drupal 6, so this needs to stay open. Emaudio and emthumb still need to be ported, though I could see us marking it as a full release without emthumb, which is going to be majorly overhauled to use filefield, but emaudio is a must before this is marked as fixed.

It is *much* easier to follow and work on the remaining tasks as their own issues. This issue is a nightmare already and the base module work has been done. The module doesn't have to be in a releasable state to close the base port issue. Seriously, pleeeease let this be closed and make new issues for remaining tasks.

So does this mean it's safe to use the embedded video function of it on a production site without fear of the official release breaking it?

I doubt that there will be any changes to the embedded video functionality before a full release that would break a site. If this was only embedded video field it would be officially released...

That's great news, I'm sure there are several people hesitant to use it on a production site for this fear.. I understand this isn't a certainty until it's officially released, but I'm still going forward with it. Thanks again

subscribing

subscribing

subscribing

This issue has been marked fixed, and will automatically close in a week or two. There is really no sense subscribing to it, as there are no plans to announce an official release on this thread, considering that won't happen until well after the thread is closed.

We're glad to have you active in development, though. If there is an issue blocking you using the module's current alpha release, you can look at that particular issue. If there is a problem you're having that doesn't have a corresponding issue, please feel free to open a new one.

Thanks,
Aaron Winborn

I have a site taxijam.co.za. I have been using youtube video but have been trying to move over to vimeo. everything works fine except that only one vimeo thumbnail shows up, any others added after that don't show up? I am using an API key.

any help would be appreciated.

Please report new problems as new issues. Please do not change the title of existing issues unless it helps to clarify the issue.