In today's episode of "there's an hour of my life I'll never get back..."

In the Spark installation profile, I attempted to create an "About Us" page in the little demo module that loads as part of the install profile: #1722802: Add an "About us" page Simple enough task, right? BZZT. WRONG. Why?

Because as dman so eloquently lays out:

spark_demo is listed as a requirement for spark : so will run its install before the spark install.
But it's the spark.install that creates a 'page' content type after that.

If I'd gotten an error such as "Invalid node type 'page'" when I called this function, I could maybe have figured this out. But with it silently doing nothing, I was completely at a loss, and dman saved my bacon.

Let's be nicer to people in this situation. :)

CommentFileSizeAuthor
#21 node_save_should-1723108-21.patch112.11 KBnitesh sethia
#15 core-throw_exception_in_node_save-1723108-15.patch3.04 KBmarcin.wosinek
#11 core-throw_exception_in_node_save-1723108-11.patch3.47 KBmarcin.wosinek
#6 core-throw_exception_in_node_save-1723108-6.patch2.79 KBmarcin.wosinek
#3 core-throw_exception_in_node_save-1723108-3.patch2.78 KBmarcin.wosinek
#1 core-throw_exception_in_node_save-1723108-1.patch1.27 KBmarcin.wosinek

Comments

marcin.wosinek’s picture

marcin.wosinek commented
Status: Active » Needs review
StatusFileSize
new core-throw_exception_in_node_save-1723108-1.patch1.27 KB

Here is patch. It works, but I'm not sure if I've put code in right place.

Status: Needs review » Needs work

The last submitted patch, core-throw_exception_in_node_save-1723108-1.patch, failed testing.

marcin.wosinek’s picture

marcin.wosinek commented
StatusFileSize
new core-throw_exception_in_node_save-1723108-3.patch2.78 KB

And now fixes for existing testes.

marcin.wosinek’s picture

marcin.wosinek commented
Status: Needs work » Needs review

Status change.

Status: Needs review » Needs work

The last submitted patch, core-throw_exception_in_node_save-1723108-3.patch, failed testing.

marcin.wosinek’s picture

marcin.wosinek commented
StatusFileSize
new core-throw_exception_in_node_save-1723108-6.patch2.79 KB

Rerolling

marcin.wosinek’s picture

marcin.wosinek commented
Status: Needs work » Needs review

Status update

Status: Needs review » Needs work

The last submitted patch, core-throw_exception_in_node_save-1723108-6.patch, failed testing.

marcin.wosinek’s picture

marcin.wosinek commented
Status: Needs work » Needs review

#6: core-throw_exception_in_node_save-1723108-6.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, core-throw_exception_in_node_save-1723108-6.patch, failed testing.

marcin.wosinek’s picture

marcin.wosinek commented
Status: Needs work » Needs review
StatusFileSize
new core-throw_exception_in_node_save-1723108-11.patch3.47 KB

Fix in patched tests; and adding one assertion to prevent nasty error we've got before (PathLanguageTest.php).

Status: Needs review » Needs work

The last submitted patch, core-throw_exception_in_node_save-1723108-11.patch, failed testing.

marcin.wosinek’s picture

marcin.wosinek commented
Status: Needs work » Needs review

#11: core-throw_exception_in_node_save-1723108-11.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, core-throw_exception_in_node_save-1723108-11.patch, failed testing.

marcin.wosinek’s picture

marcin.wosinek commented
Status: Needs work » Needs review
StatusFileSize
new core-throw_exception_in_node_save-1723108-15.patch3.04 KB

1 minor fix which seems to be unrelated, and we try again. What's funny it works locally.

alansaviolobo queued 15: core-throw_exception_in_node_save-1723108-15.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 15: core-throw_exception_in_node_save-1723108-15.patch, failed testing.

alansaviolobo’s picture

alansaviolobo commented
Issue summary: View changes
Issue tags: +Needs reroll
joburgalex’s picture

joburgalex commented

Tried to re-roll at Amsterdam2014. Unfortunately it failed and trying to find the culprit was a bit problematic.
The patch needs to be updated for files that have moved. (i.e. /core/modules/entity/lib/Drupal/entity/Tests/ is now /core/modules/system/src/Tests/Entity/).
It also uses the function node_type_save which seems to be deprecated in Drupal8. Will try and revisit this in the future.

nitesh sethia’s picture

nitesh sethia commented
Assigned: Unassigned » nitesh sethia

Working on it.

nitesh sethia’s picture

nitesh sethia commented
Assigned: nitesh sethia » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll +#drupalgoa2015
StatusFileSize
new node_save_should-1723108-21.patch112.11 KB

Rerolled the patch

Status: Needs review » Needs work

The last submitted patch, 21: node_save_should-1723108-21.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

acbramley’s picture

acbramley commented
Title: node_save() should throw an error when attempting to save a node with an invalid type » Entity storage should throw an error when attempting to save an entity with a bundle that doesn't exist
Component: node system » base system
Category: Feature request » Bug report

Surprised to see this is still an issue, and not specific to nodes (tested with block_content as well). Block content will even let you edit the entity, Node throws an error Call to a member function getPreviewMode() on null in Drupal\node\NodeForm->actions()

We should be able to throw an error at the storage level.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.