views.install needs a serious cleanup

One reason for having all this stuff in d7 was to have an easy way to port patches, but as the code is pretty stable this doesn't matter anymore.

Here is a patch with the adapted base schema.

I've always been massively confused by views_schema(). Can't we eliminate all of that and just start with a clean, normal function?

Especially if this is to go into core.

+++ b/views.installundefined
@@ -11,84 +11,13 @@ use Drupal\Core\Database\Database;
-  if (Database::getConnection()->databaseType() == 'pgsql') {
-    db_query('CREATE OR REPLACE FUNCTION first(anyelement, anyelement) RETURNS anyelement AS \'SELECT COALESCE($1, $2);\' LANGUAGE \'sql\';');
-    db_query("DROP AGGREGATE IF EXISTS first(anyelement)");
-    db_query("CREATE AGGREGATE first(sfunc = first, basetype = anyelement, stype = anyelement);");

Can you please explain why this is not needed anymore?

+++ b/views.installundefined
@@ -11,84 +11,13 @@ use Drupal\Core\Database\Database;
-  // Generate a sorted list of available schema update functions.
-  if ($get_current || empty($schemas)) {
-    $get_current = FALSE;
-    $functions = get_defined_functions();
-    foreach ($functions['user'] as $function) {
-      if (strpos($function, 'views_schema_') === 0) {
-        $version = substr($function, strlen('views_schema_'));
-        if (is_numeric($version)) {
-          $schemas[] = $version;
-        }
-      }

Why don't we want this nice schema update mechanism?

Good to know!

Going to manually test this today.

I keep losing this one.

http://drupalcode.org/project/views.git/commit/b6f5b5b

This function is chewing through memory in some tests in D7, specifically the call to get_defined_functions() is this a backport candidate?

This at least kills off the get_defined_functions() which prevents OOM locally for me at least.

Nice catch. It has definitely improved the memory utilization.

so @jibran did you tested the patch? I don't see a RTBC on this issue yet. Please try it out, ...

For some client work when I added https://www.drupal.org/project/views_datasource the site started giving memory limit error. After applying this patch the error went away. So yeah I have tested it.

Yep, tested it on a client site as @jibran eluded

We've recently switched our testing from the old qa.drupal.org to DrupalCI. Because of a bug in the new system, #2623840: Views (D7) patches not being tested, older patches must be re-uploaded. On re-uploading the patch, please set the status to "Needs Review" so that the test bot will add it to its queue.

If all tests pass, change the Status back to "Reviewed & tested by the community". We'll most likely commit the patch immediately without having to go through another round of peer review.

We apologize for the trouble, and appreciate your patience.

Re-uploading the patch.

Committed. Thanks.