Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
For the moment there's no check if the file is UTF8 or not
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-1630568
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #11
catchThis seems like a task. Moving to locale module since language system doesn't handler interface translation.
Comment #12
rootworkTagging as novice just for the issue summary update (though feel free to work on it beyond that)
Comment #14
Anjali RathodComment #15
Anjali RathodDo we have to write a test for it @catch ?
Comment #18
quietone CreditAttribution: quietone at PreviousNext commentedI have added that standard issue template. It still needs to be updated and that is suitable for a novice, leaving tag.
@Anjali Rathod, good question about tests! In nearly all cases, the answer is yes. And that is true for this issue. There are several steps, or gates, that an issue must pass before it is marked RTBC. For most issues following step 10 in the Review a patch or merge request task of the Contributor guide is sufficient. The complete list of core gates has more topics.
Comment #19
LaureatusI have made the code changes you requested and renamed the function to file_validate_encoding. I also checked with #UX and asked for some feedback on the error message. I think "The file is not encoded with UTF-8." is the best solution.
Comment #21
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedAddressed drupal CS issue of MR.