ajax_render behaves differently in regards to changing settings from hook_js_alter(). It throws away the altered copy and uses an unaltered copy.

Files: 
CommentFileSizeAuthor
#8 D7-ajax_render_alter_settings-1448796-8-do-not-test.patch1.58 KBczigor
#6 ajax_render_alter_settings-1448796-6.patch1.27 KBbalsama
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch ajax_render_alter_settings-1448796-6.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
ajax_render_alter_settings.patch1.29 KBbdragon
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch ajax_render_alter_settings.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Status:Needs review» Needs work

The last submitted patch, ajax_render_alter_settings.patch, failed testing.

ygerasimov’s picture

Status:Needs work» Needs review

Bug confirmed. Patch solves the issue. Thank you.

kenianbei’s picture

Same here, patch fixes issue for me as well.

kenianbei’s picture

ajax_render_alter_settings.patch queued for re-testing.

Status:Needs review» Needs work

The last submitted patch, ajax_render_alter_settings.patch, failed testing.

balsama’s picture

Status:Needs work» Needs review
StatusFileSize
new1.27 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch ajax_render_alter_settings-1448796-6.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Re-roll attached.

whitelikeman’s picture

I have attached the Drupal 7 version of the last submitted patch.

czigor’s picture

StatusFileSize
new1.58 KB

A reroll of #7.

mgifford’s picture

Shouldn't this be Needs Work rather than Needs Review?

Status:Needs review» Needs work

The last submitted patch, 6: ajax_render_alter_settings-1448796-6.patch, failed testing.

balsama’s picture

@mgifford Well, now it does. It passed tests 15 months ago, but obviously needs a re-roll again now. Unfortunately, there's not much motivation to re-roll it again if it's just going to languish for another 15 months :)

mgifford’s picture

Issue tags:+Needs reroll

Some issues get forgotten in the issue queues. Often it just takes a small community of folks to keep nudging it to the top.