ajax_render behaves differently in regards to changing settings from hook_js_alter(). It throws away the altered copy and uses an unaltered copy.

Files: 
CommentFileSizeAuthor
#8 D7-ajax_render_alter_settings-1448796-8-do-not-test.patch1.58 KBczigor
#6 ajax_render_alter_settings-1448796-6.patch1.27 KBbalsama
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch ajax_render_alter_settings-1448796-6.patch. Unable to apply patch. See the log in the details link for more information. View
ajax_render_alter_settings.patch1.29 KBbdragon
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch ajax_render_alter_settings.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

Status: Needs review » Needs work

The last submitted patch, ajax_render_alter_settings.patch, failed testing.

ygerasimov’s picture

Status: Needs work » Needs review

Bug confirmed. Patch solves the issue. Thank you.

kenianbei’s picture

Same here, patch fixes issue for me as well.

kenianbei’s picture

ajax_render_alter_settings.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, ajax_render_alter_settings.patch, failed testing.

balsama’s picture

Status: Needs work » Needs review
FileSize
1.27 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch ajax_render_alter_settings-1448796-6.patch. Unable to apply patch. See the log in the details link for more information. View

Re-roll attached.

balazswmann’s picture

I have attached the Drupal 7 version of the last submitted patch.

czigor’s picture

A reroll of #7.

mgifford’s picture

Shouldn't this be Needs Work rather than Needs Review?

Status: Needs review » Needs work

The last submitted patch, 6: ajax_render_alter_settings-1448796-6.patch, failed testing.

balsama’s picture

@mgifford Well, now it does. It passed tests 15 months ago, but obviously needs a re-roll again now. Unfortunately, there's not much motivation to re-roll it again if it's just going to languish for another 15 months :)

mgifford’s picture

Issue tags: +Needs reroll

Some issues get forgotten in the issue queues. Often it just takes a small community of folks to keep nudging it to the top.

mgifford’s picture

Issue tags: -Needs reroll

Well it seems that the function ajax_render() no longer exists. Closest I could find was:

core/lib/Drupal/Core/Ajax/AjaxResponseAttachmentsProcessor.php:
$this->moduleHandler->alter('ajax_render', $commands);

or maybe:

core/lib/Drupal/Core/Form/form.api.php:
function hook_ajax_render_alter(array &$data) {

So should we mark this issue as closed?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.