Closed (won't fix)
Project:
Drupal core
Version:
8.2.x-dev
Component:
comment.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 Dec 2011 at 16:45 UTC
Updated:
19 Jan 2017 at 17:12 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
agentrickardAnd a patch.
Comment #2
marcin.wosinek commentedWorks.
Patch rerolled.
Comment #3
catchThis lets you put all your comment stuff in a separate include in case comment module is disabled, but it's grouping very rare things like delete with view, so if comment module is enabled, all that code is going to be loaded again just because one is, but now with the extra overhead of an additional include etc.
I'm also not really keen in general on having hook_hook_info() implemented by every module, since it has no way at all to deal with dynamic hook names yet. Most of these hooks are or will be implemented generically by the entity system (hook_comment_load() already is), so really entity module ought to be able to dynamically handle that, but it can't, much less arbitrary things like hook_form_FORM_ID_alter().
So.. I think we should re-visit hook_hook_info() - what the patterns should be, whether we could reverse it to allow modules to explicitly register hook implementations instead (or require explicit registration which is being discussed elsewhere).
Comment #4
agentrickard@catch
#1373884: [meta] Core does not use hook_hook_info() is the meta issue. These sub-issues were all actually stalled based on sun's objections.
Comment #4.0
agentrickardChanges issue reference.
Comment #7
alansaviolobo commentedComment #8
marthinal commentedSee #2233261: Deprecate hook_hook_info groups, mark hook_hook_info() for deletion
Comment #9
kerby70 commentedAdding relationships and not in summary.
Comment #10
rpayanmComment #11
dawehnerComment #14
dpi