Document how to possible to add link options when defining local tasks and actions

It works for me - I tested by adding some 'options' to node_menu(). The class was added to /node/add links as expected.

You may need to clear your cache - changes to hook_menu implementations don't take effect until the next time the menu router is rebuilt.

I can reproduce this bug. Basically the hook_menu items array 'options' parameter is ignored for MENU_LOCAL_TASK so tabs don't behave as they should when the options are set.

"options": An array of options to be passed to l() when generating a link from this menu item.

An easy way to replicate this is with the menu_example module. add the following code at the bottom of hook_menu and the link attributes will be applied to menu items in the menu blocks, but not menu items in tabs. Attached is an image.

  $options = array();
  $options['attributes']['class'] = array('element-invisible');
  $options['attributes']['title'] = 'my title';
  foreach ($items as $path => $item) {
    $items[$path]['options'] = $options;
  }
  return $items;

I'm guesing the bug is in _menu_item_localize() but am not familiar with the menu system. Its not in the theming layer as the render array is missing the options data.

I can confirm this bug.
It doesn't work for MENU_LOCAL_ACTION either.

Subscribe.

I think this is a documentation issue. The local tasks & local actions are built entirely out of the {menu_router} table. The options array seems to be only for the actual menu links (i.e., things in the user configurable menus).

subscribe

So, have the menu system component maintainers agreed that this is a purely documentation bug? If so, could you please make an issue summary (or at least a comment saying "this is what happens and it needs to be documented here")? And then please change the component to "documentation" instead of "menu system". Because after reading this through, I'm still not sure whether it's a code or doc bug, and if doc, what needs to be documented.

Thanks!

and if its a documentation issue it is a feature request,cause the ability to add id and classes to your generated links is a pretty common need

Confirmed that it does not work for MENU_LOCAL_ACTION., Drupal 7.10.

It appears that menu_local_tasks() is looking in the menu_router table, while the options are in the menu_links table, so it will never append the options to the links. I've created a work-around which manually queries the options and merges them with localized_options:

function theme_menu_local_action($variables) {
	$link = $variables['element']['#link'];
	 
	$query = db_select('menu_links', 'l')->fields('l', array('options'))->condition('l.router_path', $link['path'])->execute();
	foreach ($query as $result) {
		$link['localized_options'] = array_merge($link['localized_options'], unserialize($result->options)); 
	}
	 
	$output = '<li>';
	if (isset($link['href'])) {
		$output .= l($link['title'], $link['href'], isset($link['localized_options']) ? $link['localized_options'] : array()); 
	}
	elseif (!empty($link['localized_options']['html'])) {
		$output .= $link['title']; 
	}
	else { 
		$output .= check_plain($link['title']);
	}
	$output .= "</li>\n";
	 
	return $output;
}

OK. For the moment, I think we should document the current behavior in Drupal 7 and 8. And then we should consider a feature request for Drupal 8 to make the tabs work with options.

Those seem like two separate issues. So I'm filing a separate Documentation issue to document the current behavior, and leaving this one as the feature request.
#1417754: hook_menu() docs need to explain that options don't work for tabs

Related, i think, is local tasks (tabs) failing to print a title tooltip text even when a description is handed in with the link, [#492380: Menu item "description" is not applied to title attribute of menu tab links]

Here's a D7 solution that works for me. Add the attributes/options to your hook_menu as expected, and add this to your theme's template.php. It will add the attributes/options from the menu_links table to your local tasks.

function MYTHEME_menu_local_task($variables) {
	$menu_item_options = db_query("SELECT options FROM {menu_links} WHERE link_path = :link_path", array(':link_path' => $variables['element']['#link']['path']))->fetchField();
	if ($menu_item_options) {
		$menu_item_options = unserialize($menu_item_options);
		$variables['element']['#link']['localized_options'] = $menu_item_options;
	}
	return theme_menu_local_task($variables);
}

Here's an example menu item:

function MYMODULE_menu() {
	$items = array();
	
	$items['member/%/like'] = array(
		'title' => 'Example Link',
		'page callback' => 'mymodule_example_page_callback',
		'page arguments' => array(1),
		'description' => t('Like this member.'),
		'access callback' => 'mymodule_example_access_callback',
		'access arguments' => array(1),
		'weight' => 81,
		'type' => MENU_LOCAL_TASK,
		'options' => array('attributes' => array('class' => array('use-ajax', 'tab-has-icon', 'icon-like', 'primary-relationship-like')))
	);

	return $items;
}

Thanks @jienckebd
I used this form for the query.

    $query = db_select('menu_links', 'm')
             ->fields('m', array('options'))
             ->condition('link_path', $variables['element']['#link']['path']);
    $menu_item_options = $query->execute()->fetchField();

We no longer have hook_menu()

We do in D7. :)

So is this possible in Drupal 8, then - and if so, how?

I just spent a little while trying to figure it out, both by adding an "options" key to the .yml file and by trying to use hook_menu_links_discovered_alter() to add it there, and haven't got anywhere with it yet - actually I couldn't even figure out how to get it to work on regular menu links either...

I've gotten it to work with regular menu links using hook_menu_links_discovered_alter() now (fun fact - if you want a Drupal 8 hook implementation to take effect, it helps if you put it in a Drupal 8 codebase, not in the Drupal 7 codebase you have running alongside it :)

But it only seemed to work for regular menu links, not action links or local tasks - so I think this issue is valid for Drupal 8.

I'm still not sure how to do any of this via the .yml files though (which is the most direct equivalent of hook_menu in Drupal 7).

Actually I would bet you can do this for local tasks and actions via hook_menu_local_tasks_alter() and hook_menu_local_actions_alter() (untested)... but that still doesn't help if you want to simply do it when defining the menu item in the first place.

You can totally do that in Drupal 8: Both \Drupal\Core\Menu\LocalTaskDefault::getOptions and \Drupal\Core\Menu\LocalActionDefault::getOptions
allows you define those entries inside the yml file (and all corresponding alter hooks).

Hm. In #20, it looks like David tried to do this and it didn't work. @David_Rothstein: Maybe you can post your YML file; @dawehner: Maybe you can post what you think should work, and we can see if we can figure this out?

Tried out

• local actions: Picture
• local tasks: https://www.drupal.org/files/issues/Screen%20Shot%202016-01-17%20at%2014...
• Add menu links: https://www.drupal.org/files/issues/Screen%20Shot%202016-01-17%20at%2014...
  Note: On both /admin and /admin/index on seven we ignore attributes on menu links due to the special core/themes/seven/templates/admin-block-content.html.twig

FYI: I was able to add a class attribute to a local task via the .yml file definition.

Here is an example of the code inside my [MODULENAME].links.task.yml, since no explicit example was provided yet in this issue:

entity.node.collaborators:
  route_name: entity.node.collaborators
  base_route: entity.node.canonical
  title: 'Manage collaborators'
  options:
    attributes:
      class:
        - 'collaborators'

Based on #32 this is a documentation task now