Problem/Motivation

When JavaScript aggregation is enabled, behaviors from me-dragula.js do not get properly attached. As a result hover classes don't get applied to controls and content becomes uneditable.

This appears to be new behavior exposed in Drupal 10.4, and likely 11.1.

Issue fork mercury_editor-3505911

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sethhill created an issue. See original summary.

sethhill’s picture

sethhill commented
Version: 2.2.x-dev » 2.1.x-dev

sethhill changed the visibility of the branch 3505911-mercuryeditor-library-needs to hidden.

sethhill changed the visibility of the branch 3505911-mercuryeditor-library-needs to active.

sethhill changed the visibility of the branch 3505911-mercuryeditor-library-needs to hidden.

sethhill opened merge request !105

pbabin’s picture

pbabin commented

Hi

We are in Drupal 10.4.2 and found ourselves in a situation where we needed to use this patch to have the .reveal-on-hover for the lpb-controls to display. Previously the library wouldn't seem to trigger.

After the patch was applied we ended up getting a console error around line 192 of /mercury_editor/source/js/preview-screen.js
let rolloverPaddingBlock = drupalSettings.mercuryEditor.rolloverPaddingBlock ?? defaultRolloverPaddingBlock;.

TypeError: undefined is not an object (evaluating 'drupalSettings.mercuryEditor.rolloverPaddingBlock')

Any recommendations?

sethhill’s picture

sethhill commented

pbabin, that looks like code from 2.2.x.

In investigating this issue I discovered an accidental commit from the 2.2.x branch into 2.1.x that brought over a bunch of unwanted changes. I removed that from 2.1.x so it should be in better shape now, and will merge this change in once tests complete successfully.

  • sethhill committed c5543213 on 2.1.x 
    Issue #3505911 by sethhill, pbabin: mercury_editor library needs...
sethhill’s picture

sethhill commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.