Closed (fixed)
Project:
Webform
Version:
6.3.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Nov 2024 at 19:49 UTC
Updated:
20 Dec 2024 at 15:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dmundraThe 1.0.3 and 1.0.2 releases on https://github.com/drgullin/icheck/releases are returning 404s. Might need a work around.
Comment #3
aluzzardiSame here.
My suggestion is to move from getting from github and pull it from asset.packagist.org:
https://asset-packagist.org/package/bower-asset/icheck
For now, adding this to you repositories array on your root composer.json should will solve:
Or replacing the url: https://codeload.github.com/drgullin/icheck/zip/1.0.2/tags/1.0.2
On your composer.lock to: https://api.github.com/repos/drgullin/icheck/zipball/8a6eb37bd7dab1e843c...
Comment #4
dmundraGitHub issue https://github.com/drgullin/icheck/issues/440
Thanks @aluzzardi. I will try that.
Comment #6
dmundraAttaching a patch of the MR https://git.drupalcode.org/project/webform/-/merge_requests/561
Comment #7
dmundraAdding the package to composer.json didn't work because the wikimedia/composer-merge-plugin would still override with the webform version.
The patching of the upstream file in the webform module also didn't work for our project as the patch is applied to late.
Comment #8
dmundraHiding patch file.
Comment #9
themodularlab@aluzzardi,
#3 works for me. Thanks!
Comment #10
kmontyNot to hijack this, but this would be a good opportunity to upgrade to 1.0.3 as well. The release being used with iCheck is from 2014.
Comment #11
rkelbel48 commentedYep same,
Swapping over the url to https://api.github.com/repos/drgullin/icheck/zipball/8a6eb37bd7dab1e843c...
mentioned in #3 worked for me as well.
Comment #12
lisa.rae commentedRan into the same issue on a client project today. In my case, the only submodule of the Webform module that was actualy being used was the
webform_togglemodule, which depends on thejquery/toggles:^4.0library.But the client had included the entire
composer.libraries.jsonfile from the Webform module in their main projectcomposer.jsonfile, which proved problematic to just remove.Here's how I solved this issue:
1. I reviewed the webform submodules that were enabled on the site, and identified the javascript libraries that were actually being used in the project.
2. I removed the webform module from the
composer.jsonfile withcomposer remove drupal/webform3. I then deleted the merge-plugin include for the webform
composer.libraries.jsonfile from the project's maincomposer.jsonfile, and then executedcomposer update --lock4. I then reinstalled the webform module with
composer require drupal/webform:^6.25. I took the package repository reference for the
jquery/toggleslibrary from the webformcomposer.libraries.jsonfile and placed it in the "repositories" section of the maincomposer.jsonfile for the project, and rancomposer update --lock6. I then executed
composer require jquery/toggles:^4.0to install the javascript library needed for the submodule to operate.Opened a pull request against the project, and the client merged it in late this evening.
This step by step process should work for any project EXCEPT the
jquery/ichecklibrary, The issue at hand is that the archive zip and tarball files for the release required by the Webform'scomposer.libraries.jsonfile are missing from Github. Version 1.0.1 however, still has the release zip and tarball files on Github when I checked earlier today, so you could include thejquery/icheckpackage repository reference, change the version to 1.0.1 instead of 1.0.2, and you should get a workable javascript library. Check the release notes for the 1.0.1 vs 1.0.2 release to see what changed before you do.For safety's sake, just in case the release tarbal and zip files get removed for release 1.0.1, you might consider manually installing the library into your project's library directory and committing the source code to your code repository to keep from losing it again. Just a thought.
Hope this helped someone.
Comment #13
smustgrave commentedThink this can be elevated as this is probably breaking a number of pipelines.
Comment #14
ambot112 commentedThe plain diff from mr is not working because it is pointing to line 157. For the meantime, this plain patch might help.
Comment #15
monymirza#14 working.
Comment #16
gouthamraon commented#14 worked for me. Thanks for the patch @ambot112.
Comment #17
mjgruta commentedFYI, if you already have a composer.lock file. The patch will not work so you need to override it by adding this code to your composer.json or better if you have composer.libraries.json file then add this on the require section "jquery/icheck": "1.0.2".
After this just run composer require drupal/webform:^6.2 or what ever version you would like. This will generate the correct composer lock hash.
Comment #18
omarlopesinoLooks like as the username changed from dargullin to drgullin the download links are broken. Seems a temporary issue.
Alternatively to the patch, I suggest another solution that is only valid when the library is not being used in the project: adding the library to replace.
For example:
Comment #19
suresh.senthatti commentedThis patch is for current 6.2 release
Comment #20
yannickooFYI after applying the patch it was needed to run
composer update jquery/icheckso that the new URL of the libraries is changed incomposer.lockfile as well ✨Comment #21
daniel.pernold commentedWe are using projects with OpenSocial and are therefore stuck with Webform 6.1.8 atm. The only solution that works for us in this case is placing the following in our
composer.json.Comment #22
miksha commented#14 worked for us to! Thanks.
Comment #23
mattgh9152 commented#14 also worked for me, #19 did not work even though I was on webforms 6.2
Comment #24
emek commented#14 works for us, we use Webform 6.2.7
Comment #25
bramdriesenRE #10 It might be better to look into deprecating/replacing the use of this. It really looks abandoned as there has been no activity for over 4 years on the project since the last release.
Comment #28
jrockowitz commentedI am going to merge this and backport it to 6.2.x
Comment #31
jrockowitz commentedComment #32
luke.leber+1 on deprecating the library.
The maintainer was explicitly presented with a dialog explaining what changing their username entails. They chose to do this despite the warnings about downstream chaos it would create.
To me, that means they probably shouldn't be an upstream dependency if such a change was made on a whim in this age of supply chain attacks.
Comment #33
jaydarnell#14 worked for me on Webform 6.2.7. Thanks!
Oh, and hi dmundra!
Comment #34
bramdriesenI created a follow up to try to deprecate the use of this plugin. (RE #32 & #25)
#3489932: Move deprecated modules into webform_deprecated
Comment #35
dmundraHey @jaydarnell
Thank you @jrockowitz for merging and releasing a new version. Appreciate that.
Comment #36
tony.sayge commented@jrockowitz thank you so much for releasing a new version! Huge time-saver.
Comment #37
trevorbradley commented6.2.8 doesn't include https://www.drupal.org/files/issues/2024-11-26/webform-icheck-library-is....
I'm still getting deploy fails with the call in webform_icheck.module:
Trying to patch webform in addition to the 6.2.8 update to see if that fixes the issue...
Comment #38
trevorbradley commentedNope, user error here. webform_icheck_webform_libraries_info() is just fine (especially when uninstalled).
Folks, a note it's important to run a composer update --lock to make sure composer.lock correctly links to the right library.
Comment #39
aluzzardiAnother important thing is that before you run the composer update --lock, if you are using the patch for version 6.2.7 remove the library from the libraries folder, otherwise it will not get the updated URL.
Composer need to detect that is missing to download and update the from the new URL.
I tried only the composer update --lock and was still having the issue, if you do not want to remove it, you can go to the composer.lock file and change the URL manually.
Comment #40
pierrepaul commentedI was curious if I could create a github account with the previous username, then create a new repository with the same name with the same tags. Turns out github blocks you at the repository creation (user creation worked). Which is good, anyone could have bundled anything in that package.
Comment #41
dimiter commentedI just wanted to mention that the solution of #20 by @yannickoo works fine when still receiving 404-errors after updating Webform to 6.2.8 :
That looks like the proper solution, instead of deleting lockfiles as mentioned above.
Comment #42
dmundraFYI, I had reached out to GitHub support about this issue and they fixed the original 404 for the URLs so https://github.com/dargullin/icheck/archive/refs/tags/1.0.2.zip should be working again.