Problem/Motivation

Remove deprecated code in the render system

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3441392

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone opened merge request !7534

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Active » Needs work
Issue tags: +Deprecation Removal, +Major version only

Binoli Lalani made their first commit to this issue’s fork.

Binoli Lalani’s picture

Binoli Lalani CreditAttribution: Binoli Lalani at QED42 for Drupal India Association commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work

Searching for deprecated and 11.0

Appears to be another instances in HtmlResponseAttachmentsProcessor

Binoli Lalani’s picture

Binoli Lalani CreditAttribution: Binoli Lalani at QED42 for Drupal India Association commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work

Left some comments.

pradhumanjain2311 made their first commit to this issue’s fork.

Binoli Lalani’s picture

Binoli Lalani CreditAttribution: Binoli Lalani at QED42 for Drupal India Association commented
Status: Needs work » Needs review

Hello,

Thank you for reviewing the code. I have updated the code as per the comment on MR. Please review.

Thank you!

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Needs work

The UrlGenerator tests should not be removed here, they are being done in #3425294: Remove deprecations for UrlGenerator methods

Binoli Lalani’s picture

Binoli Lalani CreditAttribution: Binoli Lalani at QED42 for Drupal India Association commented
Status: Needs work » Needs review

Hello,

I have reverted UrlGenerator code. Please review.

Thank you!

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work

Believe the deprecation tests are still there.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Needs review

Fixed up the MR, all green.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer and at Four Kitchens commented
Status: Needs review » Reviewed & tested by the community

Looks like all feedback has been addressed here, The removal looks good to me as well.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Reviewed & tested by the community » Needs work

Needs rebase, added some comments about property promotion, and this can be removed too:

  use DeprecatedServicePropertyTrait;

  /**
   * Defines deprecated injected properties.
   *
   * @var array
   */
  protected array $deprecatedProperties = ['cacheTagInvalidator' => 'cache_tags.invalidator'];
smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Needs review

Addressed feedback.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer and at Four Kitchens commented
Status: Needs review » Reviewed & tested by the community

Ugh, I missed those, thanks. Feedback addressed. Back to rtbc

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs work

Couple more questions on the MR.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Needs review

Address feedback.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs review » Needs work

Still one remaining I think.

andypost made their first commit to this issue’s fork.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Needs review

Hope now it ready