Problem/Motivation
In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.
This issue is to convert \Drupal\views\Annotation\ViewsDisplay
plugins to use Attributes.
To do that we need #3421008: Convert ViewsExposedForm plugin discovery to attributes first. This issue is postponed on that.
Proposed resolution
- Add a class to represent the new Attribute - Example
- Update the plugin manager constructor to include both the attribute and annotation class names - example
- Convert all plugins that use the annotation to use the new attribute - example
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#12 | Screenshot 2024-03-18 at 10.58.16 AM.png | 122.05 KB | smustgrave |
Issue fork drupal-3421002
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
larowlanComment #3
larowlanComment #4
alexpottComment #7
sorlov CreditAttribution: sorlov at Skilld commentedComment #8
sorlov CreditAttribution: sorlov at Skilld commentedComment #9
smustgrave CreditAttribution: smustgrave at Mobomo commentedMR needs to be rebased. Also MR is in draft.
Comment #11
sorlov CreditAttribution: sorlov at Skilld commentedComment #12
smustgrave CreditAttribution: smustgrave at Mobomo commentedSeems there are still some using annotations
Comment #13
Ruturaj ChaubeyComment #14
smustgrave CreditAttribution: smustgrave at Mobomo commentedSeems remainder have been addressed
Comment #15
alexpottCommitted and pushed a52189b391 to 11.x and cca3f394eb to 10.3.x. Thanks!