Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\views\Annotation\ViewsDisplayplugins to use Attributes.

To do that we need #3421008: Convert ViewsExposedForm plugin discovery to attributes first. This issue is postponed on that.

Proposed resolution

  1. Add a class to represent the new Attribute - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3421002

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan created an issue. See original summary.

larowlan’s picture

larowlan’s picture

alexpott’s picture

Title: [PP-1] Convert ViewsDisplay plugin discovery to attributes » Convert ViewsDisplay plugin discovery to attributes
Status: Postponed » Active

sorlov made their first commit to this issue’s fork.

sorlov’s picture

Status: Active » Needs work
sorlov’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Needs work

MR needs to be rebased. Also MR is in draft.

Ruturaj Chaubey made their first commit to this issue’s fork.

sorlov’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Needs work
FileSize
122.05 KB

missing

Seems there are still some using annotations

Ruturaj Chaubey’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Seems remainder have been addressed

alexpott’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed a52189b391 to 11.x and cca3f394eb to 10.3.x. Thanks!

  • alexpott committed cca3f394 on 10.3.x
    Issue #3421002 by sorlov, Ruturaj Chaubey, smustgrave, larowlan: Convert...

  • alexpott committed a52189b3 on 11.x
    Issue #3421002 by sorlov, Ruturaj Chaubey, smustgrave, larowlan: Convert...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.