Problem/Motivation

hook_help function missing in .module file

CommentFileSizeAuthor
#8 weight_help_page.png222.3 KBparaderojether
#8 after patch.png46.2 KBparaderojether
#8 before patch.png40.69 KBparaderojether

Issue fork weight-3335816

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jay Jangid created an issue. See original summary.

Jay Jangid opened merge request !8

Jay Jangid’s picture

Jay Jangid CreditAttribution: Jay Jangid at Dotsquares Ltd. commented
Assigned: Jay Jangid » Unassigned
Status: Active » Needs review

Created MR , please review.

Thank you.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Title: hook_help function missing in .module file » Implement hook_help()
renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Status: Needs review » Needs work

Thanks a lot. This is definitely the first step but I think we can improve the hook_help, because in this first version we have basically the title and description of Weight, but if the user is seeing the help section mens that the Weight was installed so probably the user already read it before so it won't be so useful for editors, you know?
IMHO I think we can put some more steps with example about how to use the "Weight" project inside of CMS

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Status: Needs work » Needs review

'

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented

MR updated with the suggestion above to help the content editors: https://git.drupalcode.org/project/weight/-/merge_requests/8

paraderojether’s picture

paraderojether CreditAttribution: paraderojether at Promet Source commented
Status: Needs review » Reviewed & tested by the community
FileSize
before patch.png40.69 KB
after patch.png46.2 KB
weight_help_page.png222.3 KB

I reviewed MR!8, I applied it on my local and it looks good to me. Drupal core 9.5.7, Weight 8.x-3.x-dev

I added screenshots for reference.
Thank You.

Neslee Canil Pinto made their first commit to this issue’s fork.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Ramsalt Lab for Drupal India Association commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.