Drupal 10 preparations.

Issue fork message-3314593

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Rajeshreeputra created an issue. See original summary.

Rajeshreeputra opened merge request !9

Rajeshreeputra’s picture

Rajeshreeputra
Location Pune
CreditAttribution: Rajeshreeputra as a volunteer and at Shivswarajya Inc. for Shivswarajya Inc. commented
Title: Drupal 10 preparation » Drupal 10 rector issue fixes
Rajeshreeputra’s picture

Rajeshreeputra
Location Pune
CreditAttribution: Rajeshreeputra as a volunteer and at Shivswarajya Inc. for Shivswarajya Inc. commented
Status: Active » Needs review
mmjvb’s picture

mmjvb CreditAttribution: mmjvb as a volunteer commented

Any reason to leave minimum-stability in, being a root setting?

Rajeshreeputra’s picture

Rajeshreeputra
Location Pune
CreditAttribution: Rajeshreeputra as a volunteer and at Acquia, Shivswarajya Inc. commented

Not sure, it's already there, and this issue is created for porting module to D10. If minimum-stability needs to be removed then that should be separate issue.

mmjvb’s picture

mmjvb CreditAttribution: mmjvb as a volunteer commented

Sorry, my mistake. It is correcting license, not removing. Still not related to deprecations of D10.

What makes removing license key different from minimum-stability.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Smithsonian Institution commented

It looks like most of the test fails are due to this error:

 Drupal\Tests\message\Functional\MessageEntityDelete::testReferencedEntitiesDelete
Drupal\Core\Extension\Exception\UnknownExtensionException: Unknown themes: stable.
Rajeshreeputra’s picture

Rajeshreeputra
Location Pune
CreditAttribution: Rajeshreeputra as a volunteer and at Acquia, Shivswarajya Inc. commented

@jhedstrom, MR from #3314596: Tests fail on D10 due to missing theme already has updated theme from stable to claro which allows passing all the test, anyway I have updated the same here as well.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Smithsonian Institution commented
Status: Needs review » Fixed

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.