Prepare for Drupal 10 compatibility:
web/modules/contrib/recreate_block_content/recreate_block_content.info.yml 0 Value of core_version_requirement: ^8 || ^9 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687..
web/modules/contrib/recreate_block_content/composer.json 0 The drupal/core requirement is not compatible with the next major version of Drupal. Either remove it or update it to be compatible. See https://drupal.org/node/2514612#s-drupal-9-compatibility..
web/modules/contrib/recreate_block_content/recreate_block_content.module 72 Call to deprecated method findConfigEntityDependents() of class Drupal\Core\Config\ConfigManager. Deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Instead you should use ConfigManagerInterface::findConfigEntityDependencies().| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3312561.recreate_block_content.drupal10_compatibility.patch | 1.37 KB | dvym |
Issue fork recreate_block_content-3312561
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3312561-drupal-10-compatibility
changes, plain diff MR !1
Comments
Comment #2
dvym commentedAdding patch to make the module D10 Compatible.
Drupal 10 Compatibility
Comment #3
jcnventuraNice.. Can you please completely remove the composer.json require section, instead of duplicating the information in two places? That information in composer.json is irrelevant at this moment, since the Drupal packagist will replace that with the information from the info.yml file.
Comment #6
johnpicozziThe above MR updates the code based on the above comments. Based on this moving this to needs review.
Comment #7
jcnventuraThanks for the MR. As per https://www.drupal.org/node/3225357, the call to findConfigEntityDependencies() restricts this to Drupal 9.3 or newer.
Comment #8
roaldnel commentedThanks for the work you have done on this so far! Will this be merged soon by chance? We would really appreciate that...
Comment #9
svitlana commentedI tested on drupal 10 and it works fine. MR looks also good.
Comment #10
norman.lolComment #11
pcate commented+1 RTBC. The patch applied cleanly and fixed all D10 compatibility issues.
Comment #13
nickdickinsonwildeThanks y'all. Merged into a new branch (3.0.x). Will have a release out later today
Comment #14
norman.lolThe new branch name is wrong. It needs to be 3.x. With 3.0.x you would be able to only have patch version releases.
Comment #15
nickdickinsonwildePer https://www.drupal.org/node/3108648 either form is acceptable. One of the biggest audience Drupal modules - Webform also uses #.#.x branches (aside, I think 6.1.x to 6.2.x should've gone to 7.0.x instead because removing supported core versions is a BC change that should be a Major version not a minor version but not really relevant).
Do you have some documentation/other projects that make you think there is a significant standardization around #.x branches for contrib modules? Drupal core goes for #.#.x branches - definitely, core has a lot more patch releases with no new features than most modules. Eh I can see your point after writing all that out. hah. Thanks for the thought. Given the velocity of this project I'm not really concerned - but will think about it for other modules for sure.