Problem/Motivation

The module README has the necessary information for contributing, but the last step of running yarn build for committing the changes is not included.

Steps to reproduce

Proposed resolution

Add yarn build step.

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?

Issue fork project_browser-3296324

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ressa created an issue. See original summary.

ressa opened merge request !200

ressa’s picture

ressa CreditAttribution: ressa at Ardea commented
Status: Active » Needs review
omkar-pd’s picture

omkar-pd CreditAttribution: omkar-pd at QED42 for Drupal India Association commented
Status: Needs review » Reviewed & tested by the community

LGTM!

chrisfromredfin made their first commit to this issue’s fork.

  • chrisfromredfin committed d6d1e77 on 1.0.x authored by ressa 
    Issue #3296324 by ressa, chrisfromredfin, omkar-pd: Update Contributing...
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
CreditAttribution: chrisfromredfin at Redfin Solutions, LLC commented
Status: Reviewed & tested by the community » Fixed

Good improvement. I also put a note in there about the existence of contributor.md which has more detailed instructions.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.