Automated Drupal 10 compatibility fixes - Scheduler 2.x

I will review this patch.

Using the 'upgrade_status' module I got some errors that are not compatible with Drupal 10.
So, I worked on it and hence provided a patch.

Please Review.

Since ModuleHandler::getImplementations was removed, SchedulerManager::getHookImplementations and all places where it's invoked will need to be refactored to immediately execute the hook implementation instead of collecting them all first. Just replacing getHookImplementations with invokeAllWith - as done in the patch - is unfortunately not enough.

ModuleHandlerInterface::getImplementations() is deprecated in drupal:9.4.0 and is removed from drupal:10.0.0. Instead you should use ModuleHandlerInterface::invokeAllWith() for hook invocations, or you should use ModuleHandlerInterface::hasImplementations() to determine if hooks implementations exist. See https://www.drupal.org/node/3000490

I think a good option would be to change getHookImplementations to getHooks, like this:

public function getHooks(string $hookType, $entity) {
  $entityTypeId = (is_object($entity)) ? $entity->getEntityTypeid() : $entity;
  $hooks = [$hookType, "{$entityTypeId}_{$hookType}"];
  // For backwards compatibility the original node hook is also added.
  if ($entityTypeId == 'node') {
    $legacy_node_hooks = [
      'hide_publish_date' => 'hide_publish_on_field',
      'hide_unpublish_date' => 'hide_unpublish_on_field',
      'list' => 'nid_list',
      'list_alter' => 'nid_list_alter',
      'publish_process' => 'publish_action',
      'unpublish_process' => 'unpublish_action',
      'publishing_allowed' => 'allow_publishing',
      'unpublishing_allowed' => 'allow_unpublishing',
    ];
    $hooks[] = $legacy_node_hooks[$hookType];
  }
  // Get all modules that implement these hooks, then use array_walk to append
  // the $hook to the end of the module, thus giving the full function name.
  foreach ($hooks as &$hook) {
    $hook = "scheduler_$hook";
  }
  return $hooks;
}

and invoked like this:

// Allow other modules to add to the list of entities to be published.
$hooks = $this->getHooks('list', $entityTypeId);
foreach ($hooks as $hook) {
  $this->moduleHandler->invokeAllWith($hook, function (callable $hook, string $module) use (&$ids, $process, $entityTypeId) {
    // Cast each hook result as array, to protect from bad implementations.
    $ids = array_merge($ids, (array) $hook($process, $entityTypeId));
  });
}

Thanks for the suggestion @DieterHolvoet.
Will try that.

Hi JatinGupta40 and DieterHolvoet,
I think it would be better if you raised separate issues for the things you are working on, and link them from this issue.
As far as I understand, this issue was created and will be updated by the automated Project Update Bot, so it would be better if your manual changes were isolated in other issues.
Also if we are going to take any of the fixes from the automatic patches then those should be split off into separate issues too.

I've created a separate issue for the module handler hooks
#3312069: ModuleHandlerInterface::getImplementations() is deprecated in 9.4

Set to Active to prevent reviews as maintainer committed.

Thanks. Yes everything that can be committed from the automated patches is done. The next automated patch will again try to change the eventDispatcher->dispatch parameters. It will be interesting to see if anything else gets automated.

As per comment in #20 the eventDispatcher->dispatch parameter is correct and must not be chnaged as per the automated patch in #22. Is there a way to state this in the code, to prevent the patch being repeatedly added?

The ticket description says removing a tag will work to stop all bot activity going forward:

If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then).

Since this was the only thing the bot found, removing the tag and marking this fixed seems fine? But I'll leave that choice to you @jonathan1055

I was leaving the issue open in case the bot reports anything new. But I do not know how or if the bot is being updated to report new things. I will leave open for now, but if you have any info on whether the bot is being updated or expanded then let me know. Thanks.

10.x compatibility has been done