[META] Drupal 10 preparation

Thanks for starting this off. Yes we can prepare for D10.
Because Scheduler 2.0 will be compatible with D8 and D9 (and I'm not dropping D8 support any time soon) we need to work out what release or version D10 compatibility will come in. I don't think there is any great hurry to commit this yet.

Yes you are right that the patch needs a re-roll.

#3042677: Drupal 9 Deprecated Code Report for Scheduler is not related, there was no recent commits on that issue, I just closed it as fixed.
#3311425: Replace warning for no entity type with an explanation in the menu is not related, there is no conflict with this patch.

However #3289475: Automated Drupal 10 compatibility fixes - Scheduler 2.x is related, as that is where the deprecation fix commits originated from.

The only other Drupal 10 deprecation remaining at this point is
#3312069: ModuleHandlerInterface::getImplementations() is deprecated in 9.4

I have created a branch and pushed everyting from your initial patch except the fixes that have already been done. This won't run at D10 yet, but we should see the same problems as you found in the patch test. Then we can go from there.

There's something up with gitlab, the MR does exist https://git.drupalcode.org/project/scheduler/-/merge_requests/60 but it is not being shown at the top of this issue. Signing in to gitlab fails atm, so maybe that's the problem.

Running with PHP8.1 is required for D10, of course. So ignore the PHP7.4 test run.

Devel Generate 5.x is required for D10
Workbench Moderation and Workbench Moderation Actions do not exist for D10 yet, and probably never will. So we might need to drop testing those at D10 but maintain the tests somehow when running D9. Anyway, that's for later.

The 9.4 test will fail because I dropped the two Workbench Moderation modules.

Removing the related 'automated' issue as that is a child issue now.

Yes, see my comment in #6 and the linked issue.

"a combined patch"
I'm not sure what you mean, as there is no patch on that other issue. I have run the full test suite on Travis with deprecations not suppressed, and there are no other deprecations listed in the Scheduler code.

Testing at D10 will mean we have to drop testing with workbench_moderation because that module does not yet have a D10 version (and is unlikely to, given that content moderation is now in core). But the scheduler 2.x branch can still support workbench_moderation, so we could conditionally include the workbench tests when testing at D9 only.

I think combine patch means, having all issue fix here in one MR and use patch https://git.drupalcode.org/project/scheduler/-/merge_requests/60.patch to test overall D10 readinesses.

Reviewed and tested, this works best with MR created in issue #3312069, hence RTBC.

It is not RTBC when there are test failures. This is the parent issue for D10 compatibility so it will only be completed when all the child issues are done. The merge request on this issue (MR60) makes the version and requirements changes to allow testing at D9 and D10 to show the current state of the work.

Following the fixed issues:
#3312069: ModuleHandlerInterface::getImplementations() is deprecated in 9.4
#3313848: Specify accessCheck(TRUE/FALSE) in entity queries
#3314267: Workbench Moderation tests cannot be run at D10

we have just one problem left to solve:
#3314158: Update javascript default time to use core/once for D10

Hi @ jonathan1055
Looks like all CI is passing with Drupal 9, 10 etc. Any plan for making this merge back to 2.x-dev and next RC or Stable release ?

Temporary change to have suppress-deprecations: false in the three phpunit runs. Just as final check before commit.

Merged and Fixed. Thank you all for your contributions.

I need to work on one other Scheduler issue and will then release 2.0-rc6. Hopefully this will have no problems, then Scheduler 2.0 will follow in a couple of weeks.

Weirdly, after the commit, the 2.x branch test fails at D10 with composer requirements failure. From the log we have:

Adding testing (require-dev) dependencies.
Composer Command: sudo -u www-data /usr/local/bin/composer require 'drupal/commerce:^2.0' 'drupal/devel_generate:>=4' 'drupal/rules:^3' 'drupal/workbench_moderation:*' 'drupal/workbench_moderation_actions:*' 'drush/drush:>=9' --prefer-stable --no-progress --no-suggest --working-dir /var/www/html

drupal/workbench_moderation[dev-1.x, 1.6.0, ..., 1.x-dev] require drupal/core ^8.8 || ^9 -> satisfiable by drupal/core[8.8.0-alpha1, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev]

But the workbench_moderation modules have been deleted from the project's composer.json. That was done in an earlier commit. The MR branch ran cleanly at D10 so I do not know why it is still trying to load those modules.

Following the above commit in #30 the branch test now passes at D10. The workbench_moderation dependencies were still in scheduler.info.yml and it is a quirk of how drupalci re-evaluates changed dependencies on patch tests and MRs - if composer.json is changed then it is respected and anything from .info.yml is ignored. But when a branch test is run the dependencies from both composer.json and .info.yml are amalgamated. This is why the MR passed at D10 but after committing, the branch test failed.

This issue is marked Fixed (and will become closed) as all known work is done as far as we know. However the two automated bot issues should remain open in case they find anything new.

I have released 2.0.0-rc6 which includes full Drupal 10 compatibility.

Providing there are no problems reported I will release Scheduler 2.0.0 in the week starting 7th November (two and half weeks after rc6)

For info, I am also working on Drupal 10 compatibility for the 8.x-1.x branch
#3331246: Drupal 10 compatibilty for Scheduler 8.x-1.x